fix(web): pull requests error names the environment that failed#27882

Problem

When one environment the Pull Requests page reads from is unreachable (for example a T3 Connect machine that is shut down), the page shows a warning such as "Relay could not reach the environment endpoint (endpoint_request_failed). Showing the last pull requests loaded." It does not say which environment failed, so it reads as if pull request loading is broken in general, and pressing Retry brings the same unexplained banner straight back.

Reproduced on main (26dc3688e2) in the web app. Server A (local, many open PRs) was paired with a second server B, each with one project, and the PR page was opened with all servers. B was then stopped and a new search started. A's rows still listed, but the banner gave only B's transport error with no environment name, and Retry showed the identical banner again.

Change

createMergedEnvironmentQuery in apps/web/src/state/pullRequests.ts used to keep only the first failure's message. It now keeps that failure as { environmentId, message }. The Pull Requests page turns the id into the environment's label and shows <label>: <message>, in both the warning banner (rows shown) and the "Could not load pull requests" state (no rows shown). This is the same format and the same "Environment" fallback the mobile PR list already uses. Which environments are queried and what Retry does are unchanged.

Scope and approval

Fixes pingdotgg/t3code#27821

Verification

• apps/web/src/state/pullRequests.test.ts › "names the environment whose list failed while the others' rows still show": fails on main (the error is a bare string with no environment) and passes with the fix. The file passes 21/21.
• vp run check:changed passes on the head (format, lint, knip, typecheck, tests, react compiler).

Takeover

No code changes; evidence and verification added below. The earlier evidence (captured at bcf47b6896 against 26dc3688e2, with GitCafe-only attachments and no scripts) is replaced by a fresh matrix captured at the current head.

Evidence

Before = cb9629e689 (merge-base), After = c60e8ba864 (head). Fixture matrix: matrix.md (9 rows). Full gallery with every checkpoint, sheet and diff: index.html.

Environment: Linux x86_64, headless Chromium 148.0.7778.96 over CDP (agent-browser), no device emulation, DPR 1, 100% font scaling, reduced motion, Date frozen at 2026-11-03T04:00:00Z, sidebar collapsed, scroll origin. REAL rows: two dev servers on fresh databases (T3CODE_DEV_SEED=0); A (fs-32) on pingdotgg/t3code, B (labelled Remote B — issue 27821) on a separate synthetic repo, both loaded and targeted, then B stopped. These are direct connections, not T3 Connect. HARNESS rows mount the real PullRequestsPage with controlled per-environment results for states the app cannot be seeded into.

Diffs: Diff0 = absolute RGB delta ×16, threshold 0. DiffT = magenta where max channel delta >16/255.

Recordings (same script on both sides; timestamps are seconds into each recording):

• P07 (REAL, 1440×1000 dark): healthy list; B stopped ~1.1 s; new search ~2.1 s; failure banner ~3.5–3.8 s; banner Retry ~5.7–6.0 s; same failure again ~7.0–7.3 s; Filters → Server → fs-32 ~8.0–8.8 s; banner gone ~9.7–10.0 s. before-P07.mp4 · after-P07.mp4
• P08 (REAL, 1440×1000 light): centred failure; Retry ~1.1 s (busy, disabled); failure returns ~2.3–3.6 s; Filters → Server → fs-32 ~3.4–5.1 s; ordinary empty result. before-P08.mp4 · after-P08.mp4
• P09 (HARNESS, 1440×1000 dark): A, B, C targets; C fails first ~0.1 s; B fails later with blank message ~1.6 s; B recovers ~4.3 s; C fails with a non-Error cause ~7.0 s. The prefix follows the first failing target. before-P09.mp4 · after-P09.mp4

What else changed (beyond the added <label>: prefix):

• Warning with rows (P01, P07): text wraps differently; banner height and Retry position unchanged at 1440. At 390 (P03) the long label adds two lines: banner grows 32px, Retry moves down 16px.
• Centred error (P02, P08): description gains one line; icon and title move up 10px, Retry down 10px. At 390 (P04): two lines, 20px each way.
• P05/P06: missing and empty label maps render byte-identically (Environment:). P06 also changes a few title glyph pixels, consistent with fractional horizontal centring of the wider block.
• Healthy and recovered checkpoints (P07, P08): zero changed pixels at threshold 0. No settled comparison changes pixels outside its error region (counts in the manifest).

Scripts and rebuild inputs (uploaded, not committed): REPRODUCTION.md · manifest.json · all scripts (tar.gz) · seed.mjs · harness.mjs · record-p07.mjs · record-p08.mjs

🤖 Generated with Claude Code