fix(web): settle undo notice no longer covers the thread above it#25548

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

External image Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 3f94487
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7b959ebe-6f4e-442a-90c4-88948ded7f45

External image Commits

Reviewing files that changed from the base of the PR and between 3f9448747bb8848050dc2cacf83affa6f94a66a1 and 29a45a8343f0ecd650724441d0449d64f50ee792.

External image Files selected for processing: 1

• apps/web/src/components/sidebar/SidebarListMarkers.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

SidebarSectionHeader no longer uses a fixed-height, positioned marker container. When hostsUndoNotice is true, the undo notice renders directly in the marker instead of being absolutely positioned above the header.

Changes: Sidebar marker layout

Layer / File(s)	Summary
Marker and undo notice layout apps/web/src/components/sidebar/SidebarListMarkers.tsx	The marker no longer uses relative positioning or a fixed height. The undo notice renders directly in the marker when hostsUndoNotice is true.

Priority: External image Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related issues

• pingdotgg/t3code#23949 — This issue describes a short-lived undo notice obscuring the list. This change renders the notice in the marker instead of as an overlay.
• pingdotgg/t3code#24242 — This issue describes a Settled thread notification covering the thread list. This change also changes the undo notice from overlay positioning to direct marker rendering.

Possibly related PRs

• pingdotgg/t3code#25270 — This PR introduced the overlay placement that this change removes.
• pingdotgg/t3code#23517 — Both changes address sidebar row interactions after list changes, using different approaches.

Suggested reviewers: maria-rcks

The sidebar layout change is mergeable based on the reviewed evidence.

^Failed Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check	Warning	The description follows the template in most areas. The Problem section explains the overlay that hides the last thread title for 5 seconds, and the Change section explains the 24px bottom shelf behav…	Add a link to the triaged bug issue or to the maintainer discussion that approved revisiting the #25270 overlay decision, including the approval comment. Without that approval, explain why this fix qualifies as a very small, focused fix of …

^Passed Passed checks: 3 passed

Check name	Status	Explanation
Title check	Passed	The title names the main change: the settle undo notice no longer covers the thread above it. It uses the conventional commit form with a clear scope, and it matches the objective of moving the notice…
Linked Issues check	Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	Passed	Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: the settle undo notice no longer covers the thread above it. It uses the conventional commit form with a clear scope, and it matches the objective of moving the notice to its own line above the bottom shelf. It is specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description follows the template in most areas. The Problem section explains the overlay that hides the last thread title for 5 seconds, and the Change section explains the 24px bottom shelf behavior. The Scope and approval section links the follow-up to #25270 and explains why the overlay is revisited. The Verification section reports a manual check in the dev app with screenshots, plus format, lint, and typecheck results, and it states that the full test suite was not run. The description does not link an approved triaged issue or a maintainer approval comment, so the scope requirement is only partly met. It also does not name the model and harness, which the template asks for when an agent was used. The description also says the author revisits behavior kept on purpose in #25270, which the template treats as a behavior change that needs explicit maintainer approval.

Resolution

Add a link to the triaged bug issue or to the maintainer discussion that approved revisiting the #25270 overlay decision, including the approval comment. Without that approval, explain why this fix qualifies as a very small, focused fix of an obvious bug. The description also changes an intentional behavior and it argues for a broader follow-up (shifting rows on auto-settle and on notice expiry), so state clearly that this PR covers only the notice placement. Add the model and harness used, since the description says the change was written by claude-opus-5-5, and keep the 'Written by' note in the template's end-of-description slot. Consider stating the observed results in the Verification section more concretely, for example the list state and whether the notice still shifts rows when it expires.

🧪 Generate unit tests (beta)

• Create a new PR