fix(server): avoid reparsing streamed replies for timestamps #25252 · pingdotgg/t3code

MmacroscopeappBotapproved these changes6d ago

Approvability

Verdict: Approved at b79914d

Macroscope's review found this PR approvable — This is a narrow server-side fix that removes redundant parsing of large streamed payloads while preserving timestamp encoding and persistence behavior. The accompanying regression test verifies both affected event types and timestamp precision.

No code changes detected at 464d77d. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

Ggithub-actionsBot6d ago

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	−35 B (−0.7%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.3 KiB	1.2 KiB	−35 B (−2.7%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	21.6 KiB	21.5 KiB	−41 B (−0.2%)	24.4 KiB	✅
Codex	Live turn messages	2	1	−1 (−50.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.3 KiB	1.3 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.9 KiB	21.9 KiB	0 B (0.0%)	24.4 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: 97e35bc · PR result: 464d77d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 108.5 KiB
Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

CcoderabbitaiBot6d ago

Review in Change Stack →

No actionable comments were generated in the recent review.

External image Recent review info

External image Run configuration

Source mode: Auto
Repository: pingdotgg/t3code
Branch: fix/issue-25157
File: .coderabbit.config.ts
Commit: 464d77d
Layers: Repository TS config
Review profile: CHILL
Plan: Team
Run ID: dddb344c-1de9-44e6-a3f6-447899149f88

External image Commits

Reviewing files that changed from the base of the PR and between b79914d19940449f2c412cad8ba64f07330fc77a and 464d77df25806d9e37b7524ce3d59c51fc4d4d51.

External image Files selected for processing: 2

apps/server/src/orchestration-v2/ProjectionStore.test.ts
apps/server/src/orchestration-v2/ProjectionStore.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

ProjectionStore now encodes message and turn-item index timestamps directly from event payloads. A regression test checks the stored timestamps and verifies that large streamed payload text is not parsed to retrieve them.

Changes: Projection timestamp indexing

Layer / File(s)	Summary
Direct timestamp encoding and regression test `apps/server/src/orchestration-v2/ProjectionStore.ts`, `apps/server/src/orchestration-v2/ProjectionStore.test.ts`	A shared UTC timestamp encoder supplies message and turn-item index values. The regression test checks the stored timestamps and verifies that the large payload text is not parsed to retrieve them.

Priority: External image Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related PRs

pingdotgg/t3code#24145: This PR changes the same ProjectionStore handlers and compares indexed fields before writing.

Suggested reviewers: t3dotgg, maria-rcks

Merge Risk: External image Minimal · up to 464d7

The change indexes timestamps directly without changing payload storage. No merge-blocking risk is identified.

Pre-merge checks: ^Passed 4

Check name	Status	Explanation
Title check	Passed	The title is concise, conventional, and accurately identifies the server fix: avoiding repeated parsing of streamed replies to read timestamps.
Description check	Passed	The description includes Problem, Change, Scope and approval, and Verification sections. It explains the issue, implementation, linked issue, tests, live-server checks, limitations, and agent attribut…
Linked Issues check	Passed	Directly linked issue [`#25157`] requires `message.updated` and `turn-item.updated` to index timestamps without parsing the full streamed payload. `ProjectionStore.ts` now encodes timestamps from the ty…
Out of Scope Changes check	Passed	The changes are limited to the server projection store and its focused regression test. The implementation directly addresses [`#25157`]. The test validates the implementation and stored timestamp behav…

Full details: Description check

Explanation

The description includes Problem, Change, Scope and approval, and Verification sections. It explains the issue, implementation, linked issue, tests, live-server checks, limitations, and agent attribution. The scope section does not include an explicit maintainer approval comment, but the description is otherwise complete and focused.

Full details: Linked Issues check

Explanation

Directly linked issue [#25157] requires message.updated and turn-item.updated to index timestamps without parsing the full streamed payload. ProjectionStore.ts now encodes timestamps from the typed event payload with Schema.DateTimeUtcFromString. The existing payload encoding and upsert behavior remain unchanged. The regression test covers both event types, a 128 KiB streamed payload, no matching full-payload parse, and millisecond timestamp indexes. The separate ws.ts concern is explicitly optional and is not required by this PR.

Full details: Out of Scope Changes check

Explanation

The changes are limited to the server projection store and its focused regression test. The implementation directly addresses [#25157]. The test validates the implementation and stored timestamp behavior. No unrelated rendering, client, or ws.ts changes are included.

Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

fix(server): avoid reparsing streamed replies for timestamps#25252

Problem

Change

Scope and approval

Verification

Checks

Approvability

Thread transfer impact