fix(mobile): search stays open after going back from a thread#24748

merged1
main
fix/mobile-search-restore-on-back
opened16d agobyTtheo
View on GitHubTwo-way sync enabledPR last imported 15d ago

On iPhone, if you search threads, open a result, and go back, the search field collapses to its button. The list stays filtered by your query, so it looks like your threads are gone.

When the list comes back into view, the search field now reopens with the query. Before this, only the iPhone Duo did that. The keyboard still opens only if search was focused when you left.

BeforeAfter
beforeafter

Proof: reproduced on an iPhone 17 simulator (iOS 26.5) with real data, then repeated the same flow with the fix. Close still clears search, and a thread round trip with no search still shows only the button. vp run check:changed passes.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol. Sol verdict: approved

Created with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

Checks

23 successful · 12 skipped
All checks passed
cbbd444

Added 1 commit

  • fix(mobile): search stays open after going back from a threadcbbd444
Synced from GitHub

Approvability

Verdict: Approved at cbbd444

Macroscope's review found this PR approvable — This is a localized iOS search-state bug fix that keeps the existing native search UI active after navigating back from a thread. It does not change schemas, product defaults, deployment behavior, or static-analysis configuration.

You can add or adjust custom eligibility rules. Learn more.

Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review.

External image Recent review info
External image Run configuration
External image Commits

Reviewing files that changed from the base of the PR and between 8c0670b2be8ea315ff790415db2cf76bcae8e0a8 and cbbd4445ea00165169b297924ae0434b25238b97.

External image Files selected for processing: 1
  • apps/mobile/src/features/workspace/WorkspaceToolbar.ios.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

On iOS, search restoration now reactivates the integrated search field when native liquid glass is supported. The existing focus behavior for active search mode remains unchanged.

Changes: iOS Search Restoration

Layer / File(s)Summary
Search restoration condition
apps/mobile/src/features/workspace/WorkspaceToolbar.ios.tsx
Search restoration reactivates the integrated search field when native liquid glass is supported. Focus behavior for active search mode remains unchanged.

Priority: External image Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related issues

  • pingdotgg/t3code#23013: The issue reports that returning from a thread hides the search field while the query still filters the thread list. This change updates search restoration on iOS.

Suggested reviewers: pixpmusic, juliusmarminge

Merge Risk: External image Minimal · up to cbbd4

The search restoration change is mergeable; no actionable current-head risk was found.

Pre-merge checks: Passed 4
Check nameStatusExplanation
Title checkPassedThe title clearly describes the mobile search restoration bug when returning from a thread.
Description checkPassedThe description explains the problem, the fix, affected behavior, screenshots, manual verification, and test results. It does not explicitly document maintainer approval or explain why the focused bug…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, the fix, affected behavior, screenshots, manual verification, and test results. It does not explicitly document maintainer approval or explain why the focused bug qualifies without prior approval, as requested by the Scope and approval section.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.