fix(github): keep gh's default repository when local remotes exist#24551

External image Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: fix/issue-24383
• File: .coderabbit.config.ts
• Commit: a90e45f
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: e22e2c5c-6d49-4f68-9a0b-b6a9e4ed2c60

External image Commits

Reviewing files that changed from the base of the PR and between eea989536849e5b5049987ee24318b5a77326542 and a90e45f2bd71c882bf9b48d935e6cff6fb45576d.

External image Files selected for processing: 2

• packages/source-control-github/src/server/gitHubRepositoryResolution.test.ts
• packages/source-control-github/src/server/gitHubRepositoryResolution.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

The base repository selection now skips remotes only when both repository and host parsing return null. Tests cover scheme-less GitHub remotes, non-GitHub and malformed remotes, and local-path remotes.

Changes: GitHub base selection

Layer / File(s)	Summary
Remote parsing and base selection packages/source-control-github/src/server/gitHubRepositoryResolution.ts, packages/source-control-github/src/server/gitHubRepositoryResolution.test.ts	selectGitHubBaseRepository skips a remote only when both parseGitRemoteRepository and parseGitRemoteHost return null. Tests cover scheme-less GitHub remotes, fallback cases, and resolving a GitHub locator when a local-path remote is present.

Priority: External image Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: maria-rcks, maxwellyoung

The change addresses selection of the marked GitHub repository when local-path remotes are present. No outstanding issue prevents merge after normal checks.

Check name	Status	Explanation
Title check	Passed	The title names the fix (keeping gh's default repository selected when local remotes exist) and matches the changeset, which ignores hostless remotes in selectGitHubBaseRepository. It is a conventiona…
Description check	Passed	The description follows the template's main sections: Problem, Change, Scope and approval, and Verification. It explains the failure with a reproduction path, describes the parser reuse and compatibil…
Linked Issues check	Passed	Issue #24383 requires GitHub PR repository selection to ignore non-GitHub remotes and retain the repository marked by gh repo set-default. The change skips a remote only when both repository parsing…
Out of Scope Changes check	Passed	The changes stay within issue #24383. The source change updates GitHub repository selection and its documentation. The added tests cover the reported local-remote regression and parser compatibility. …

Full details: Title check

Explanation

The title names the fix (keeping gh's default repository selected when local remotes exist) and matches the changeset, which ignores hostless remotes in selectGitHubBaseRepository. It is a conventional commit title in plain language and fits the author's stated problem.

Full details: Description check

Explanation

The description follows the template's main sections: Problem, Change, Scope and approval, and Verification. It explains the failure with a reproduction path, describes the parser reuse and compatibility handling, links issue #24383 as a triaged bug, and gives concrete test results and runtime evidence. The Verification section names the models used, as the template requests. Minor gaps: the template asks for focused tests or manual checks, and the author provides them, so no gap is material. The scope section cites an automated issue flow rather than a maintainer approval comment, which a reviewer may want to confirm.

Full details: Linked Issues check

Explanation

Issue #24383 requires GitHub PR repository selection to ignore non-GitHub remotes and retain the repository marked by gh repo set-default. The change skips a remote only when both repository parsing and host parsing return no result. This skips local-path remotes while preserving userless SCP remotes. The tests cover a local remote with a marked origin, scheme-less GitHub remotes, GitLab mirrors, malformed URLs, SSH aliases, and other selection cases. The focused tests also verify the resolved repository locator.

Full details: Out of Scope Changes check

Explanation

The changes stay within issue #24383. The source change updates GitHub repository selection and its documentation. The added tests cover the reported local-remote regression and parser compatibility. No unrelated client, contract, or render changes are shown.

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB