Claude assistant replies appeared only when the SDK delivered a completed text block, even with Response streaming set to Show finished paragraphs. Reproduced in the Linux web client by asking Claude Opus 5.5 for five paragraphs about the history of the printing press: reasoning appeared during generation, but the reply arrived together at completion.
Handle Claude text block starts and text deltas with the existing provider text coalescer. Reconcile completed snapshots with the streamed block identity, and flush partial text when a turn stops so completion and fallback paths do not duplicate the reply.
Fixes https://github.com/pingdotgg/t3code/issues/17270
GitCafe: #17270
Triaged bug via the automated issue flow.
expected [] to include 'Movable type changed Europe.').Final post-merge verification: 300 scoped tests passed. Both fresh independent code reviews returned MERGE on the final revision. The capture revision was followed by focused protocol tests and a three-line correction preserving result fallback after an entirely empty stream and snapshot.
Real Claude recordings: Before, exact five-paragraph prompt, After, same prompt. The after run shows successive paragraphs at roughly 8, 10, 12, and 14 seconds, before completion at 19 seconds. Live prose varies; the deterministic replay below supplies matched visual comparisons.
Additional observed behavior: partial streamed text survives Stop. The synthetic mixed-block snapshot groups streamed and snapshot-only text into separate rows; the SDK normally sends one snapshot per content block. These differences are shown in the evidence index rather than claimed as visual equality.
Rendering environment: collaborative Chromium browser on Linux, no device emulation, CSS viewports 1440×900 and 390×900 in light/dark, DPR 2, default font scaling. The browser tool caps desktop rasters at 1280×800; narrow rasters are 780×1800; the manifest records measured CSS and raster dimensions per frame. Web was exercised; Windows desktop and native clients were not separately run. No client code or contracts change.
Full evidence index, narrated chapters, seeds and replay drivers. Protocol-only terminal, empty-response, child-stream and unknown-index variants are covered by focused adapter tests. The follow-up retention replay below uses unique session IDs; the original captures establish point-in-time rendering.
Tested 096782c3e1 against 27e0c684c5 using a sanitized SDK replay through the real Claude SDK, adapter, server and web app. Both paragraph and turn modes are covered. SDK normally emits per-content-block snapshots; mixed-block grouping is fixture-specific.
| Config | Before (paragraph gate) 27e0c684c5 | After (paragraph gate) 096782c3e1 | Diff0 (0/255,4×) | DiffT (16/255,4×) | Recordings |
|---|---|---|---|---|---|
| 1440-light | Before | After | Diff0 same gate pair | DiffT same gate pair threshold16 | Before / After |
| 1440-dark | Before | After | Diff0 same gate pair | DiffT same gate pair threshold16 | Before / After |
| 390-light | Before | After | Diff0 same gate pair | DiffT same gate pair threshold16 | Before / After; Stop Before / After |
| 390-dark | Before | After | Diff0 same gate pair | DiffT same gate pair threshold16 | Before / After; Stop Before / After |
The eight initial empty-state pairs are pixel-identical at threshold zero. Head shows completed paragraphs before snapshots; turn mode waits. Correction/repetition, thinking/tool/new message, actual UI Stop in both modes, and clean snapshot-only follow-up are captured. Counter/icon noise in turn diffT and fixture-specific settled grouping differences are disclosed in the index. Focused identity/empty/error/child-stream variants are proved by adapter tests, rather than visual captures.
Exhaustive manifest. Exhaustive index.
Both diff columns compare exactly the displayed Before/After gate pair. Diff0 threshold0/255; DiffT threshold16/255; maximum absolute RGB channel difference, amplified4×, no masks. All68 accepted matched milestone pairs have both threshold diffs in the index. Initial empty-state equality is separate.
Follow-up isolation and compatibility proof: 49 retention/reconciliation assertions and five fallback assertions passed. Native IDs are unique per session and identical across matched baseline/head runs. Text, ownership, IDs and order survive reload and a later fixture thread. The final empty-stream/snapshot fallback was also exercised through the real app in head paragraph mode. Supplemental retention recordings cover 1440/light in both modes; protocol-only variants use the adapter tests.
Independent final proof audit: SUFFICIENT for all six matrix rows.
Models: Claude Opus 5.5 and GPT-6.1-Sol. Harnesses: Claude Agent SDK and Codex, orchestrated through T3 Code.
Review completed
Added 7 commits
Verdict: Needs Human Approval
Macroscope's review found this PR requires human approval — This change materially alters Claude's existing response path by emitting progressive assistant content and reconciling it across snapshots, completion, and interruption flows. The stateful streaming and lifecycle handling is focused but substantial enough to merit human review.
You can add or adjust custom eligibility rules. Learn more.
✅ Thread transfer remains within every enforced ceiling.
| Provider | Metric | Main baseline | This PR | Impact | PR ceiling | |
|---|---|---|---|---|---|---|
| Codex | Total thread wire | 4.9 KiB | 4.9 KiB | 0 B (0.0%) | 6.8 KiB | ✅ |
| Codex | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Codex | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | 0 B (0.0%) | 2.0 KiB | ✅ |
| Codex | Live turn WebSocket decoded | 20.8 KiB | 20.8 KiB | 0 B (0.0%) | 29.3 KiB | ✅ |
| Codex | Live turn messages | 1 | 1 | 0 (0.0%) | 8 | ✅ |
| Claude | Total thread wire | 5.0 KiB | 5.0 KiB | −31 B (−0.6%) | 6.8 KiB | ✅ |
| Claude | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Claude | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | −31 B (−2.5%) | 2.0 KiB | ✅ |
| Claude | Live turn WebSocket decoded | 21.2 KiB | 21.2 KiB | −41 B (−0.2%) | 29.3 KiB | ✅ |
| Claude | Live turn messages | 2 | 1 | −1 (−50.0%) | 8 | ✅ |
Baseline: 6e79211 · PR result: a459583 · Source CI: success
10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.
No actionable comments were generated in the recent review.
c91b9182-2a29-4956-8dd9-f15afce7b7c9Reviewing files that changed from the base of the PR and between 6e792117436662208bf2b6eb71ee8d0d88817e43 and a459583c71f7edee50f5ec0724db712f771398ed.
apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.tsapps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.tsLimit details: You’ve used all 10 included reviews currently available.
ClaudeAdapterV2 now emits assistant text as it arrives in SDK stream events. It tracks streamed blocks, settles them at turn completion, and reconciles them with completed assistant snapshots. Tests cover streamed text, snapshot handling, and empty or child-thread-only frames.
Changes: Claude assistant text streaming
| Layer / File(s) | Summary |
|---|---|
Streaming artifact state apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts | Assistant nodes, messages, and turn items now expose running streaming state and use the streamed block’s start time. Active turns track streamed text blocks and their timing and order. |
Streamed text updates apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts | Root text-block events create and update assistant text items. A coalescer emits node, message, and turn-item updates, and turn finalization flushes pending text. |
Snapshot reconciliation and validation apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts, apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts | Snapshots complete matching streamed blocks and project unstreamed text. Tests cover snapshot correction, turn completion without a snapshot, result-only text, and empty or child-thread-only frames. |
Priority: External image Normal
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix · Severity of issue fixed: Low
| 1 | sequenceDiagram |
| 2 | participant SDK as Claude SDK |
| 3 | participant Adapter as ClaudeAdapterV2 |
| 4 | participant Stream as Orchestration event stream |
| 5 | SDK->>Adapter: Root text-block start and text-delta events |
| 6 | Adapter->>Stream: Running assistant node, message, and turn-item updates |
| 7 | SDK->>Adapter: Assistant snapshot |
| 8 | Adapter->>Stream: Completed streamed items and unstreamed snapshot text |
Suggested reviewers: t3dotgg, macroscopeapp
a4595Claude text can appear while the response is still being written. No merge-blocking issue was established.
| Check name | Status | Explanation |
|---|---|---|
| Description check | Passed | The description includes the required Problem, Change, Scope and approval, and Verification sections. It identifies the linked issue, explains the implementation, reports focused test results, documen… |
| Title check | Passed | The title clearly and concisely describes the primary change: Claude answers now stream as they are written. It uses an appropriate conventional commit format. |
| Linked Issues check | Passed | Issue #17270 requires Claude assistant text to appear incrementally in paragraph mode. The PR adds Claude SDK text-block start and delta projection through the provider text coalescer. It reconciles s… |
| Out of Scope Changes check | Passed | The reported changes are limited to ClaudeAdapterV2 and its focused test file. The implementation supports the linked streaming fix, and the tests verify its delivery, reconciliation, fallback, and te… |
Explanation
The description includes the required Problem, Change, Scope and approval, and Verification sections. It identifies the linked issue, explains the implementation, reports focused test results, documents manual verification and limitations, and ends with the model and harness information.
Explanation
Issue #17270 requires Claude assistant text to appear incrementally in paragraph mode. The PR adds Claude SDK text-block start and delta projection through the provider text coalescer. It reconciles streamed blocks with completed snapshots and settles partial text on success, error, query exit, and interruption. The added ClaudeAdapterV2 tests cover streamed updates, snapshot correction, empty snapshots, fallback output, and child-thread or empty-stream cases. These changes address the issue's coding and automated-test requirements.
Explanation
The reported changes are limited to ClaudeAdapterV2 and its focused test file. The implementation supports the linked streaming fix, and the tests verify its delivery, reconciliation, fallback, and termination behavior. No unrelated change is established by the supplied change summary. The repository diff was unavailable, so this assessment relies on the supplied PR evidence and the reviewed file evidence.
Note
This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.
Comment @coderabbitai help to get the list of available commands.