fix: show mixed linked PR badges with a neutral status#24317

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

External image Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: fix/issue-15702
• File: .coderabbit.config.ts
• Commit: cb6a593
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 39ff17e4-4d17-43e2-93dd-4b0e0381d597

External image Commits

Reviewing files that changed from the base of the PR and between 08f47fada71c02c17e5d6efc8ded0b49c2c59664 and cb6a593a16050106ea2523bb827c4677a7e18791.

External image Files selected for processing: 4

• apps/mobile/src/state/use-thread-pr.test.ts
• apps/web/src/components/ThreadStatusIndicators.tsx
• packages/client-runtime/src/threadPullRequests.test.ts
• packages/source-control-core/src/shared/threadPullRequests.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

The shared badge calculation now reports mixed states when linked pull requests have differing snapshot states. Mobile and web presentations show neutral badges for mixed states. Tests cover the calculation and presentation.

Changes: Mixed pull-request badges

Layer / File(s)	Summary
Shared mixed-state badge calculation packages/source-control-core/src/shared/threadPullRequests.ts, packages/client-runtime/src/threadPullRequests.test.ts	Pull-request badges use mixed when visible linked pull requests have differing snapshot states. Tests cover mixed states and matching states.
Mobile and web mixed-state presentations apps/mobile/src/state/thread-pr-presentation.ts, apps/mobile/src/state/use-thread-pr.test.ts, apps/web/src/components/ThreadStatusIndicators.tsx	Mobile badges omit an overall state and describe mixed pull requests as being in different states. Web badges use a muted icon and display the linked count with a + prefix. Mixed badges have no settled hover-color override.

Priority: External image Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

• pingdotgg/t3code#23999: Adds forge-specific change-request terminology to linked pull-request surfaces also changed here.
• pingdotgg/t3code#23997: Replaces GitHub-specific assumptions in ThreadStatusIndicators.tsx and related runtime code.
• pingdotgg/t3code#23992: Moves badge helpers into source-control-core and client-runtime registries, which this change builds on.

Suggested reviewers: maria-rcks, t3dotgg

No actionable merge-blocking risk is established.

Check name	Status	Explanation
Title check	Passed	The title clearly summarizes the main change: mixed linked pull-request badges now use a neutral status.
Linked Issues check	Passed	Issue #15702 requires the sidebar and composer badges to stop presenting the total linked count as an open count for mixed states. The shared resolver now returns mixed for unrelated pull requests w…
Out of Scope Changes check	Passed	The changes remain connected to issue #15702. The type update enables the required mixed aggregate. The resolver change detects differing states, including closed with merged or pending links. Web and…
Description check	Passed	The pull request description includes all required sections: Problem, Change, Scope and approval, and Verification. It identifies the linked issue, explains the behavior change, lists focused checks a…

Full details: Linked Issues check

Explanation

Issue #15702 requires the sidebar and composer badges to stop presenting the total linked count as an open count for mixed states. The shared resolver now returns mixed for unrelated pull requests with differing snapshot states while retaining existing homogeneous and stack behavior. The web badge renders a muted glyph, the total count, and a different-states accessible label. The shared ThreadPullRequestBadgeControl covers the sidebar and composer. Mobile maps the mixed state to a muted presentation with the same label. Focused resolver, web, and mobile tests were added or updated, and the PR reports those tests passed.

Full details: Out of Scope Changes check

Explanation

The changes remain connected to issue #15702. The type update enables the required mixed aggregate. The resolver change detects differing states, including closed with merged or pending links. Web and mobile presentation changes prevent a false open status. The hover-color adjustment supports the new presentation. The focused test changes verify the resolver and presentations. No unrelated setting, capability, or persisted state was added.

Full details: Description check

Explanation

The pull request description includes all required sections: Problem, Change, Scope and approval, and Verification. It identifies the linked issue, explains the behavior change, lists focused checks and observed results, documents unverified areas and failed native builds, and includes the model and harness used. The verification is incomplete, but the description clearly reports those limits rather than omitting them.

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR