refactor(source-control): git and process behaviour comes from forge hooks#23995

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

External image Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: scp/04-git-hooks
• File: .coderabbit.config.ts
• Commit: 4963bd2
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 984e7511-fe16-4e60-a548-e316ff559754

External image Commits

Reviewing files that changed from the base of the PR and between d07fbdcb3e49fbea4367bfa36403aff435eb027e and 4963bd26678025d8918b9ec7bd3368a7942144c1.

External image Files selected for processing: 2

• apps/server/src/git/GitManager.test.ts
• apps/server/src/git/GitManager.ts

Limit details: You’ve used all 10 included reviews currently available.

The change moves change-request refs, repository targeting, terminology, and branch-base handling into source-control clients and providers. It replaces pull-request-specific Git fetch operations with ref-based operations and adds configurable failure classification and keyed concurrency for host CLI processes.

Changes: Source-control provider integration

Layer / File(s)	Summary
Provider-selected change-request refs packages/source-control-core/..., packages/source-control-{forgejo,github,gitlab}/client/definition.ts, apps/server/src/git/GitManager.ts, apps/server/src/pullRequest/PullRequestReviewGuideService.ts, apps/server/src/vcs/GitVcsDriver.ts, apps/server/src/vcs/GitVcsDriverCore.ts, related tests	Client definitions expose provider-specific head refs. GitManager and the review guide use these refs, and GitVcsDriver fetches caller-supplied refs. Tests include GitLab worktree preparation from its merge-request head ref.
Provider repository targeting and branch-base sharing packages/source-control-core/src/server/SourceControlProvider.ts, packages/source-control-github/src/server/GitHubSourceControlProvider.ts, packages/shared/src/sourceControl.ts, apps/server/src/git/GitManager.ts	Provider hooks determine repository targets and record branch bases. GitManager resolves change-request terminology through clients and shares branch-base data with providers. GitHub implements repository-target and branch-base hooks.
Git branch-base storage and lookup apps/server/src/vcs/GitVcsDriver.ts, apps/server/src/vcs/GitVcsDriverCore.ts, apps/server/src/vcs/GitVcsDriverCore.test.ts	GitVcsDriver writes the T3 branch-base key and reads the legacy GitHub key when the T3 value is absent. Tests check the T3 key and use the generic ref-fetch API.
Host-process classification and concurrency apps/server/src/vcs/VcsProcess.ts, apps/server/src/vcs/VcsProcess.test.ts, packages/contracts/src/vcs.ts, packages/source-control-core/src/server/SourceControlHost.ts, packages/source-control-{azure-devops,gitlab}/src/server/*, packages/source-control-github/src/server/*	Process inputs accept custom failure classifiers, not-found details, and keyed concurrency. Azure DevOps and GitLab add CLI failure classifiers. GitHub CLI calls use a keyed concurrency limit.

Priority: External image Normal

Estimated code review effort: 4 (Complex) | ~50 minutes

Change: Refactor

Sequence Diagram(s)

mermaid

1	sequenceDiagram
2	participant GitManager
3	participant GitLabClient
4	participant GitVcsDriver
5	participant PrimaryRemote
6	GitManager->>GitLabClient: changeRequestHeadRef(number)
7	GitLabClient-->>GitManager: refs/merge-requests/number/head
8	GitManager->>GitVcsDriver: fetchRefIntoBranch(cwd, ref, branch)
9	GitVcsDriver->>PrimaryRemote: Fetch ref into refs/heads/branch

Possibly related issues

• pingdotgg/t3code#14939 — The PR changes change-request head materialization and removes inferred fork names, but does not show a complete fix for host-qualified clone lookup.
• pingdotgg/t3code#22920 — The PR changes branch-base recording and lookup, but does not show remote-base validation.
• pingdotgg/t3code#24304 — The PR adds provider-specific not-found details, but does not show saved-token-specific guidance.

Suggested reviewers: t3dotgg, stbenjam, maria-rcks, only21mil

A reused checkout can advance past a closed change request’s head and report that it is on the request head. Fix that refresh path before merging.

^Failed Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check	Warning	The description explains the problem and the cross-package changes in detail. It omits the required Scope and approval section and does not report focused verification steps or their results.	Add a Scope and approval section with a link to the triaged issue or maintainer approval, or explain why this change qualifies for an exception. Add a Verification section describing focused tests or manual checks, their observed results, a…

^Passed Passed checks: 3 passed

Check name	Status	Explanation
Title check	Passed	The title clearly summarizes the main change: forge-specific Git and process behavior now comes from forge hooks. It is concise and specific.
Linked Issues check	Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Resolution

Add a Scope and approval section with a link to the triaged issue or maintainer approval, or explain why this change qualifies for an exception. Add a Verification section describing focused tests or manual checks, their observed results, and anything not checked.

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR