Synced from GitHub
fix(web): align pull request file counts with diff stats#23905
Problem
The changed-file count and diff statistics were vertically misaligned in the pull request view at reduced browser zoom. They should align on the same text baseline.
Change
Align the file count and diff statistics to the text baseline in both the pull request header and detail panel. Center the file icon alongside its count.
Scope and approval
This is a small, focused fix for a visible alignment bug. The same alignment change applies to the header and detail panel.
Verification
Captured before and after screenshots of the same pull request at 90% CSS scale. git diff --check passed.
Checks
- SuccessfulCodeRabbitGitHub
Review completed
- Successful
Skipped - Not affected
- Skipped
- Skipped
- Skipped
- SuccessfulRemove preview downloadGitHub
- SuccessfulCheckGitHub
- SkippedRelease SmokeGitHub
- Skipped
- SkippedRustGitHub
- SuccessfulTest WebGitHub
- SuccessfulBuild and TypecheckGitHub
- SuccessfulTestGitHub
- SuccessfulLabel PR 23905GitHub
- Skipped
- SuccessfulLabel PR sizeGitHub
- Skipped
- Successful
- SuccessfulPrepare PR size configGitHub
- SuccessfulCollect PR targetsGitHub
- Successful
- SkippedEAS PreviewGitHub
- SuccessfulTest Server 6GitHub
- SuccessfulTest Server 1GitHub
- SuccessfulTest Server 7GitHub
- SuccessfulTest Server 4GitHub
- SuccessfulTest Server 5GitHub
- SuccessfulTest Server 3GitHub
- SuccessfulTest Server 8GitHub
- SuccessfulTest Server 2GitHub
- SuccessfulChangesGitHub
- SuccessfulLintGitHub
- SuccessfulNative fingerprint diffGitHub
Added 1 commit
- fix(web): align pull request file counts with diff stats1b45265
Synced from GitHub
Approvability
Verdict: Approved at 1b45265
Macroscope's review found this PR approvable — This PR makes a narrowly scoped visual alignment adjustment to file-count and diff-stat indicators in existing pull-request views. It changes no data, behavior, defaults, or integrations, so its runtime risk is minimal.
You can add or adjust custom eligibility rules. Learn more.
Synced from GitHub
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
- Source mode: Auto
- Repository: pingdotgg/t3code
- Branch: t3/fix-pr-view-alignment
- File: .coderabbit.config.ts
- Commit: 1b45265
- Layers: Repository TS config
- Review profile: CHILL
- Plan: Team
- Run ID:
7e0ca621-66f1-4c5d-8e44-c0df5cdc2a2e
📥 Commits
Reviewing files that changed from the base of the PR and between 51273020db3245f4ec29514a419d29b5dcb012dc and 1b45265a99ce75a8d53346150fc712be2fdc7a55.
📒 Files selected for processing: 2
apps/web/src/components/pullRequest/PullRequestDetailLayout.tsxapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📝 Walkthrough
Two pull-request detail components now use baseline alignment for file-count and diff-stat elements. The file-diff icon remains vertically centered in its row.
Changes: Pull request detail alignment
Layer / File(s) Summary Count and diff alignment
apps/web/src/components/pullRequest/PullRequestDetailLayout.tsx,apps/web/src/components/pullRequest/PullRequestDetailPanel.tsxThe file-count and diff-stat row uses baseline alignment, with the file-diff icon vertically centered. The condensed header’s changed-file count and icon use baseline alignment. Priority: ⬇️ Low
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Suggested reviewers:
juliusmarminge
Merge Risk: ⚪ Minimal · up to 1b452
The alignment-only change addresses the reported pull-request display issue without an identified functional or operational risk.
Pre-merge checks: Passed 4
Check name Status Explanation Title check Passed The title clearly and concisely describes the primary change: aligning pull request file counts with diff statistics. Description check Passed The description covers the problem, change, scope justification, and verification. It states that before-and-after screenshots were captured, but it does not embed or link the required UI evidence. Linked Issues check Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.