fix(web): mark the selected diff scope in its menu#23893

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 200dad3
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 03b37cd3-75d4-43af-9e59-38476fdd687f

Reviewing files that changed from the base of the PR and between 6123bd6b0481801869b71d61490b82a53a337b22 and 622b9c27da437082d7e8accf7972407e756caf95.

• apps/web/src/components/DiffPanel.tsx

• apps/web/src/components/DiffPanel.tsx

Explanation

The title "fix(web): mark the selected diff scope in its menu" matches the main change in the raw summary: DiffPanel now renders MenuRadioItemIndicator beside the Changes, Uncommitted, Latest turn, and per-turn radio items, so the selected scope shows a marker. It is specific, uses a conventional commit prefix, and avoids vague terms. Its wording is slightly broader than the change, since it does not name the hover problem, but that is acceptable.

Explanation

The description states the problem (a hovered neighboring row looks selected and no selection marker is shown), the change (adding the existing MenuRadioItemIndicator to the scope and individual-turn options), and the scope (diff menu only, shared web/desktop component, mobile unaffected). It links issue #19208 and explains why no prior approval is needed under the obvious-bug exception. Verification lists concrete checks, including the commands run, the viewport, themes, interactions tested, and what was not exercised. Before and after screenshots are included, as the template requires for UI changes. The description does not fully follow the template: it cites the obvious-bug exception instead of a maintainer-approved issue, which the template allows for small fixes. The Problem, Change, Scope and approval, and Verification headings are not used; the content is grouped under a Verification and Screenshots section. These gaps are minor, so the check passes.

Explanation

Issue #19208 requires the selected diff-scope row to stay distinguishable from an adjacent hovered row. The issue lists a checkmark on the selected row as an acceptable fix. The whole-PR diff (merge base 200dad3b to head 622b9c27) for apps/web/src/components/DiffPanel.tsx adds MenuRadioItemIndicator to the Changes (branch), Uncommitted (unstaged), and Latest turn (latest) DropdownMenuRadioItem entries. It also adds the indicator to the individual-turn items after the timestamp span. The indicator sits in a flex span beside each label. The change is code-level and matches the requirement. Visual confirmation by the author covers Changes and Uncommitted only. Individual-turn rendering was not exercised. The issue does not require automated tests. Limitation: the diff shows the import and JSX, but the indicator's checked-only rendering comes from the existing ui/menu.tsx implementation, which this diff does not change. Its export was not directly read.

Explanation

The whole-PR diff touches only apps/web/src/components/DiffPanel.tsx among the files inspected. The diff for apps/web/src/components/ui/menu.tsx between merge base and head is empty, so shared menu styling and selection behavior are unchanged. The added flex wrapper spans and the indicator sit only inside the diff scope menu items. This wrapping supports indicator placement and is part of the same objective. No unrelated behavior change appears in the diff. The change set is larger than the earlier +5/-0 review: it is now +14/-3 per the summary, and the direct diff confirms the expanded edits, all within the same menu.

• Create a new PR