With an environment theme selected (a theme file in ~/.t3/userdata/themes that the server publishes), every reload paints the stock theme first: stock black or white, with the blue accent and sidebar header, until the server connects and the real theme replaces it. It happens in light and dark mode, and is most visible in dark.
Environment themes only arrive from the server after the app connects, and the client never stored them, so the boot script in index.html had nothing to paint. After connecting, a theme list that hadn't arrived yet was also treated as empty for a moment.
The web app now caches the server's themes in localStorage, the same way custom themes are already stored for boot. The boot script and the first render paint from that cache. In the server config projection, undefined now means "not received yet" and [] means "no themes", so the cache is only replaced once the server's theme update arrives. Deleting the last theme still clears it.
Small fix for an obvious bug, extending the existing custom-theme boot storage. No new settings.
themeBoot.test.ts case fails without the fix. Affected tests pass (63), and vp run check:changed passes.Reload in the desktop app, dark mode on the left and light mode on the right, both clips starting at the reload.
Before:
External imageAfter:
External imageModel: Claude Opus 5.5, reviewed by GPT-6.1-Sol. Harness: Claude Code through T3 Code.
Review completed
Added 1 commit
Verdict: Approved at 005ad22
Macroscope's review found this PR approvable — This is a focused fix for environment themes flashing to stock colors on reload. It adds a validated localStorage snapshot for first paint and preserves it until the server provides authoritative data, with the remaining changes limited to synchronization semantics and tests.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review. 🎉
f81e7ea6-f63c-4915-a455-389fed4f4fedReviewing files that changed from the base of the PR and between 2c8bdf6177159d8fcd12a897d7c9311f6eb93237 and 005ad22101207e347e5b8c91576b77de8cf19996.
apps/web/index.htmlapps/web/src/hooks/useEnvironmentTheme.tsapps/web/src/state/server.tsapps/web/src/themeBoot.test.tsapps/web/src/themePalette.tspackages/client-runtime/src/rpc/session.test.tspackages/client-runtime/src/state/serverConfigProjection.tsIncluded review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Environment themes now persist as versioned local-storage snapshots, and startup lookup can resolve them after saved custom themes. Server state distinguishes missing or pending theme data from an advertised empty set. Synchronization leaves the stored snapshot unchanged while theme data is null.
Changes: Environment theme flow
| Layer / File(s) | Summary |
|---|---|
Server theme state and projection packages/client-runtime/src/state/serverConfigProjection.ts, apps/web/src/state/server.ts, packages/client-runtime/src/rpc/session.test.ts | The server projection preserves empty theme arrays. The primary-server atom returns null when configuration or advertised themes are not yet available, and returns an empty array when the server does not support environment themes. Replay tests expect an empty array after deletion. |
Environment theme snapshot storage apps/web/src/themePalette.ts | The palette cache lazily loads a versioned local-storage snapshot. Changed themes are persisted when possible, and environment-theme lookup uses the getter. |
Startup theme resolution and synchronization apps/web/index.html, apps/web/src/hooks/useEnvironmentTheme.ts, apps/web/src/themeBoot.test.ts | The boot script checks saved custom themes before environment themes. The sync effect skips null publications. A test checks startup selection of a dark environment-theme variant. |
Priority: ⬇️ Low
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
| 1 | sequenceDiagram |
| 2 | participant ServerConfigProjection |
| 3 | participant PrimaryServerEnvironmentThemesAtom |
| 4 | participant useEnvironmentThemeSync |
| 5 | participant themePalette |
| 6 | participant localStorage |
| 7 | participant BootScript |
| 8 | ServerConfigProjection->>PrimaryServerEnvironmentThemesAtom: Store published themes, including empty arrays |
| 9 | PrimaryServerEnvironmentThemesAtom->>useEnvironmentThemeSync: Provide themes or null |
| 10 | useEnvironmentThemeSync->>themePalette: Set themes when publication is non-null |
| 11 | themePalette->>localStorage: Persist versioned theme snapshot |
| 12 | BootScript->>localStorage: Read environment-theme snapshot |
| 13 | BootScript->>BootScript: Resolve saved custom theme, then environment theme |
Suggested reviewers: maria-rcks, juliusmarminge
005adReloading alongside another environment can briefly show the wrong colors. The palette corrects when the selected environment publishes its themes, so this is a bounded visual risk rather than a merge blocker.
| Check name | Status | Explanation |
|---|---|---|
| Title check | Passed | The title clearly and concisely describes the main fix: preserving environment themes across reloads. |
| Description check | Passed | The description includes the problem, implementation, scope rationale, focused test results, manual verification, and before/after evidence. It also explains why prior approval was not required for th… |
| Linked Issues check | Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | Passed | Check skipped because no linked issues were found for this pull request. |
Explanation
The description includes the problem, implementation, scope rationale, focused test results, manual verification, and before/after evidence. It also explains why prior approval was not required for this obvious bug fix.
Comment @coderabbitai help to get the list of available commands.