fix(opencode): leave configured server updates to their owner#23859

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

⚙️ Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 2c8bdf6
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: a41fa265-5e3d-4df3-8072-fd441b9ca266

📥 Commits

Reviewing files that changed from the base of the PR and between 2c8bdf6177159d8fcd12a897d7c9311f6eb93237 and bf64a3ae354c3513ceeb384d5a78f6e88ed9043a.

📒 Files selected for processing: 3

• docs/user/providers-opencode.md
• packages/provider-opencode/src/server/driver.test.ts
• packages/provider-opencode/src/server/driver.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

OpenCode maintenance now treats a non-empty configured server URL as externally managed. It does not offer a local package update for that server and directs users to update it through its starting app or tool. A blank server URL retains local update behavior.

Changes: OpenCode server updates

Layer / File(s)

Summary

External server maintenance behavior packages/provider-opencode/src/server/driver.ts, packages/provider-opencode/src/server/driver.test.ts, docs/user/providers-opencode.md

The driver skips local update resolution for configured servers and changes the advisory for external servers that are behind the latest version. Tests cover HTTP and HTTPS server configurations, confirm that the local CLI is not probed, and verify that a blank server URL retains the native upgrade command. The documentation clarifies which installed package the update button updates and how to update a configured server.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix · Severity of issue fixed: Medium

Configured-server update guidance and blank-URL local updates show no identified merge-blocking risk.

^Failed Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Linked Issues check	Warning	[#22869] The diff in packages/provider-opencode/src/server/driver.ts sets isExternalServer when serverUrl.trim() is non-empty. For such servers, maintenance resolves with null, so no local opencode up…	Either (a) implement the issue's expected behavior for configured servers: probe the installed CLI version separately, and when the CLI is current but the running server is behind latest, show a message that states the CLI is updated and th…

^Passed Passed checks: 3 passed

Check name	Status	Explanation
Title check	Passed	The title follows conventional commit format and names the main change: configured OpenCode servers are now left to their owner for updates instead of offering a local CLI update. It matches the raw s…
Description check	Passed	The description follows the template well. It has a Problem section with the bug, the Windows/Nightly reproduction context, and the mismatch between the CLI and the running server. The Change section …
Out of Scope Changes check	Passed	The reviewed changes stay within the scope of #22869. driver.ts changes gate maintenance resolution on a non-empty Server URL and adjust the outdated-server advisory text for configured servers. drive…

Full details: Title check

Explanation

The title follows conventional commit format and names the main change: configured OpenCode servers are now left to their owner for updates instead of offering a local CLI update. It matches the raw summary (driver.ts resolves no update for non-empty serverUrl) and the PR objectives (manual-only maintenance for configured servers). It is specific and concise, with no file lists or vague terms.

Full details: Description check

Explanation

The description follows the template well. It has a Problem section with the bug, the Windows/Nightly reproduction context, and the mismatch between the CLI and the running server. The Change section explains the manual-only maintenance behavior for configured servers, the preserved local CLI updates for an empty Server URL, and the tradeoffs. The Scope and approval section explains the focused obvious-bug exception and states that no maintainer approval is claimed. The Verification section lists the specific tests, the base-commit failure and post-fix pass, the commands run, and what was not tested on Windows. The author placed the model attribution at the end as the template asks. The description is long and includes detail about #22839 that goes beyond the template, but all required sections are substantively filled.

Full details: Out of Scope Changes check

Explanation

The reviewed changes stay within the scope of #22869. driver.ts changes gate maintenance resolution on a non-empty Server URL and adjust the outdated-server advisory text for configured servers. driver.test.ts adds regressions for loopback and remote configured servers, a blank-URL positive control for native CLI upgrade, and checks for no local CLI probe. docs/user/providers-opencode.md clarifies that configured servers are updated through their host application or tool. Each change supports the manual-update behavior for configured servers or keeps the existing local-managed behavior. No unrelated code path was identified in the reviewed summary and the focused driver diff. The behavioral tradeoff for the shared sidebar update shortcut is a consequence of the design and not an unrelated change.

Full details: Linked Issues check

Explanation

[#22869] The diff in packages/provider-opencode/src/server/driver.ts sets isExternalServer when serverUrl.trim() is non-empty. For such servers, maintenance resolves with null, so no local opencode upgrade or install command is offered. This removes the misleading Update now action for configured servers. The advisory text now tells users to update the server with the app or tool that started it, restart it when sessions can be interrupted, and refresh provider status. The advisory still uses the running-server version probe, so it clears when the server reports the new version. These parts meet the issue's requirements to avoid automatic termination, to recheck the runtime version, and not to assume a local CLI is the remote server's installation. Two issue expectations are not met. (1) The issue asks to verify the installed CLI version separately from the running server version. The PR adds no CLI verification for configured servers, and the PR description says this is intentional. (2) The issue asks to say 'CLI updated; restart the configured server to apply' when the CLI is current and the server is old. The PR does not emit this message. The change follows a different design, and the PR states this. The docs and driver tests cover the chosen design. No test covers the CLI-updated restart message because the message is not implemented.

Resolution

Either (a) implement the issue's expected behavior for configured servers: probe the installed CLI version separately, and when the CLI is current but the running server is behind latest, show a message that states the CLI is updated and the configured server must be restarted to apply it, with a regression test for that message; or (b) obtain maintainer confirmation in #22869 that the manual-only approach replaces the CLI-verification and restart-message expectations, and record that decision in the linked issue or PR.

🧪 Generate unit tests (beta)

• Create a new PR