On Linux hosts without a session bus, opening a project can make gh auth token and account discovery autolaunch a new D-Bus daemon for each keyring lookup. These daemons survive the command and accumulate until the host exhausts resources.
Share a guard between GitHub credential retrieval and account discovery that disables gh's bus autolaunch when no configured or discoverable session bus exists. Preserve existing bus addresses and per-command environment overrides.
Preserves HelixNebula's fix from #23549, including author credit, with a linear trailing-newline scan.
Fixes #23603
Triaged bug via the automated issue flow. Server-only process-environment change; no client, wire-contract, settings, or persisted-data changes.
expected undefined to be 'disabled:'; it passes with the fix.vp run check:changed: exit 0; format, lint, knip, GraphQL generation, affected-package typechecks, and 45 focused tests passed.Runtime transcript: Ubuntu Linux/Xvfb, real gh 2.97.0, real development app. Baseline 22840ab943 and fixed 0dd6c9fdfe. In a mount/PID namespace with /run/user hidden and the bus address unset, added a local project with remote git@github-hn:owner/repo.git through the app.
| Runtime | gh operations | D-Bus daemon count |
|---|---|---|
| Main, missing bus | Project credential lookup | 2 → 4; both new daemons survived gh exit |
| Fixed, missing bus | Repeated token lookup and account discovery | 2 → 2 |
| Fixed, configured bus | Token lookup and account discovery | 2 → 2 |
The fixed app's command log recorded:
| 1 | gh auth token --hostname github-hn | bus=disabled: |
| 2 | gh auth token --hostname github.com | bus=disabled: |
| 3 | gh --version | bus=disabled: |
| 4 | gh auth status --json hosts | bus=disabled: |
Repeated missing-bus calls retained disabled:. With a configured bus, all four operations retained unix:path=/run/user/1000/bus. Supplemental direct gh token lookup for github.com exited 0 with output suppressed; the alias lookup exited 1. No tokens were recorded. Stopping the baseline namespace removed its two leaked daemons.
The render fixture matrix is empty (0/0): this backend fix has no visible render paths. Actual Windows/WSL and Secret Service-only credential login remain unverified. Credentials reachable only through a Secret Service activated by an autolaunched bus can become unavailable; existing configured buses and gh's other credential sources remain available. Calls to gh made indirectly by git credential helpers are outside this change.
Written with Claude Opus 5.5 and GPT-6.1-Sol in T3 Code through the Codex harness.
Fixes pingdotgg/t3code#23603
Added 2 commits
Verdict: Needs Human Approval
Macroscope's review found this PR requires human approval — This is a focused server-side fix that prevents D-Bus daemon leaks during GitHub CLI credential and account discovery, while changing credential availability in no-session-bus environments. Because it directly affects authentication and keyring-backed credential retrieval, the change warrants human review.
You can add or adjust custom eligibility rules. Learn more.
✅ Thread transfer remains within every enforced ceiling.
| Provider | Metric | Main baseline | This PR | Impact | PR ceiling | |
|---|---|---|---|---|---|---|
| Codex | Total thread wire | 5.0 KiB | 5.0 KiB | 0 B (0.0%) | 6.8 KiB | ✅ |
| Codex | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Codex | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | 0 B (0.0%) | 2.0 KiB | ✅ |
| Codex | Live turn WebSocket decoded | 20.9 KiB | 20.9 KiB | 0 B (0.0%) | 29.3 KiB | ✅ |
| Codex | Live turn messages | 2 | 2 | 0 (0.0%) | 8 | ✅ |
| Claude | Total thread wire | 5.0 KiB | 5.0 KiB | 0 B (0.0%) | 6.8 KiB | ✅ |
| Claude | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Claude | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | 0 B (0.0%) | 2.0 KiB | ✅ |
| Claude | Live turn WebSocket decoded | 21.2 KiB | 21.2 KiB | 0 B (0.0%) | 29.3 KiB | ✅ |
| Claude | Live turn messages | 2 | 2 | 0 (0.0%) | 8 | ✅ |
Baseline: 22840ab · PR result: 0dd6c9f · Source CI: success
10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.
No actionable comments were generated in the recent review.
The PR adds a process service that checks D-Bus availability before running GitHub CLI commands. GitHub credential lookup and CLI discovery now use this service.
Changes: GitHub CLI D-Bus handling
| Layer / File(s) | Summary |
|---|---|
D-Bus process environment handling packages/source-control-github/src/server/gitHubCliProcess.ts, packages/source-control-github/src/server/gitHubCliProcess.test.ts | makeGhProcess checks the effective D-Bus address. When no usable bus is discoverable on a supported platform, it sets DBUS_SESSION_BUS_ADDRESS to disabled:. Tests cover host and spawn addresses, bus discovery, filesystem errors, and platform behavior. |
Credential and discovery integration packages/source-control-github/src/server/GitHubCredentials.ts, packages/source-control-github/src/server/GitHubSourceControlProvider.ts, packages/source-control-github/src/server/GitHubCredentials.test.ts, packages/source-control-github/src/server/GitHubRest.test.ts | Credential lookup and CLI discovery now use makeGhProcess. Credential tests verify the spawned environment, and the REST credential test setup provides a no-op filesystem layer. |
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix · Severity of issue fixed: Medium
| 1 | sequenceDiagram |
| 2 | participant GitHubCredentials |
| 3 | participant makeGhProcess |
| 4 | participant FileSystem |
| 5 | participant HostProcess |
| 6 | GitHubCredentials->>makeGhProcess: Request GitHub CLI process |
| 7 | makeGhProcess->>FileSystem: Check for a session bus |
| 8 | FileSystem-->>makeGhProcess: Return bus or session-file result |
| 9 | makeGhProcess->>HostProcess: Run gh with the selected environment |
0dd6cThe change is mergeable after normal checks. No actionable risk remains established for GitHub credential lookup or CLI discovery.
| Check name | Status | Explanation |
|---|---|---|
| Title check | Passed | The title clearly and concisely describes the main fix: preventing D-Bus daemon leaks during GitHub credential lookups. |
| Linked Issues check | Passed | Issue #23603 requires background gh token lookups and account discovery to avoid D-Bus autolaunch when no session bus exists. makeGhProcess checks the effective address, the runtime bus socket, an… |
| Out of Scope Changes check | Passed | The changes stay within issue #23603. The new process service prevents D-Bus autolaunch for GitHub CLI calls. The credential and discovery integrations route the affected calls through that service. T… |
| Description check | Passed | The description covers the required Problem, Change, Scope and approval, and Verification sections. It explains the issue and expected behavior, describes the server-side fix and its scope, links the … |
Explanation
Issue #23603 requires background gh token lookups and account discovery to avoid D-Bus autolaunch when no session bus exists. makeGhProcess checks the effective address, the runtime bus socket, and dbus-session, then sets DBUS_SESSION_BUS_ADDRESS to disabled: only when no bus is configured or discoverable. It preserves explicit and discoverable addresses. GitHubCredentials and GitHubSourceControlProvider use this process service. Tests cover missing, configured, discoverable, overridden, Darwin, and filesystem-error cases. The supplied validation reports the credential regression test and package checks passing.
Explanation
The changes stay within issue #23603. The new process service prevents D-Bus autolaunch for GitHub CLI calls. The credential and discovery integrations route the affected calls through that service. The added tests and test-layer updates support this behavior. No unrelated client, wire-contract, settings, or persisted-data changes are evidenced.
Explanation
The description covers the required Problem, Change, Scope and approval, and Verification sections. It explains the issue and expected behavior, describes the server-side fix and its scope, links the tracked issue, and reports focused tests, runtime checks, and unverified cases.
093cd4e0-168d-4ab7-b2c4-223b0e42746fReviewing files that changed from the base of the PR and between 22840ab943b8418744b48223411e46ba4fdcef1a and 0dd6c9fdfe5802104768fb96b48c64a89dbdcd8f.
packages/source-control-github/src/server/GitHubCredentials.test.tspackages/source-control-github/src/server/GitHubCredentials.tspackages/source-control-github/src/server/GitHubRest.test.tspackages/source-control-github/src/server/GitHubSourceControlProvider.tspackages/source-control-github/src/server/gitHubCliProcess.test.tspackages/source-control-github/src/server/gitHubCliProcess.tsLimit details: You’ve used all 10 included reviews currently available.
Hey @juliusmarminge is this still planned for a merge? Thanks!
