fix(deps): pin all patched package versions#23798

merged1
main
t3/fix-patched-dependency-version-pins
opened2d agobyJJulius Marminge
View on GitHubTwo-way sync enabledPR last imported 2d ago

Fresh dependency resolution in Release Smoke can select versions newer than our patches, failing with ERR_PNPM_UNUSED_PATCH for @expo/fingerprint and expo-network.

Add exact workspace overrides for all patched packages that lacked one and refresh the lockfile. Existing exact overrides remain in place, so every patched package is pinned, including transitive dependencies. Resolved package versions are unchanged.

Validation: node scripts/release-smoke.ts passes, including regeneration without a lockfile; vp run check:changed passes formatting and typechecks for all 32 packages; git diff --check passes. This is dependency configuration only, with no visual changes.

Model: GPT-6.1 Sol. Harness: Codex in T3 Code.

Checks

All checks passed

Added 1 commit

  • fix(deps): pin all patched package versionsa1d912a
Synced from GitHub

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This pins existing patched dependencies for reproducible lockfile-free installs without changing the normal locked graph. Human review is warranted because the pins include the Clerk Expo authentication package, whose patched runtime behavior affects native auth navigation.

You can add or adjust custom eligibility rules. Learn more.

Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review. šŸŽ‰

ā„¹ļø Recent review info
āš™ļø Run configuration
šŸ“„ Commits

Reviewing files that changed from the base of the PR and between fd1063ba7c452e2a938484277235afebf0639119 and a1d912aa0b592412f33438fe34a7b6f44038c0fa.

ā›” Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
šŸ“’ Files selected for processing: 1
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

šŸ“ Walkthrough

The workspace configuration adds exact version pins for patched packages under overrides. The existing expo-modules-core override remains unchanged, but its explanatory comment is removed.

Changes: Dependency overrides

Layer / File(s)Summary
Add exact package version pins
pnpm-workspace.yaml
The overrides section adds exact version pins for patched packages. The existing expo-modules-core pin remains unchanged, and its explanatory comment is removed.

Priority: āž– Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: project516

Merge Risk: ⚪ Minimal · up to a1d91

The dependency override changes are mergeable based on the supplied evidence.

Pre-merge checks: Passed 4
Check nameStatusExplanation
Title checkPassedThe title clearly and concisely describes the main change: pinning patched dependency versions.
Description checkPassedThe description explains the dependency-resolution problem, the override and lockfile changes, and specific verification results. It is mostly complete, but it does not explicitly document the Scope a…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the dependency-resolution problem, the override and lockfile changes, and specific verification results. It is mostly complete, but it does not explicitly document the Scope and approval requirement or explain why this focused configuration change qualifies without prior approval.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix Ā· Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Synced from GitHub

Thread transfer impact

āœ… Thread transfer remains within every enforced ceiling.

ā„¹ļø The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire5.0 KiB5.0 KiBāˆ’7 B (āˆ’0.1%)6.8 KiBāœ…
CodexThread snapshot wire3.8 KiB3.8 KiB0 B (0.0%)4.9 KiBāœ…
CodexLive turn WebSocket wire1.2 KiB1.2 KiBāˆ’7 B (āˆ’0.6%)2.0 KiBāœ…
CodexLive turn WebSocket decoded20.9 KiB20.9 KiB0 B (0.0%)29.3 KiBāœ…
CodexLive turn messages220 (0.0%)8āœ…
ClaudeTotal thread wire5.0 KiB5.0 KiB+7 B (+0.1%)6.8 KiBāœ…
ClaudeThread snapshot wire3.8 KiB3.8 KiB0 B (0.0%)4.9 KiBāœ…
ClaudeLive turn WebSocket wire1.2 KiB1.2 KiB+7 B (+0.6%)2.0 KiBāœ…
ClaudeLive turn WebSocket decoded21.2 KiB21.2 KiB0 B (0.0%)29.3 KiBāœ…
ClaudeLive turn messages220 (0.0%)8āœ…

Baseline: 4eae8ae Ā· PR result: a1d912a Ā· Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.