fix(web): show supported remote editors in the picker#23572

open1
main
GitHub fork: fix/web-remote-editor-picker
opened7d agobyUulughbeck
View on GitHubTwo-way sync enabledPR last imported 1h ago

Remote web connections only showed VS Code. Browsers cannot detect installed editors, so the picker now offers the supported remote editors, including Cursor and Zed. Desktop detection and local connections stay the same.

This is a small fix to the existing picker. No new editor protocols or settings.

vp run check:changed passed, including 17 focused tests. The regression fails before the fix and passes after it. Checked the menu and saved editor selection in an isolated web client. Native editor launch was not exercised.

Written with GPT-6.1-Sol in the Codex harness. Reviewed with GPT-6-Astra.

Checks

7 successful · 1 neutral · 2 skipped
All checks passed
b071e48

Added 1 commit

  • fix(web): show supported remote editors in the pickerb071e48
Synced from GitHub

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — The web picker now defaults remote connections to all supported editor links instead of only VS Code, while desktop and local behavior remain unchanged. This changes a product default, so the change warrants human review.

You can add or adjust custom eligibility rules. Learn more.

Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 8d3b061121fe65669d5d43d011b48cd3027a4108 and b071e48896191ae207ddc2ba0ebf5cf602a3f497.

📒 Files selected for processing: 2
  • apps/web/src/components/chat/OpenInPicker.browser.test.tsx
  • apps/web/src/remoteOpen.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The editor fallback list now varies by platform. Browser tests verify local editor choices and remote-link selection, including opening the expected Zed SSH URL.

Changes: Editor fallback and picker behavior

Layer / File(s)Summary
Platform-specific fallback and picker behavior
apps/web/src/remoteOpen.ts, apps/web/src/components/chat/OpenInPicker.browser.test.tsx
The hook uses all remote-capable editors as the browser fallback and the desktop fallback list on desktop. Browser tests check the local editor menu, remote-link choices, and Zed URL handling.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge, yash-singh1

Merge Risk: ⚪ Minimal · up to b071e

The editor picker behavior is correctly connected for the supported browser and desktop modes, with no established merge-blocking risk.

Pre-merge checks: Passed 4
Check nameStatusExplanation
Title checkPassedThe title clearly and concisely describes the main change: showing supported remote editors in the web picker.
Description checkPassedThe description explains the problem, the fix, scope, verification results, test coverage, UI evidence, and untested native launch path. It does not use the template headings or link an issue or appro…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, the fix, scope, verification results, test coverage, UI evidence, and untested native launch path. It does not use the template headings or link an issue or approval, but it provides enough focused context for this small bug fix.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Note

Written by gpt-6.1-sol on behalf of Maria

thanks @ulughbeck. your pr correctly separates browser remote links from desktop detection and local host editors, and exercises selecting and opening zed.

i rebuilt it in https://git.cafe/pingdotgg/t3code/pulls/25490 because your fork does not allow maintainer edits. it offers the same supported remote editors while preserving vs code as the fresh default and retaining saved selections. the expanded choices still need maria's approval.

i compared your original diff with the replacement. the fallback/cache/effect changes became one early return in main's current atom implementation. the local-menu and remote-zed coverage remains in the existing test file; the remote regression now also checks the vs code default and favorite-editor shortcut. no intended editor support was dropped.

blacksmith vp run check:changed passed format, lint, knip, affected typechecks, and 20 tests. real chrome verified the remote menu, saved zed selection after reload, and the advertised zed ssh URL request. native editor launch, packaged desktop, mobile, and relay/tunnel transports remain unverified. before/after screenshots and a recording are in the replacement.