Sign up
pingdotgg
/
t3code
Code
Issues
Pulls
CI
Stacks
Search
Branches
Tags
Code
Issues
Pulls
CI
Stacks
Search
Branches
Tags
More
View stargazers
13
Sign up
Code
fix(server): retain the runtime used by the service launcher
#23247
draft
1
3
main
fix/issue-17490
opened
4d ago
by
J
Julius Marminge
7 files changed
View on GitHub
Two-way sync enabled
PR last imported 2d ago
Conversation
5
Commits
Files changed
1 unresolved
1 unresolved thread · Jump to file
apps/server/src/serviceLauncher.ts:563 · 🟠 **High** `src/serviceLauncher.ts:563` A concurrent successful `install({ start: false })` can ha
Selected thread:
apps/server/src/serviceLauncher.ts
:563 — 🟠 **High** `src/serviceLauncher.ts:563` A concurrent successful `install({ start: false })` can have its new `launcherVersion` overwritten with the old value, leaving service state pointing at launcher A and allowing pruning to remove launcher B even though the unit was repointed to B. `#writeState` reads the state before the installer writes B, then atomically writes its stale merged state afterward; coordinate this merge and write with the install/repoint operation so the installed version is preserved. <details> <summary>🚀 Reply "<strong>fix it for me</strong>" or copy this <strong>AI Prompt</strong> for your agent:</summary> ```text In file @apps/server/src/serviceLauncher.ts around line 563: A concurrent successful `install({ start: false })` can have its new `launcherVersion` overwritten with the old value, leaving service state pointing at launcher A and allowing pruning to remove launcher B even though the unit was repointed to B. `#writeState` reads the state before the installer writes B, then atomically writes its stale merged state afterward; coordinate this merge and write with the install/repoint operation so the installed version is preserved. ``` </details> <!-- macroscope-meta: {"kind":"code_review","variant":"dbca4b5e98da5ade3401563e99690a04"} -->
Files Changed
0 / 7 viewed
7 files changed
Line totals unavailable
Ignore whitespace
Unified
Split
apps/server/src
apps/server/src
…
cloud
cloud
…
bootService.test.ts
bootService.test.ts
…
bootService.ts
bootService.ts
…
pinnedRuntime.test.ts
pinnedRuntime.test.ts
…
pinnedRuntime.ts
pinnedRuntime.ts
…
serviceProtocol.ts
serviceProtocol.ts
…
serviceLauncher.test.ts
serviceLauncher.test.ts
…
serviceLauncher.ts
serviceLauncher.ts
…