In Material You dark, the composer's send button is nearly invisible while it is disabled (empty prompt). ComposerActionButton draws the onPrimary icon on primary at 15% opacity. onPrimary is meant for solid primary, and in dark schemes it is a dark tone (about tone 20). The result is a dark arrow on a faint tint over a dark surface.
The disabled state now uses the Material 3 disabled colors: onSurface at 12% for the container and at 38% for the icon (bg-foreground/12, accent-foreground/38). The enabled and danger states are unchanged.
Every composer that uses ComposerActionButton gets this, on all themes. The old style fails the same way in any theme whose primary foreground is dark against the surface.
This is a small, focused fix for an obvious bug, so it qualifies without a prior issue. The disabled send button was unreadable in Material You dark, and the change affects only that button's disabled colors.
Before: seen on a phone in Material You dark (screenshot below, new-thread composer with an empty prompt).
Contrast, computed with @material/material-color-utilities over the composer surface (surfaceContainerHigh at 90% over surfaceContainerLow), using dark tonal-spot schemes from three seeds:
| Seed | Before (onPrimary on 15% primary) | After (38% onSurface on 12% onSurface) |
|---|---|---|
#B3261E | 1.28:1 | 2.56:1 |
#6750A4 | 1.26:1 | 2.56:1 |
#386A20 | 1.26:1 | 2.57:1 |
The disabled state is intentionally below 3:1 per Material 3. The fix restores the spec's level instead of near-invisibility.
vp lint on the changed file passes.
Not checked: no "after" screenshot from a device build yet.
🤖 Generated with Claude Code (Claude Opus 5.5)
Added 1 commit
Verdict: Approved at 766870d
Macroscope's review found this PR approvable — This is a focused mobile UI bug fix that changes only the colors of an existing disabled composer action, leaving enabled and danger states and interaction behavior unchanged. It has no schema, security, deployment, default-configuration, or static-analysis implications.
You can add or adjust custom eligibility rules. Learn more.
Warning
Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.
Next included review available in 38 seconds.
Limit details: You’ve used all 10 included reviews currently available.
Review configuration:
5dbe8f66-5d2b-48c6-af1b-be7d34379374Reviewing files that changed from the base of the PR and between 67d773c2d89f610368766c2797ea8c4b380cea7d and 8c4c2fc2c7696334c94260d9cc0bf82a354327a7.
apps/mobile/src/components/ComposerToolbar.tsxNo actionable comments were generated in the recent review.
22d4a602-c423-4b40-8e27-273d26b9841eReviewing files that changed from the base of the PR and between b5a226e49c52ecab4ddc2d678a7012d97e651a6a and 766870d9494e861b396d73240d61d4caaf812227.
apps/mobile/src/components/ComposerToolbar.tsxIncluded review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Disabled non-danger composer action buttons now use a foreground-based background and icon tint. Danger button styling and enabled button icon tint remain unchanged.
Changes: Composer action styling
| Layer / File(s) | Summary |
|---|---|
Disabled action colors apps/mobile/src/components/ComposerToolbar.tsx | Disabled non-danger buttons use bg-foreground/12 and accent-foreground/38. Danger styling and enabled icon tint remain unchanged. Comments document the disabled colors. |
Priority: External image Low
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Bug fix
Suggested reviewers: juliusmarminge
76687The disabled-button styling change is mergeable; no current-head issue was found.
| Check name | Status | Explanation |
|---|---|---|
| Title check | Passed | The title is concise, conventional, and accurately identifies the disabled send button readability fix in Material You dark mode. |
| Linked Issues check | Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | Passed | Check skipped because no linked issues were found for this pull request. |
| Description check | Passed | The pull request description includes all required sections. It explains the problem, change, scope exemption, verification results, contrast measurements, lint status, and limitations. It also includ… |
Explanation
The pull request description includes all required sections. It explains the problem, change, scope exemption, verification results, contrast measurements, lint status, and limitations. It also includes before and after visual evidence and identifies the agent used.
Comment @coderabbitai help to get the list of available commands.
Added 2 commits
Note
Written by gpt-6.1-sol on behalf of Maria
thanks @RVZO6. your Material 3 disabled colors address the right bug: the icon now uses onSurface at 38% over an onSurface container at 12%.
i preserved your commit, merged current main without rebasing, and removed the explanatory code comment. the final diff is one file, six added lines and two removed lines. enabled/danger colors, sizes, disabled handling, and actions are unchanged. no overlapping focused fix was found.
verification at 8c4c2fc2c7696334c94260d9cc0bf82a354327a7:
vp run check:changed passed formatting, lint, both unused-code passes, and affected typechecks.vp test run apps/mobile/src/lib/nativeTheme.test.ts: 12 tests passed.all ci checks completed with no failures on this head. there are no inline review findings. native evidence remains the blocker to readiness. no replacement pr was created.
Note
Written by gpt-6.1-sol on behalf of Maria
no changed runtime behavior could be verified on this linux boat vm. inspected the description, discussion, commit authors, and diff at 8c4c2fc2c7696334c94260d9cc0bf82a354327a7. the pr is open and its pr commits have no authorship by @juliusmarminge or @t3dotgg. git.cafe mirror: https://git.cafe/pingdotgg/t3code/pulls/23161.
the diff changes only native mobile ComposerActionButton disabled colors. web captures would not exercise this native component. git.cafe reports 27 successful checks, zero failing and zero pending. these do not establish native behavior.
native main reproduction, matching before/after captures, Material You dark contrast, empty-prompt disabled behavior, enabled send, danger/stop behavior, and a real Codex gpt-6.1-sol turn through the native client remain unverified.
attempted device_list. it returned exactly: Agent device access is turned off for this environment. the mobile verification skill requires stopping when device tools are unavailable and prohibits switching automation systems. no dev server, worktree, install, provider turn, or screenshot was started because this native-only path was blocked before runtime setup. no code changed.
verification needs device access enabled, then main and this exact head on Android with Material You dark, matching empty-prompt captures, and enabled-send plus stop checks through a real provider turn. iOS remains unverified as well.
Note
Written by gpt-6.1-sol on behalf of Maria
verified head 8c4c2fc2c7696334c94260d9cc0bf82a354327a7 on the t3 android emulator (1080x2400, api 35), using the cached native development client, metro on port 8081, and an isolated dev server on port 13773. paired the native app and created a real git project and threads through the app. used real codex gpt-6.1-sol turns through this vm's local proxy. no mocks or demo data.
no fix was needed. the checkout is clean and no commits were pushed. the current head has 27 successful ci checks, zero failing and zero pending; those are separate from the native verification above.
before: original disabled colors in material you dark
after: readable disabled send on the exact pr head
android: enabled send, real gpt-6.1-sol response, and return to disabled send
ios cannot run on this linux vm. a full github/main checkout, other themes, other android devices, and other providers were not exercised. no new static checks were run because no code changed. the recording is embedded as an animated image for github compatibility; its source mp4 playback and seeking were checked in the browser.