Sidebar.tsx is ~5,100 lines, and about a third of it is the thread row: the row itself, its sortable wrapper, the search-result row, and their tooltip, provider stack, snooze menu and time-label helpers.
This PR moves that code as-is into sidebar/SidebarThreadRow.tsx. Nothing changes in behavior or render boundaries: the code is the same, and the React Compiler still compiles both files with 0 bailouts.
| before | after | |
|---|---|---|
Sidebar.tsx | 5,108 lines | 3,483 lines |
sidebar/SidebarThreadRow.tsx | — | 1,675 lines |
Renders are unchanged because nothing moved across a subscription boundary. The render win is in the top layer of this stack.
Tests run:
vp test run src/reactCompilerCoverage.test.ts -t idebarSidebar.logic.test.tsSidebar.drag.test.tstsc for apps/webClaude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code
Review completed
Skipped - Not affected
Added 1 commit
Verdict: Approved at 12757e8
Macroscope's review found this PR approvable — The PR extracts existing sidebar thread-row implementations and their helpers into a dedicated module while preserving the existing callers and behavior. It introduces no new user-facing capability, product default, schema, deployment, or static-analysis configuration change.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review. 🎉
ec15df98-e748-430a-af6c-7dad739a6434Reviewing files that changed from the base of the PR and between 6a6c84f9906cbdfa7f533fecfc39ce18c2f4c273 and 12757e8bc5e470d60bc1dc0eac747a9a1293cb87.
apps/web/src/components/Sidebar.tsxapps/web/src/components/sidebar/SidebarThreadRow.tsxLimit details: You’ve used all 10 included reviews currently available.
Sidebar thread-row helpers and components move into SidebarThreadRow.tsx. Sidebar.tsx removes their local implementations and wires the sidebar to the extracted APIs.
Changes: Sidebar thread rows
| Layer / File(s) | Summary |
|---|---|
Shared row support apps/web/src/components/sidebar/SidebarThreadRow.tsx | Adds provider-entry data, time and provider helpers, tooltip and snooze UI, and sortable-row contracts. |
Thread-row behavior and rendering apps/web/src/components/sidebar/SidebarThreadRow.tsx, apps/web/src/components/Sidebar.tsx | Adds thread-row status and operation logic, drag-and-drop behavior, slim and card rendering, and a diff helper that returns null. Removes corresponding local helpers and row code from Sidebar.tsx. |
Search rows and Sidebar wiring apps/web/src/components/sidebar/SidebarThreadRow.tsx, apps/web/src/components/Sidebar.tsx | Adds the search-result row. Removes its local implementation and related declarations from Sidebar.tsx, which imports the extracted components, constants, and types. |
Priority: ⬇️ Low
Estimated code review effort: 4 (Complex) | ~45 minutes
Change: Refactor
Suggested reviewers: maria-rcks
12757This refactor moves the sidebar thread row code into its own file without intended behavior change. No concrete merge-blocking risk was identified.
Failed Failed checks: 1 warning
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | Warning | The description explains the change and lists verification steps, but it does not provide the required Problem or Scope and approval sections. It also does not include before-and-after screenshots req… | Add the required Problem section with expected behavior and reproduction or environment details. Add the Scope and approval section with the triaged issue, maintainer approval, or a valid exemption rationale. Add before-and-after screenshot… |
| Check name | Status | Explanation |
|---|---|---|
| Title check | Passed | The title clearly describes the main change: moving the sidebar thread rows into a separate file. It is concise and uses a valid conventional commit format. |
| Linked Issues check | Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | Passed | Check skipped because no linked issues were found for this pull request. |
Explanation
The description explains the change and lists verification steps, but it does not provide the required Problem or Scope and approval sections. It also does not include before-and-after screenshots required for a UI change.
Resolution
Add the required Problem section with expected behavior and reproduction or environment details. Add the Scope and approval section with the triaged issue, maintainer approval, or a valid exemption rationale. Add before-and-after screenshots, and include a recording if interaction details require it. Confirm and correct the reported test command if -t idebar is a typo for -t sidebar. Store no PR-only assets in the repository.
Note
This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.
Comment @coderabbitai help to get the list of available commands.