fix(mobile): label mixed thread and file mention results accurately#21456

Approvability

Verdict: Approved at 2faff92

Macroscope's review found this PR approvable — This is a focused mobile UI bug fix that accurately labels existing mixed thread/file search results, surfaces existing search failures, and preserves bare-@ behavior. The underlying search pipeline and external contracts are unchanged, with targeted regression tests covering the new states.

Notes:

• Code review disabled. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

Review in Change Stack →

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

thanks @only21mil. your fix correctly identifies the mixed thread/file search scope and makes the empty state reachable. i kept your commits and merged current main, without rebasing.

i removed unrelated matcher assertions from the label tests, kept file-search errors visible beside thread matches, and restricted that banner to mention searches. loading now waits for both files and older threads. stale errors clear while the query, environment, or project directory changes. bare @, selection actions, and other menus are preserved.

verification at 1794e1133688cd9bfdf1ba5ba0015c08d327fa35:

• blacksmith-check / vp run check:changed passed: format, lint (zero warnings), knip, mobile/scripts typecheck, and 17 tests. the added query/target and thread-loading regressions failed before their fixes. no new test files.
• two independent code reviewers approved this head after one review round and one follow-up.
• isolated dev server started and the web client loaded in system chrome. this does not verify the native composer.
• native interaction checks, matching before/after screenshots, and recording remain unverified: adb has no attached devices, and t3 reports "agent device access is turned off for this environment." the original screenshots remain historical evidence; no new native captures are claimed.
• all 28 ci checks are green, and the head is mergeable. the old stale-error review thread is resolved.
• coderabbit hit its review limit on the final head; the two independent code approvals above cover the final diff.

compared the original diff against the final change: labels, empty-panel visibility, and file-error handling are retained. only the unrelated matcher assertions were dropped; no feature was moved or removed.

Merged current main with a merge commit, retaining both the mention-loading regression test and main's caret-selection tests. The PR remains nine changed files with 175 insertions and 53 deletions against main.

At 2af9b56a1c764dd51bee72334eb0c41b92b260d1: all 28 reported checks pass, no conflicts, and two independent read-only reviews approve. Blacksmith vp run check:changed passes format, lint, both knip passes, both affected typechecks, and 20 tests in five files. Existing review findings are already addressed.

No production UI changes in this pass. Inspected the existing iOS mixed-results and Android empty-state evidence. Native interaction was not rerun on this VM.

Verified in a real dev environment

No changed behavior could be exercised on this Linux VM. This is an unverifiable result, not a runtime approval.

Read the description, diff, discussion, reviews, and commit authors for head 2af9b56a1c764dd51bee72334eb0c41b92b260d1. The PR is open and its PR commit list has no commits authored by juliusmarminge or t3dotgg. The changed production path is native mobile: type a nonblank @ query in a new or existing thread composer to search thread titles and workspace paths. The patch changes mixed-result labels, loading/empty visibility, file-search errors, and debounce error handling. Web does not render these components.

Prepared a separate github/main worktree at 570d4b03ee and ran vp i successfully. Device discovery then blocked runtime reproduction:

The repository's mobile verification skill requires stopping when device access is unavailable. No dev server or provider turn was started, no code was changed or pushed, and no runtime images/video were captured. Existing PR screenshots are historical evidence, not evidence from this pass. Cafe reports 28 successful checks, 0 failing and 0 pending; that does not establish runtime correctness.

Not verified

Original-bug reproduction on main and the fix on the PR head; native iOS/Android new and existing thread composers; mixed thread/file matches; loading and unmatched-query text; file-search errors alongside thread matches and during query/target changes; neighboring bare @, mention selection, and slash-command behavior; and a real Codex gpt-6.1-sol turn with selected context.

These require an available native client connected to the isolated dev server. Checking the web client with Playwright would not exercise this mobile-only diff. No before/after captures or interaction recording can be supplied from this run.

Verified on Android emulator (API 35) against a real dev server

blocked; no runtime verification is claimed in this pass.

read the diff, discussion, reviews, and commit authors at 2af9b56a1c764dd51bee72334eb0c41b92b260d1. the pr is open, its pr commit list contains no authors juliusmarminge or t3dotgg, and the change applies to android. git.cafe's matching pr is also #21456.

t3 device_list repeatedly returned:

the repository's test-t3-mobile skill requires stopping verification when device access is unavailable. requested that device access be enabled. no emulator, backend, metro, provider turn, code changes, or pushes were started. no screenshots or recording were captured. the 28 successful reported ci checks do not prove runtime behavior.

Not verified

ios; android original-bug reproduction on main; new and existing thread composers; mixed thread/file labels, loading and unmatched-query states; file-search errors alongside thread matches and during query/target changes; bare @, mention selection, slash commands, and real Codex gpt-6.1-sol turns with selected context. before/after screenshots and interaction recording remain unavailable until device access is enabled.

Verified on Android emulator (API 35) against a real dev server

verified head 2af9b56a1c764dd51bee72334eb0c41b92b260d1 on the t3 android emulator with a cached native dev client, metro, and an isolated backend on port 13773. no mocks or demo data.

• a real Codex gpt-6.1-sol turn read the server project's package.json and returned t3.
• @package found that real thread and workspace files. the heading reads "threads and files". selecting the thread inserted its context link; a second real Codex turn read the linked thread and returned t3.
• an unmatched query displays "no matching threads, files, or folders" in both new and existing thread composers.
• checked neighboring bare @ behavior and the /plan command picker. repeated mixed and empty searches with the android on-screen keyboard visible.
• reproduced the original behavior using a separate github/main checkout at 1cf14a498fa27712a305097012c6f8f920a6da33, its matching cached native client, and the same backend data: thread rows were labeled "files", and an unmatched query hid the panel.
• all 18 existing focused tests passed in 3 files through blacksmith: composer labels, composer menu, and search debounce. no code changes or pushes were needed.

before, main with the same query and data:

main labels real thread and file matches as files

after, pr head:

pr labels real thread and file matches as threads and files

before, unmatched query on main:

main hides the unmatched mention panel

after, the same unmatched query on the pr head:

pr shows the thread-aware empty message

interaction recording at 2x speed: bare mention, mixed results, thread selection, a real turn using selected context, existing-thread empty state, and slash command picker. playback and seeking checked after upload.

android mention selection and real codex context turn

Not verified

ios cannot run on this linux vm. physical devices, dark theme, restricted file-read connections, injected network failures, and loading-state timing were not exercised. the loading and debounce checks above are automated tests, not runtime evidence for those states. web and desktop do not render these mobile components.

at 9ef0e1aa1944d981e8566d93eb6ccbdd939e667f: all 29 checks are green, no conflicts, both github review threads resolved, and two independent read-only code reviewers approve this head.

merged current main with a merge commit, preserving all three conflicting mobile test entries. fixed the new initial-snapshot loading finding with 19 production lines and cases in the existing debounce test file. one existing filesystem test needed a shell mock. no new test files. final pr diff: 10 files, +239/-56; original: 9 files, +175/-53.

blacksmith vp run check:changed github/main passed format, lint, both knip passes, mobile/scripts typechecks, 27 focused tests, and 9 compiler checks. the snapshot regression failed before the fix and passed afterward. both task workers are stopped; no dev servers were started.

native runtime and fresh before/after evidence remain unverified. device_list returned Agent device access is turned off for this environment. the mobile verification skill requires stopping when device access is unavailable. historical android evidence remains in the discussion, but does not verify this new loading fix. handoff is waiting on that runtime check, not claiming merge readiness. no merge, rebase, force-push, or label changes were performed.

merged current main into the existing head without rebasing or force-pushing. the only conflict was in the query tests; both branch-pagination coverage and mention snapshot-loading coverage are preserved. no production changes beyond main's merge.

blacksmith-check passed vp run check:changed c6ef3b46ebed34fbefa1706674fe5748254cee18: format, lint (zero warnings), knip, mobile/scripts typechecks, 28 focused tests, and 10 compiler checks. both existing review threads are resolved. ci is running on 2c04fa7644a1d191491989463a7336f8572e87b3.

native interaction remains unverified: device access is turned off in this environment. browser checks cannot exercise this native mobile composer.

follow-up at b29ed9700268e996bfb3d5ba8c584d1115db8046: single-character mentions now wait for the first shell snapshot, since local title matching accepts one character. the existing test failed before the fix. older-thread search keeps its two-character threshold; bare mentions are unchanged.

merged newer main and preserved both react-test registrations. blacksmith vp run check:changed 1854e14d0943c9c80913d797bc8fa7eafc765e9c passed format, lint, knip, both affected typechecks, 28 tests, and 10 compiler checks. two independent reviewers approve this exact head.

native interaction remains unverified because device access is disabled. the preceding push had a failed Vercel marketing status without a deployment URL or GitHub Actions failure; the new head's checks must finish before readiness.