fix(web): preview images outside the workspace #21064 · pingdotgg/t3code

MmacroscopeappBotapproved these changes12d ago

Approvability

Verdict: Approved at 47e4e1f

Macroscope's review found this PR approvable — This is a narrowly scoped web bug fix that reuses the existing media-file path for external workspace images while preserving internal, explicit-media, and draft behavior. Targeted tests cover POSIX, normalized, Windows, and UNC paths, with no default or static-analysis configuration changes.

^{You can add or adjust custom eligibility rules. Learn more.}

CcoderabbitaiBot12d ago

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.config.ts
Review profile: CHILL
Plan: Advanced
Run ID: 7b9b76f9-3346-4ed4-93ed-955723da16eb

📥 Commits

Reviewing files that changed from the base of the PR and between 16918b57d6754d6f145e9b6367c825aa31a740da and 47e4e1fe56d554533f2cfc5642b07f674bd8eb1d.

📒 Files selected for processing: 2

apps/web/src/components/files/FilePreviewPanel.test.ts
apps/web/src/components/files/filePreviewMode.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

workspaceAssetResource now classifies non-draft workspace-file resources without a relative path as media-file resources. Tests cover workspace boundaries, Windows path casing, explicit media requests, and draft mode.

Changes: Workspace asset classification

Layer / File(s)	Summary
Resource selection and path coverage `apps/web/src/components/files/filePreviewMode.ts`, `apps/web/src/components/files/FilePreviewPanel.test.ts`	For non-draft resources, `workspaceAssetResource` changes the kind from `workspace-file` to `media-file` when the media reference has no relative path. Tests cover in-workspace and outside-workspace paths, Windows path casing, explicit media requests, and draft mode.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 47e4e

Outside-workspace image previews use the media-file path, and no merge-blocking issue remains after normal checks.

### Architecture Summary

Architecture risk: 🔵 Low · up to 47e4e

The change affects 1 system.

Changed systems: apps/web

Architecture concerns No architecture-level concerns identified.

Review details

Systems and components

observed — apps/web (ui) was modified; 2 changed files map to changed impact.

Before / after behavior

observed — Modified behavior in apps/web/src/components/files/FilePreviewPanel.test.ts: Adds workspaceAssetResource test cases expecting in-workspace images to use the workspace-file resource and outside-workspace images—including sibling-prefix paths, traversal paths, and paths on another drive—to use media-file. The cases also cover case-insensitive Windows paths, explicit media requests inside the workspace, and an outside-workspace image in draft mode expecting a draft-workspace-file resource.
observed — Modified behavior in apps/web/src/components/files/filePreviewMode.ts: Adds the mediaFileReference import used to determine whether a workspace file should be represented as a media file.
observed — Modified behavior in apps/web/src/components/files/filePreviewMode.ts: For non-draft resources, workspaceAssetResource now converts "workspace-file" to "media-file" when the media reference has no relativePath; otherwise it preserves the input kind. The returned resource retains the same thread ID and absolute path.

Pre-merge checks: ^Passed 4

Check name	Status	Explanation
Linked Issues check	Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	Passed	Check skipped because no linked issues were found for this pull request.
Title check	Passed	The title clearly and concisely describes the primary fix: allowing preview of images located outside the workspace.
Description check	Passed	The description covers the problem, implementation, scope approval through the linked issue, focused tests, browser verification, screenshots, recording, limitations, and agent details.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

JJulius Marminge11d ago

Taking over this one. I’ll reduce the tests to the useful coverage, update the implementation against current main, and verify it before publishing the changes.

JJulius Marminge5d ago

Taking over this one

JJulius Marminge5d ago

Thanks @trahane for the fix. Taken over in #24627, retaining your shared media-resource selection approach on current main, with minimal regression tests and verified before/after browser evidence. Closing this fork PR in favor of the credited replacement; your branch is unchanged.

fix(web): preview images outside the workspace#21064

Checks

Approvability