fix(web): Stop shows a pending state and repeat clicks no longer resume#20809

Approvability

Verdict: Approved at 32b15c5

Macroscope's review found this PR approvable — This is a self-contained one-file UI bug fix that adds a temporary pending state to the existing Stop/Resume control, preventing accidental repeat clicks without changing APIs, schemas, or product defaults. Its runtime impact is narrowly limited to the control’s local timing, disabled state, and labels.

^{You can add or adjust custom eligibility rules. Learn more.}

Review in Change Stack →

No actionable comments were generated in the recent review.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

External image Recent review info

External image Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 3cbc982
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 43ec3839-be1f-4889-bac2-f25cc1b511ad

External image Commits

Reviewing files that changed from the base of the PR and between 43b13cab8f4a79b8a66f45c49338cef0ebac935a and 48f384a2c485ba9818ace77eda11cb5985827ae5.

External image Files selected for processing: 4

• apps/web/src/components/chat/ChatComposer.tsx
• apps/web/src/components/chat/ComposerFooterControls.tsx
• apps/web/src/components/chat/ComposerPrimaryActions.browser.test.tsx
• apps/web/src/components/chat/ComposerPrimaryActions.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Validated b8a4ef698e with a local Codex turn and the mounted regression test. The new-run guard clears correctly, and Stop disables immediately (36 ms in the browser). One gap remains: repeat clicks that last beyond the 1 s landed guard still resume. With clicks every 100 ms, Stop became disabled Stopping at 36 ms, Resume was disabled at 1381 ms, then enabled at 2406 ms. The next click sent "Continue where you left off." and started another run. A mounted test that renders canInterrupt=false, advances 1100 ms and clicks the same last-button slot reproduces it (onResume called 20 times for 20 clicks).

We are carrying your three commits with authorship intact in Signalbox for #741 / #779 item 5. I am testing a small follow-up that keeps the old Stop target disabled once settled and places the existing Resume control beside it, so safety does not depend on how long the user keeps clicking. I will link the patch and demo here once verified.

Follow-up patch is now public in https://github.com/JustYannicc/signalbox/pull/781 (commit e101c52f4535ffa66458eaf552d825b8d4096d70), after carrying your three commits with original authorship. It keeps the original Stop target disabled after settling and puts Resume alongside it, removing the timed same-target swap. The regression clicks the mounted old target 20 times after 1100 ms: 20 Resume calls on b8a4ef698e, zero with the patch; explicit Resume still works. All 8 component tests, targeted lint and web typecheck pass. Local real Claude Opus 5.5 and GPT-6.1 Sol turns both stop; 35 repeated clicks at the original coordinates send zero Continue messages. Deliberate Resume starts a new turn whose Stop is immediately enabled. Happy for you to take the follow-up commit into this PR.

Thanks @JustYannicc, great catch on repeat clicks outlasting the 1 s guard, and for the follow-up patch. I took your approach from e101c52 into cd049fc and added you as co-author. Two small changes on top: dropped the sendLock check since it isn't on this base, and keyed the footer actions by thread so a pending stop doesn't carry over when switching threads. Appreciate the help!

Signalbox now carries cd049fc and the latest 60d547a as cherry-picks with your authorship preserved in https://github.com/JustYannicc/signalbox/pull/781. The only fork delta is the existing send-lock guard.

Thread keying checked out on the deployed preview: switched while Opus Stop was disabled "Stopping" into a running Sol thread, whose Stop was enabled immediately. Both real provider turns stop; 20 repeated Opus clicks and 35 repeated Sol clicks sent no Continue messages. All 10 of your component tests pass unchanged. Thanks for taking the follow-up.

Pulled in 43b13ca too, with its permission-loss regression. That test fails before the guard and passes after; all 11 component tests pass here. We retained our current jsdom harness because the browser-test infrastructure migration isn't on Signalbox's base yet. Runtime changes now match this PR, plus our send-lock hook.

Fixed in 68b31e4013. The landed layout no longer depends on showResume, so the Stopped button keeps its slot beside Resume or Submit. The compact toggle stays visible when typed text leaves compactTokens non-null. New test: stop lands, then typed text with compact tokens, then 20 clicks on the old slot send 0 submits and 0 Resume calls, with Stopped disabled and the compact toggle shown.

Taking over this one as maintainer for batch web-misc-06. I’ll preserve the original commits, reduce the tests to focused regressions, and verify Stop/Resume interaction and thread-switch behavior before pushing. Credit to @voida6 for the fix. No merge planned.

@coderabbitai resume

Maintainer takeover is now at 82e823c. Both independent full-diff reviews found no blockers. Please review this head; the old Stop position stays inert beside Resume and Submit. Updated Linux interaction evidence and verification limits are in the description.

@juliusmarminge I’ll resume automatic reviews and review head 82e823c. The review will cover the inert Stop position beside Resume and Submit, thread-switch behavior, and the Linux evidence and verification limits in the PR description.

updated the original branch, keeping @voida6's commits and the pending/stopped interaction. merged main, reduced the old test harness to focused disposable browser regressions, and tied reset to the executing run so reconnects and queue holds cannot leave stale state or expose resume under repeated clicks. production changes stay in three composer files.

verification at ce7b6a5c07439b4e3bdcfc89df227205a06ea294:

• blacksmith vp run check:changed 071239804e375078dd3fae3b14704b4def57e048: format, lint, knip, affected typechecks and seven browser regressions pass. five original regressions fail on main; reconnect and completion regressions fail without their fixes.
• real linux chrome and codex provider: main stop becomes resume at the same coordinates and a repeat click starts a turn. this head keeps stopped at that position, with resume 40px left. twenty repeat clicks do nothing; typing does not send; explicit resume starts a run with stop enabled; switching to a new thread and back clears stopped state. queued follow-up plus stop also stays inert. checked 1280px light/dark and 390px dark.
• two independent reviews, one follow-up each, found the reconnect and queued-run identity issues addressed above. the final queue correction was checked by tests and the real provider/client path; no third review round was requested.

unverified: native desktop/mobile, other providers, cross-environment navigation, and a real disconnect/remote-resume race (the latter has a browser regression). an immediate interrupt RPC failure retains stopping until the ten-second retry window; the existing error display remains available.

matching composer crops, main then fixed:

main: resume occupies the stop target

fixed: stopped target remains beside resume

main: repeat click resumes a real codex turn

fixed: repeated clicks, draft, new run and thread-switch reset

final head: queued follow-up and repeated stop clicks

390px dark: stopped stays beside resume with a queued message

final ci: 28/28 checks green, no conflicts. bot comments reread after checks; no new actionable finding. ready for maria's review.

Merged main in to clear the conflict (48f384a2c4); no rebase or force-push, your commits are untouched. Resolution, all following main's composer changes:

• ChatComposer.tsx: kept the per-thread Stop key and took main's compact={isComposerPrimaryActionsCompact} (#25869 removed isComposerResting).
• ComposerPrimaryActions.tsx: kept the button-array structure and dropped isConnecting from the Refine label, since main removed that prop. Also dropped it from the browser test's props.
• Renamed the Stop timer effect's lint directive from react-effect-budget to no-unreasoned-state-sync, which main now enforces.

No behavior changes beyond that. Required checks are green on the merge commit.