fix(gitlab): look up a pasted repository URL by its project path#20275

GitLab repository lookup now derives project paths from repository URLs, accounts for a matching configured install root, and checks whether the resolved host and path match the requested URL.

Changes: GitLab repository URL lookup

Layer / File(s)	Summary
Project path lookup packages/source-control-gitlab/src/server/GitLabCli.ts, packages/source-control-gitlab/src/server/GitLabCli.test.ts	The lookup extracts repository paths from URLs and removes a matching configured install root before querying the project API. Tests cover URL schemes, ports, nested paths, and SSH remotes.
Repository identity validation packages/source-control-gitlab/src/server/GitLabCli.ts, packages/source-control-gitlab/src/server/GitLabCli.test.ts	The CLI adds typed host- and path-mismatch errors and checks resolved repository identity against the requested URL. Tests cover host, port, and path mismatches.

Priority: External image Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Possibly related issues

• pingdotgg/t3code#20226: Both concern project path resolution for self-hosted GitLab URLs with a prefix. This PR handles a configured web install root but not the issue’s separate subfolder configuration.

Possibly related PRs

• pingdotgg/t3code#24000: Removes the ./server/GitLabCli package export, which affects access to the new error classes in this PR.
• pingdotgg/t3code#24181: Removes the same package export while moving forge definitions to shared modules, affecting access to the new error classes.

Suggested reviewers: juliusmarminge

Repository lookup is mergeable with a bounded caveat: a host-mismatch error may suggest a configuration command that does not resolve the problem. Correct the guidance and strengthen the install-root test when practical.

The lookup adds host, web-port and repository-path checks without letting a pasted URL select the authenticated GitLab server. No introduced security defect was established. Remaining uncertainty concerns real CLI configuration behavior and the existing trust placed in server-provided clone URLs.

Retained concerns No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The demonstrated PR-specific influence is repository selection within the existing CLI environment. Downstream cloning still uses the existing Git and SSH authority; the inspected change does not grant input control over CLI credential-host selection or add deployment privileges.

Security Findings and Attack Paths

• inferred — An inconsistent API response could pass web-identity checks while supplying a different SSH clone destination. However, the base already accepted that SSH field without independent identity validation, and the unchanged clone service already preferred it. This is an existing provider-trust assumption, not an established introduced or worsened attack path.

Trust Boundaries and Controls

• observed — Repository input remains encoded inside a single projects endpoint argument. The added rejection checks run after the API response but before clone URLs are released. Inspected tests explicitly expect host-mismatch errors for another hostname and another web port.

Resilience and Maintainability Implications

• inferred — For parsed web URLs, failure to obtain usable install-root configuration can cause lookup failure, but it does not remove the final returned host and path checks. The fallback therefore preserves the inspected identity gate rather than silently accepting a different returned web path.

^Failed Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check	Warning	The description explains the problem, implementation, scope, verification, limitations, test results, and CI status. However, the Scope and approval requirement is incomplete because it does not provi…	Add a link to an explicit maintainer approval comment covering the direction and scope, or explain why this focused fix qualifies for an approval exemption. Update the description when approval is obtained.

^Passed Passed checks: 3 passed

Check name	Status	Explanation
Title check	Passed	The title clearly describes the primary change: resolving pasted GitLab repository URLs by project path. It is concise and uses a valid conventional commit format.
Linked Issues check	Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, implementation, scope, verification, limitations, test results, and CI status. However, the Scope and approval requirement is incomplete because it does not provide an explicit maintainer approval comment for the requested direction and scope, and it states that human approval remains pending.

Resolution

Add a link to an explicit maintainer approval comment covering the direction and scope, or explain why this focused fix qualifies for an approval exemption. Update the description when approval is obtained.

🧪 Generate unit tests (beta)

• Create a new PR

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.