Healthy slow connections can be dropped when a health check or cached T3 Connect ticket takes more than three seconds. The shared connection supervisor now gives quick probes six seconds and extends them when raw WebSocket messages still arrive, with an absolute fifteen-second cap. Cached ticket requests also get six seconds, including learned LAN and tailnet routes.
Frame counting runs before the RPC read loop, so a full subscription buffer cannot hide incoming traffic. The message listener belongs to the socket scope and is removed on release. Mobile returns from an inactive state without a background visit reset retries and check for a better route without probing or resubscribing shell/thread streams. Genuine background resumes retain their existing probe/reconnect behavior. Effect's five-second ping cadence, direct endpoint identity checks, and current main's token-preservation rules are unchanged.
Maintainer takeover of #19426, building on @t3dotgg's work and @nick-potts's original contribution in #18704. All contributor commits are preserved; current main was merged and follow-ups simplify the tests, socket ownership, and comments.
Verification on headless Linux, Node 24, at aa7bb7087e:
Tests: GPT-6-Astra (high); implementation: GPT-6.1-Sol (high); adversarial reviews: Claude Opus 5.5 and GPT-6-Sol through T3 Code delegated tasks. Coordinated with GPT-6.1-Sol through the Codex harness in T3 Code.
Review completed
Added 4 commits
Verdict: Needs Human Approval
Macroscope's review found this PR requires human approval — This PR changes default connection and cached-ticket timeouts and modifies central WebSocket, mobile lifecycle, and authorization behavior. Those production defaults and authorization-path changes require human review despite the focused tests and otherwise targeted bug-fix scope.
You can add or adjust custom eligibility rules. Learn more.
✅ Thread transfer remains within every enforced ceiling.
| Provider | Metric | Main baseline | This PR | Impact | PR ceiling | |
|---|---|---|---|---|---|---|
| Codex | Total thread wire | 5.0 KiB | 5.0 KiB | −7 B (−0.1%) | 6.8 KiB | ✅ |
| Codex | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Codex | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | −7 B (−0.6%) | 2.0 KiB | ✅ |
| Codex | Live turn WebSocket decoded | 20.9 KiB | 20.9 KiB | 0 B (0.0%) | 29.3 KiB | ✅ |
| Codex | Live turn messages | 2 | 2 | 0 (0.0%) | 8 | ✅ |
| Claude | Total thread wire | 5.0 KiB | 5.0 KiB | +24 B (+0.5%) | 6.8 KiB | ✅ |
| Claude | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Claude | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | +24 B (+2.0%) | 2.0 KiB | ✅ |
| Claude | Live turn WebSocket decoded | 21.2 KiB | 21.2 KiB | +41 B (+0.2%) | 29.3 KiB | ✅ |
| Claude | Live turn messages | 1 | 2 | +1 (+100.0%) | 8 | ✅ |
Baseline: dd5c7bd · PR result: b57afe0 · Source CI: success
10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.
No actionable comments were generated in the recent review. 🎉
b2e1ff20-b7fc-4b55-b6da-50daaf8c4e85Reviewing files that changed from the base of the PR and between b57afe0fa54f4769fdcdf3d38e67bd8c08e74b3e and aa7bb7087eb8390248c6fd8ea06329a21bc105ca.
apps/mobile/src/connection/app-state-wakeups.test.tsapps/mobile/src/connection/app-state-wakeups.tsdocs/internals/connection-runtime.mdpackages/client-runtime/src/authorization/layer.test.tspackages/client-runtime/src/authorization/service.tspackages/client-runtime/src/connection/registry.test.tspackages/client-runtime/src/connection/supervisor.test.tspackages/client-runtime/src/connection/supervisor.tspackages/client-runtime/src/connection/wakeups.tspackages/client-runtime/src/operations/commands.performance.test.tspackages/client-runtime/src/rpc/session.test.tspackages/client-runtime/src/rpc/session.tspackages/client-runtime/src/state/server.test.tspackages/client-runtime/src/state/serverUsage.test.tspackages/client-runtime/src/state/shell-sync.test.tspackages/client-runtime/src/state/threads-sync.test.tsIncluded review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
The connection runtime now counts incoming WebSocket frames and uses frame activity when timing session probes. Mobile wakeups distinguish brief refocus from background visits. The cached-endpoint socket timeout increases from three to six seconds.
Changes: Connection runtime
| Layer / File(s) | Summary |
|---|---|
RPC received-frame counting packages/client-runtime/src/rpc/session.ts, packages/client-runtime/src/rpc/session.test.ts, packages/client-runtime/src/connection/registry.test.ts, packages/client-runtime/src/operations/*.test.ts, packages/client-runtime/src/rpc/client.test.ts, packages/client-runtime/src/state/*.test.ts, apps/web/src/cloud/linkEnvironment.test.ts | RpcSession counts WebSocket message events and exposes the count through receivedFrames. Session mocks and fixtures provide the new field. A test checks that a Pong is counted while the config-stream consumer is blocked. |
Probe timing and frame-driven extensions packages/client-runtime/src/connection/supervisor.ts, packages/client-runtime/src/connection/supervisor.test.ts, docs/internals/connection-runtime.md | Quick probes use a six-second window. Incoming frames can extend a probe deadline, up to 15 seconds from probe start; retry signals can shorten the deadline and set its extension window. Tests cover probe timing, and the connection-runtime documentation describes the behavior. |
Cached-endpoint authorization timeout packages/client-runtime/src/authorization/service.ts, packages/client-runtime/src/authorization/layer.test.ts | The cached-endpoint socket timeout increases to six seconds. Tests cover delayed ticket responses and a pending cached-endpoint request that proceeds through relay bootstrap after six seconds. |
Mobile refocus wakeups apps/mobile/src/connection/app-state-wakeups.ts, apps/mobile/src/connection/app-state-wakeups.test.ts, apps/mobile/src/connection/platform.ts, packages/client-runtime/src/connection/wakeups.ts, packages/client-runtime/src/connection/supervisor.test.ts, packages/client-runtime/src/state/shell-sync.test.ts, packages/client-runtime/src/state/threads-sync.test.ts, docs/internals/connection-runtime.md | Mobile returns without a background timestamp now emit application-refocused. The runtime classifies it as an application-active wakeup. Tests cover retry behavior, connected-session behavior, and state wakeup handling. |
Priority: ➖ Normal
Estimated code review effort: 3 (Moderate) | ~25 minutes
Change: Bug fix
| 1 | sequenceDiagram |
| 2 | participant WebSocket |
| 3 | participant RpcSession |
| 4 | participant ConnectionSupervisor |
| 5 | WebSocket->>RpcSession: message event increments received-frame count |
| 6 | ConnectionSupervisor->>RpcSession: read receivedFrames at probe deadline |
| 7 | alt New frames arrived and the 15-second cap remains |
| 8 | ConnectionSupervisor->>ConnectionSupervisor: extend deadline by current probe window |
| 9 | else No new frames or the cap is reached |
| 10 | ConnectionSupervisor->>ConnectionSupervisor: handle probe timeout |
| 11 | end |
Possibly related PRs
Suggested reviewers: juliusmarminge
aa7bbNo concrete merge-blocking issue remains; proceed with normal checks.
| Check name | Status | Explanation |
|---|---|---|
| Title check | Passed | The title clearly and concisely describes the main change: preventing healthy slow client connections from being dropped. |
| Linked Issues check | Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | Passed | Check skipped because no linked issues were found for this pull request. |
| Description check | Passed | The description is detailed and covers the problem, implementation, scope, verification results, limitations, trade-offs, and contributor or maintainer context. It does not use the template section he… |
Explanation
The description is detailed and covers the problem, implementation, scope, verification results, limitations, trade-offs, and contributor or maintainer context. It does not use the template section headings, but the required information is present and the description is relevant and substantially complete.
Comment @coderabbitai help to get the list of available commands.
Added 1 commit
Taking over this one as maintainer for batch ssh-relay-remote-10. I will preserve the contributor commits, merge current main, simplify the implementation and tests, and push follow-ups here. Slow-link and native verification limits will stay explicit; this remains unmerged pending human approval.
