refactor(desktop): classify electron exports#10266

merged1

cleanup-desktop/runtime-core

cleanup-desktop/electron-helpers

openedSep 6, 2026byJJulius Marminge

View on GitHubTwo-way sync enabledPR last imported 4d ago

1 unresolved thread · Jump to file

apps/desktop/src/electron/ElectronApp.ts:101 ·  `electron/ElectronApp.ts:101` `make` is part of the canonical public shape o

Selected thread: apps/desktop/src/electron/ElectronApp.ts:101 —  `electron/ElectronApp.ts:101` `make` is part of the canonical public shape of a service module that owns construction (`Foo.Foo`, `Foo.make`, `Foo.layer`), so consider keeping it exported even though only the local `layer` consumes it today — that is what `packages/client-runtime/src/connection/driver.ts` does, where the unused-export lint is silenced with a tag comment (`/** @public Service construction is part of the canonical Effect module API. */`) rather than by dropping `export`. ```suggestion export const make = ElectronApp.of({ ``` No longer relevant as of eca58d022256cf5584ba343ff8925a02aecc00bb

0 / 10 viewed10 files changedLine totals unavailable

apps/desktop/src/electron/ElectronApp.ts · Earlier revision ad29bf10 · right 101

Original diff

@@ -98,7 +98,7 @@ const addScopedAppListener = <Args extends ReadonlyArray<unknown>>(
       }),
   ).pipe(Effect.asVoid);
 
-export const make = ElectronApp.of({
+const make = ElectronApp.of({

macroscopeappBotSep 6, 2026

electron/ElectronApp.ts:101

make is part of the canonical public shape of a service module that owns construction (Foo.Foo, Foo.make, Foo.layer), so consider keeping it exported even though only the local layer consumes it today — that is what packages/client-runtime/src/connection/driver.ts does, where the unused-export lint is silenced with a tag comment (/** @public Service construction is part of the canonical Effect module API. */) rather than by dropping export.

suggestion

1	export const make = ElectronApp.of({

No longer relevant as of eca58d022256cf5584ba343ff8925a02aecc00bb