Sign up
View stargazers13Sign up

refactor(desktop): classify backend exports#10265

merged1
main
cleanup-desktop/runtime-core
openedSep 6, 2026byJJulius Marminge
10 files changed
View on GitHubTwo-way sync enabledPR last imported 4d ago
1 unresolved thread · Jump to file
Selected thread: apps/desktop/src/backend/DesktopBackendConfiguration.ts:740 — <!-- MURMUR_IGNORE --> `backend/DesktopBackendConfiguration.ts:740` This module owns construction of the service, so `make` is part of its public shape (`DesktopBackendConfiguration.make` alongside `.layer`) — the convention is to export a real `make` in that case, even when only `layer` is consumed today (cf. `packages/client-runtime/src/connection/driver.ts`, which documents the exported `make` as "part of the canonical Effect module API"). Suggest keeping the export. ```suggestion export const make = Effect.gen(function* () { ``` No longer relevant as of d12e01b8c6b22163a4f80b577c1e6ed8f6c4469e <!-- macroscope-meta: {"kind":"code_review"} -->
0 / 10 viewed10 files changedLine totals unavailable

apps/desktop/src/backend/DesktopBackendConfiguration.ts · Earlier revision b6306d8e · right 740

Original diff
@@ -737,7 +737,7 @@ const resolveWslStartConfig = Effect.fn("desktop.backendConfiguration.resolveWsl
   } satisfies DesktopBackendManager.DesktopBackendStartConfig;
 });
 
-export const make = Effect.gen(function* () {
+const make = Effect.gen(function* () {
M
macroscopeappBotSep 6, 2026

backend/DesktopBackendConfiguration.ts:740

This module owns construction of the service, so make is part of its public shape (DesktopBackendConfiguration.make alongside .layer) — the convention is to export a real make in that case, even when only layer is consumed today (cf. packages/client-runtime/src/connection/driver.ts, which documents the exported make as "part of the canonical Effect module API"). Suggest keeping the export.

suggestion
1export const make = Effect.gen(function* () {

No longer relevant as of d12e01b8c6b22163a4f80b577c1e6ed8f6c4469e