refactor(web): keep app utilities private and remove dead helpers#10227

merged1
cleanup-web/component-internals
cleanup-web/app-internals
openedSep 5, 2026byJJulius Marminge
View on GitHubTwo-way sync enabledPR last imported 3d ago

Web app utilities export implementation details without external consumers. Keep locally used helpers and constants private, and remove the dead preview-refresh shortcut wrapper, review-comment predicate, and theme labels.

Exported types and Effect schemas remain allowed. Existing behavior tests and the shared React hook test harness remain in place. Core UI component modules are unchanged.

Layer 3 of 4 in the web runtime-export cleanup stack. Based on #10226.

Verification at the integrated stack tip: vp run --filter @t3tools/web test passes all 4,052 tests across 333 files. Web typecheck and changed-file lint/format pass. vp run knip:check passes. A negative probe confirmed that a wholly unused components/ui/*.tsx file still fails the file audit.

Model: gpt-6 astra. Harness: Codex in T3 Code.

Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—13.6 KiB—15.1 KiB✅
CodexThread snapshot wire—7.0 KiB—7.3 KiB✅
CodexLive turn WebSocket wire—6.6 KiB—7.8 KiB✅
CodexLive turn WebSocket decoded—57.1 KiB—66.4 KiB✅
CodexLive turn messages—10—21✅
ClaudeTotal thread wire—13.6 KiB—15.1 KiB✅
ClaudeThread snapshot wire—7.0 KiB—7.3 KiB✅
ClaudeLive turn WebSocket wire—6.5 KiB—7.8 KiB✅
ClaudeLive turn WebSocket decoded—57.8 KiB—66.4 KiB✅
ClaudeLive turn messages—9—21✅

Baseline: unavailable · PR result: ce43c55 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Synced from GitHub

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

Synced from GitHub

Approvability

Verdict: Approved at 01dbe80

Macroscope's review found this PR approvable — The PR only narrows private web-module exports and removes unused helpers; existing runtime logic, stored values, and application paths remain unchanged. The web package is private and no dependent callers of the removed exports were found.

No code changes detected at ce43c55. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

Added 1 commit

  • refactor(web): keep app utilities private and remove dead helpersce43c55