Sign up
View stargazers13Sign up

ci: reject unused SSH exports with Knip#10145

merged1
cleanup-ssh/private-exports
cleanup-ssh/knip-gate
openedSep 5, 2026byJJulius Marminge
1 files changed
View on GitHubTwo-way sync enabledPR last imported 4d ago

SSH's unused exports are now cleaned up in the preceding layer. Add packages/ssh to the existing Knip export check so CI rejects new unused SSH exports and types.

The existing files/dependencies check and other workspace checks stay enabled. No dependencies, suppressions, or entry-point exceptions are added.

Verification: vp run knip:check passes with SSH included. The preceding layer resolves the 17 SSH findings that would otherwise fail this gate. No runtime or UI changes.

Model: gpt-6 astra. Harness: Codex in T3 Code.

Note

Add packages/ssh to knip:check workspace list

Extends the Knip export analysis to cover the packages/ssh workspace so unused SSH exports are caught in CI.

Macroscope summarized 2cf0792.

Added 1 commit

  • ci: reject unused SSH exports with Knip2cf0792
Ggithub-actionsBotSep 5, 2026
Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire—13.6 KiB—15.1 KiB✅
CodexThread snapshot wire—7.0 KiB—7.3 KiB✅
CodexLive turn WebSocket wire—6.6 KiB—7.8 KiB✅
CodexLive turn WebSocket decoded—57.1 KiB—66.4 KiB✅
CodexLive turn messages—10—21✅
ClaudeTotal thread wire—13.6 KiB—15.1 KiB✅
ClaudeThread snapshot wire—7.0 KiB—7.3 KiB✅
ClaudeLive turn WebSocket wire—6.5 KiB—7.8 KiB✅
ClaudeLive turn WebSocket decoded—57.9 KiB—66.4 KiB✅
ClaudeLive turn messages—10—21✅

Baseline: unavailable · PR result: 2cf0792 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

MmacroscopeappBotSep 5, 2026
Synced from GitHub

Approvability

Verdict: Approved at 2cf0792

Macroscope's review found this PR approvable — This is a small CI-only change that extends the existing Knip export check to the SSH workspace, with no product runtime, default, schema, or deployment impact. It broadens static-analysis coverage rather than suppressing diagnostics.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.