Sign up
View stargazers13Sign up

refactor(tailscale): keep package internals private#10011

merged1
main
t3code/knip-stricter-entry-audit
openedSep 5, 2026byJJulius Marminge
1 files changed
View on GitHubTwo-way sync enabledPR last imported 3d ago

Knip reports four unused value exports and one unused type export in the private Tailscale package. Repository-wide references confirm the values are used only inside their module and the type alias has no callers.

Make the two internal timeouts, stderr classifier, and output-error class private; remove the unused status-self type alias. Keep the runtime schema, public error union, command behavior, and tests unchanged. This leaves the package export-clean for the next CI layer.

Verification: the Tailscale and dev-share suites pass all 22 tests before and after. Package typecheck, targeted lint/format, and diff checks pass. The package Knip export audit goes from five findings to zero.

Model: gpt-6 astra. Harness: Codex in T3 Code.

Added 1 commit

  • refactor(tailscale): keep package internals privateec9cd41
Ggithub-actionsBotSep 5, 2026
Synced from GitHub

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.5 KiB13.6 KiB+63 B (+0.5%)15.1 KiB✅
CodexThread snapshot wire7.0 KiB7.0 KiB+4 B (+0.1%)7.3 KiB✅
CodexLive turn WebSocket wire6.5 KiB6.6 KiB+59 B (+0.9%)7.8 KiB✅
CodexLive turn WebSocket decoded57.0 KiB57.1 KiB+88 B (+0.2%)66.4 KiB✅
CodexLive turn messages810+2 (+25.0%)21✅
ClaudeTotal thread wire13.5 KiB13.5 KiB+4 B (+0.0%)15.1 KiB✅
ClaudeThread snapshot wire7.0 KiB7.0 KiB−4 B (−0.1%)7.3 KiB✅
ClaudeLive turn WebSocket wire6.5 KiB6.5 KiB+8 B (+0.1%)7.8 KiB✅
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB✅
ClaudeLive turn messages880 (0.0%)21✅

Baseline: ba873b8 · PR result: ec9cd41 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

MmacroscopeappBotSep 5, 2026
Synced from GitHub

Approvability

Verdict: Approved at ec9cd41

Macroscope's review found this PR approvable — This is a narrowly scoped cleanup that hides unused Tailscale internals in a private package. Timeout values, schemas, command behavior, and existing callers remain unchanged, with no product-default or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.