feat(power): add site patterns, clean links, Markdown links, and group names#36

Problem

Plan 07 (power features) needs four small pieces of pure logic before its hooks can land, about day 16, after Core's action table:

• a shared site matcher, for link routing and site styles;
• a clean-link strip table, for Shift+Cmd+C;
• Copy as Markdown;
• tab-group naming.

They can be written and unit-tested now, with no browser hooks.

Change

Three rac patches in patches/rac/power/. Nothing calls this code yet.

• site-pattern.patch: rac::SitePattern (chrome/browser/rac/site_pattern/).
  • "Domain is": the host plus its subdomains, matched on label boundaries and case-insensitively. It refuses ICANN suffixes like com or co.uk through the registrable-domain helper, and allows private suffixes like github.io on purpose. It accepts *.host.
  • "URL contains": a case-insensitive substring of the canonical address.
  • Only http(s) pages match. ForSiteOf() gives the "Always open / Boost this site" pattern.
  • Values loaded from prefs are re-checked, so a hand-edited pref can't bypass the input checks.
• clean-links.patch:
  • rac::CleanLink(), based on Stedding's L2 table (BSD-3). It drops utm_*, ad-click ids, and share ids on known hosts. Every other parameter keeps its order and its byte-exact encoding, the fragment is untouched, and only http(s) addresses change.
  • rac::MarkdownLink() writes [title](clean url), escaped so it always renders as exactly one link.
  • The one upstream hunk is the dep line in chrome/browser/BUILD.gn that loads these targets.
• group-names.patch: rac::AutoGroupName(), Ardia's deterministic rule ported to C++ (Apache-2.0). The host's name comes from the public suffix list, and IDN hosts are shown in Unicode.

Borrowed code sits in chrome/browser/rac/power/third_party/{stedding,ardia}/ with README.chromium, LICENSE, and NOTICE, so about:credits lists it. tools/licenses/licenses.py parses both.

Net-diff hunks (D17): +1 (chrome/browser/BUILD.gn). Everything else is new rac-owned files.

Verification

• rac_power_unittests: 106 of 106 pass in a real Chromium 156 build (base-156-2, through build-queue.sh). They include the plan's acceptance cases:
  • https://x.com/a?utm_source=y&id=3#c copies as https://x.com/a?id=3#c;
  • three GitHub PR tabs give the group name "GitHub";
  • Ardia's four test cases, ported one for one;
  • a must-not-change case for every strip-table name, including working look-alikes such as Google Calendar eid and Yandex clid.
• he validate series is clean.
• Reviews:
  • a hill-climb council (Sonnet and Devin SWE-2 Max), with no blocking findings; six confirmed findings were fixed;
  • a fresh Opus final review, whose two should-fix items and three nits were fixed;
  • /code-review, whose seven confirmed items were fixed. Two cost items were left for the hooks: PageOf splitting a title again, and Matches() copying the URL.
• Nothing is user-visible, so there are no screenshots.

This PR is stacked on sync/helium-0.20.1.1. Retarget it to main once the sync merges (D62); it doesn't merge before then.

Model and tool: Claude Opus 5.5 (lead, judge, final review) in Claude Code, with Claude Sonnet 5.5 and Devin SWE-2 for tests and fixes.

🤖 Generated with Claude Code

Devin Review

Summary by cubic

Adds the pure logic and unit tests for four upcoming power features — site pattern matching, clean-link copying, Copy as Markdown, and tab-group naming. Nothing calls this code yet, so there's no user-visible change.

New Features

• rac::SitePattern matches "domain is" (host plus subdomains, rejecting ICANN suffixes like com, accepting *.host) or "URL contains" for http(s) pages only, and refuses typed sites with a broken scheme.
• rac::CleanLink drops tracking, ad-click, and share parameters on known hosts, including _ga, _gl, and mibextid on facebook.com and si on youtube-nocookie.com, keeping every other parameter's order and byte-exact encoding, and leaving fragments untouched.
• rac::MarkdownLink writes [title](clean url), percent-encoding < and > in destinations and escaping entity-like & and spaces kept by data: and javascript: addresses, so it renders as exactly one link.
• rac::AutoGroupName names a tab group from the host's registrable domain, showing IDN hosts in Unicode and keeping non-Latin page titles.
• Borrowed code from Stedding (BSD-3) and Ardia (Apache-2.0) sits in third_party/ with license files, so about:credits lists it.
• All 106 rac_power_unittests pass, including must-not-change cases for every strip-table name and the plan's acceptance cases.

^{Written for commit e970b2ceeb616de7c5506c0716398c3dff273629. Summary will update on new commits.}

View guided diff Turn on auto-fix