You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.
fix(managed-cli): map undecodable staged files to unverified#369
Summary
- A staged checksum or
VERSIONfile that is not valid UTF-8 raisedUnicodeDecodeError, whichfailure_status()degraded to the genericerrorinstead of theunverifiedtampering signal used for other refused content. - Decode failures in
install()now fold into the existingchecksum_fileandversion_filecodes, so binary staged files reportunverifiedlike mismatched ones. - Observable result: same install refusal, but the widget renders the tampering signal instead of a generic error.
Related issue
None
Documentation impact
docs/development.mdalready documents that refused downloads reportunverified; this change aligns the behavior with the doc, so no guide update is needed.- TODO.md is unaffected: no parity entry covers helper failure mapping.
- Changelog: updated Unreleased.
Verification
- New test
test_binary_staged_files_report_unverifiedintests/test_managed_cli.py(binary.sha256and binaryVERSIONfixtures): observed red before the fix (UnicodeDecodeErrormessage mismatch), green after. make check: full suite green locally on the stacked tip0e63e84. Skipped locally (tools absent, CI covers them):actionlint,pyflakes. QML hardening noted partial import/type checks locally ("CI requires full checks").- CI: green on
0e63e84—check,smoke,smoke-runtime,pr-titleall pass (run).
Visual changes
None
Review notes
- Stacked on #368 (base
fix/todo-gate-harden); retarget tomainonce #368 merges. This PR's own diff is only themanaged_clicommit. - Only
UnicodeDecodeErroris folded in; a missing staged file still reportserror, which fits a local staging problem rather than refused content.
Checks
- SuccessfulCodeRabbitGitHub
Review skipped: manual review required for this OSS repository
- SkippedreleaseGitHub
- SuccessfulsmokeGitHub
- SuccessfulCodeQLGitHub
- Successfulsmoke-runtimeGitHub
- Successfulpr-titleGitHub
- SuccessfulscopeGitHub
- SuccessfulcheckGitHub
- SuccessfulAnalyze (actions)GitHub
- SuccessfulAnalyze (python)GitHub
Synced from GitHub
Synced from GitHub
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
Synced from GitHub
Important
- 🔍 Trigger review
This repository does not receive automatic reviews because it has fewer than 10 stars.
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 04a26c91-bfe0-4a55-80ea-f03fccf225d1
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Added 1 commit
- fix(managed-cli): map undecodable staged files to unverifieda5f0987