gpui: Fix blending of colors in `HighlightStyle::highlight` (#37666)

Whilst looking into adding support for RainbowBrackes, we stumbled upon
this: Whereas for all properties during this blending, we take the value
of `other` if it is set, for the color we actually take `self.color`
instead of `other.color` if `self.color` is at full opacity.
`Hsla::blend` returns the latter color if it is at full opacity, which
seems wrong for this case. Hence, this PR swaps these.

Will not merge before the next release, to ensure that we don't break
something somewhere unexpected.

Release Notes:

- N/A
6441099a67Finn Evers committed on 9/10/2025, 4:56:49 PM· committed by GitHubparent611b966
6 files changedLine totals unavailable