The latest updates on your projects. Learn more about Vercel for GitHub.
| Project | Deployment | Actions | Updated |
|---|---|---|---|
| External image lodesong | Ready Ready | Preview | Nov 19, 2026 4:47pm UTC |
Refs #621 (the desktop nits; the phone ones are deferred to v2). from the ui audit:
home and stats, before and after (dark, light):
e2e: the releases matcher and a border check, the sparse chart sentence and the tab height. not done: moving made for you and jump back in above the purchase actions (phone only, v2). the mock library has no releases, so the release card border and the 'requested' text are covered by the e2e only, not by a screenshot.
The latest updates on your projects. Learn more about Vercel for GitHub.
| Project | Deployment | Actions | Updated |
|---|---|---|---|
| External image lodesong | Ready Ready | Preview | Nov 19, 2026 4:47pm UTC |
Warning
You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.
Next included review available in 37 minutes.
Limit details: You’ve used the included review currently available.
Review configuration:
3246a36f-0b7a-4896-ab1e-29526afb9b57Reviewing files that changed from the base of the PR and between e7df5c1b03272ada24d4bac9469c91cd3ca2bf74 and 96c67892a1f7f68d7e8a9a16bff62e2b50406dba.
docs/home-nits-after-dark.png is excluded by !**/*.pngdocs/home-nits-after-light.png is excluded by !**/*.pngdocs/home-nits-before-dark.png is excluded by !**/*.pngdocs/home-nits-before-light.png is excluded by !**/*.pngdocs/stats-nits-after-dark.png is excluded by !**/*.pngdocs/stats-nits-after-light.png is excluded by !**/*.pngdocs/stats-nits-before-dark.png is excluded by !**/*.pngdocs/stats-nits-before-light.png is excluded by !**/*.pngapps/api/src/stats.test.tsapps/api/src/stats.tsapps/player/src/components/day-chart.tsxapps/player/src/components/mix-row.tsxapps/player/src/components/release-card.tsxapps/player/src/pages/stats.tsxe2e/releases.e2e.tse2e/stats.e2e.tsThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This comment shows the latest Codex review activity on this pull request.
| Review | Status | Commit | Review trigger |
|---|---|---|---|
| 📝 Code Review | ✅ Completed 2026-11-19T16:37:07.149406Z | bd5cb83 | PR opened |
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
The latest updates on your projects. Learn more about lodesong previews.
| Project | Deployment | Actions | Updated (UTC) |
|---|---|---|---|
| lodesong-pr-652 | ✅ Ready (Build logs · Deploy logs) | Visit Preview | Nov 19, 2026, 4:48pm |
| api | ✅ Ready | API reference | Nov 19, 2026, 4:48pm |
Sign in with demo / demo. The preview is isolated: its own empty data, a generated demo library, no production data.
In the macOS app: sign out, tap the background 4 times, enter pr-652.
Here are some automated review suggestions for this pull request.
Reviewed commit: bd5cb83bb9
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| … | … | @@ -38,6 +38,9 @@ test("stats show what you played, forgotten favourites make a playlist, and the | |
| 38 | 38 | await chart.focus(); | |
| 39 | 39 | await page.keyboard.press("End"); | |
| 40 | 40 | await expect(chart).toHaveAttribute("aria-valuetext", /: \d[\d,]* minutes?$/); | |
| 41 | + | await expect(page.getByText(/^only 1 day of 30 so far/)).toBeVisible(); | |
P2 Badge Avoid hard-coding the sparse day count
When this test starts within 39 minutes after local midnight, its 40 records posted at now - i * 60_000 span two local dates, so the chart correctly reports 2 listened days and this exact assertion fails. Anchor the test records to one date or assert the sparse message without fixing the count.
Useful? React with 👍 / 👎.
ran it all. build, bun run size (156.9 of 161 KB), bun run colors, biome ci clean. home, stats, releases, cls pass one at a time. the new asserts in e2e/releases.e2e.ts and e2e/stats.e2e.ts fail on a clean origin/main build and pass here. a11y had 2 flaky fails in the full run (landmarks, focus return) that pass alone, unrelated.
fine
border is 1px on the cover in light (rgb(197,197,197)) and dark (rgb(38,38,38)), still 160x160 border-box, so RELEASE_CARD_HEIGHT and the virtualization math are untouched. dark edge is faint but theregroup-data-[orientation=horizontal]/tabs:h-9 is only on the stats list. the only other TabsList is settings, which has its own h-auto override, and the coarse pointer h-auto in packages/ui stays. tab now ~35pxDayChart is only used on stats. sparse is correct at the edges (7 day range never sparse, 3 listening days not sparse), days are bucketed server side by the user's tz so the count matches the bars. sentence reads 'only 1 day of 30 so far', singular/plural ok through plural. cls spec doesnt visit /stats, but the height only flips when data arrives, same as the old tall chartshould fix
src/components/day-chart.tsx counts days with minutes > 0 but minutes are Math.rounded server side, so a day with a 20s play is 0. a range with only a short play shows 'only 0 days of 30' next to a streak of 1 day. count the days by plays instead, or floor each listening day at 1 minutee2e/stats.e2e.ts: the 40 plays are now - i * 60_000, so a run in the first 40 min after midnight splits across two days and only 1 day flakesmix-row.tsx: title is hover only, so touch and keyboard still cant read the cut text (screen readers get the full text anyway since line-clamp is visual). also the pr body says tooltip 'when it is cut off' but it is always set. fine for a desktop nit, a tap to expand would close the issue properlyunverified visually
bg-background so should be fine)verdict: approve