track list: time column flush with the right edge#650

open2
main
611
opened11h agobyMMalek Gara-Hellal
View on GitHubTwo-way sync enabledPR last imported 7h ago

Refs #611 (desktop part; phone is deferred to v2). the track list reserved a column for the row actions after the time column, and the actions only show on hover, so the empty space showed as a dead strip at the right edge and the time ended well short of the header rule. the actions column now sits before the time column, so the time is last and flush with the right edge, and the hover actions appear to its left. it is the same swap in four places in library.tsx (the row cells, the colgroup, the header cells and the missing-tracks row from #596). column widths, the artist column, disc rows and the virtualization row heights are unchanged, and nothing shifts on hover.

album page and songs page, before and after (dark, light):

the e2e measures the time text itself (a range over its text node) against the header text and the table edge, hovered or not, checks the like and more buttons sit left of the time, and the grid width does not change on hover; it fails on the old code (the actions column sits 80px right of the time text). not done: the actions column still reserves 80px between the like button and the time when not hovered (that space is empty but not at the edge; giving it back to the title needs an overlay design), the phone layout (columns ending at about 75% of the width), and the editing-playlist variant, the rating column and the artist-column variant were not checked visually (only reordered).

Checks

1 failing · 12 successful · 9 skipped
Some checks failed

Failing1

9bf3049
Synced from GitHub

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

External image Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c83c6c10-7fc8-4332-8d33-16433944a147
External image Commits

Reviewing files that changed from the base of the PR and between e7df5c1b03272ada24d4bac9469c91cd3ca2bf74 and 9bf30492b434240c87263c544bd706fc7b443e1f.

External image Files ignored due to path filters: 8

  • docs/tracklist-time-after-album-dark.png is excluded by !**/*.png
  • docs/tracklist-time-after-album-light.png is excluded by !**/*.png
  • docs/tracklist-time-after-songs-dark.png is excluded by !**/*.png
  • docs/tracklist-time-after-songs-light.png is excluded by !**/*.png
  • docs/tracklist-time-before-album-dark.png is excluded by !**/*.png
  • docs/tracklist-time-before-album-light.png is excluded by !**/*.png
  • docs/tracklist-time-before-songs-dark.png is excluded by !**/*.png
  • docs/tracklist-time-before-songs-light.png is excluded by !**/*.png
External image Files selected for processing: 2

  • apps/player/src/components/library.tsx
  • e2e/lists.e2e.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Synced from GitHub
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

ReviewStatusCommitReview trigger
📝 Code Review✅ Completed 2026-11-19T16:27:26.538791Zdbbf69bPR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

swap itself is clean, checked every variant and no blockers.

checked in a worktree at the pr head, desktop 1440 and phone 390 (screenshots look right, time flush with the header rule and the numbers line up under time)

  • header order matches cell order in all variants (#, title, album, liked, actions, time). no aria-colindex anywhere so nothing to fix there
  • tab order in a row is the same as before (play, like, play next, queue, more, hide, remove). time has no focusable so moving it changes nothing. on phone only like and more
  • playlist editing (w-32 / pointer-coarse:w-28), disc rows (colSpan={columns}), missing rows (colspan 2+album+ratings then empty actions then time) all add up to the column count. no rating column on the pages i hit, but the rating cell sits before like so the swap doesnt touch it
  • row heights unchanged (34 / 44 desktop, 45 phone), virtualized missing rows spec passes, no horizontal scroll at 390
  • e2e that use td nth only use nth(1) (title), nothing relies on the old order. no docs reference the old order
  • bun scripts/build.ts ok, bun run size 156.8 KB of 161, bun run colors, biome ci clean
  • specs pass: lists, context-menus, missing-tracks, touch-targets (chromium + phone), playlists, a11y (74, workers=1), cls

should-fix: the gap check in e2e/lists.e2e.ts is vacuous. i ran the spec on a copy of origin/main with only the spec and it does fail, but only on the last line (toHaveText(/^\s*\d+:\d\d\s*$/)). all the toBeLessThan(3) gap asserts pass on main too because the last td (actions) already reaches the table edge in a fixed layout. so the "flush" part proves nothing, measure the right edge of the text (a Range on the time cell) vs the header text instead

nit: the issue also asks for the hidden actions space to go to the title. its still reserved at w-20 on desktop (opacity only, so no layout shift) and a strip sits between title/album and time. fine as a tradeoff, just say it in the pr body so #611 isnt closed on it

verdict: approve

Added 2 commits

  • fix(player): flush track time column241d4a1
  • test(player): measure time text edge9bf3049