Sign up
View stargazersSign up

fix(admin): load complete products for search editing#244

draft1
v2
orch/2026-07-18T08-42-00-926Z-2efb3c4e/issue205-author
openedJul 19, 2026byAAviddaram
2 files changed
View on GitHubTwo-way sync enabledPR last imported 20d ago

Addresses #205

Summary

  • replace fabricated instant-search Product values with an authoritative detail query per result identity
  • render loading, not-found, retryable error, and complete Product card states
  • preserve the existing Product card, form, update contract, list projection, and create flow

Checks

  • bun run --cwd apps/admin check-types
  • bun run --cwd apps/admin build
  • bunx biome check apps/admin/src/components/product/product-card-by-id.tsx
  • fabricated-default grep and git diff --check

Proof status

Draft pending required isolated local authenticated browser proof. No local Google OAuth credentials or supported disposable-login boundary are available in this worker environment; per the issue safety gate, no authentication bypass or remote environment was used.

Note

Load complete product data for each search result card in admin products view

  • Replaces the stubbed ProductCard rendering in products.index.tsx with a new ProductCardById component that accepts only a product ID.
  • ProductCardById fetches the full product, brands, and categories via tRPC (getProductById, getAllBrands, getAllCategories) and renders a skeleton while loading.
  • Handles not-found and generic error states per card, with a retry button that refetches all three queries.
  • Behavioral Change: each search result card now issues 3 tRPC requests independently, replacing a single pass with no data fetching.

Macroscope summarized 85f59a7.

Checks

4 successful · 1 skipped
All checks passed
59bda2f

Added 1 commit

  • fix(admin): load complete products for search editing59bda2f
CcoderabbitaiBotJul 19, 2026
Synced from GitHub

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

yaml
1reviews:
2 auto_review:
3 drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.