Sign up
View stargazersSign up

chore(lint): explicit oxlint rules, vendored anti-slop at error, warnings fail vp check#162

merged1
lint/1-effect-fixes
lint/2-oxlint-rules
openedOct 13, 2026byAAviddaram
43 files changed
View on GitHubTwo-way sync enabledPR last imported 20d ago

Ultracite's preset hid which rules ran, and warnings never failed the gate. 19 strict-effect-provide warnings sat in the output unread.

  • lint.config.ts lists the core rules we kept, and dmmulroy/anti-slop is vendored under tools/oxlint/anti-slop with every rule at error. require-readable-spacing is left out.
  • denyWarnings: true makes vp check exit non-zero on any warning, including with --quiet.
  • The effecttsgo error rules now also cover packages/db/** and apps/web/src/**.
  • Entry points that provide layers get file-scoped strict-effect-provide overrides: apps/api/src/index.ts, apps/api/scripts/*.ts, auth.ts, email.ts and r2.ts (they provide RuntimeContext.phantom, which is Layer.empty), and deliveries.test.ts.

The code changes are in the PR below. This one only passes on top of it.

vp check 0 errors 0 warnings, vp run test passed.

Checks

4 successful · 2 skipped
All checks passed
e3223b4

Added 1 commit

  • Replace Ultracite with explicit oxlint rules and vendored anti-slop; warnings fail vp checke3223b4
CcoderabbitaiBotOct 13, 2026
Synced from GitHub

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f7709315-affd-4b89-8315-7762024a988f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.