Proposal: interactive map elements (Lotus/Summit doors) à la valoplant#109

Walkthrough

The proposal documents clickable Lotus and Summit map elements. It describes static definitions, persisted undoable state, interactive rendering, future ability-state support, and phased implementation considerations.

Changes

Interactive map elements

Estimated code review effort: 1 (Trivial) | ~5 minutes

What T-Rex did

• T-Rex produced a proof for a posted P1 finding and attached a log showing export-stack validation that ScreenshotView does not use InteractiveMap.
• T-Rex added a coordinate-frame validation script and captured placement and conversion checks for the inset map frame.
• T-Rex reviewed docs/proposals/interactive-map-elements.md and documented exact results including screenshot_uses_InteractiveMap=False, screenshot_contains_proposed_layer=False, and video_constructs_ScreenshotView=True.
• T-Rex ran a precise map-coordinate validation showing pre-run misalignment and post-run exact mapping to X=960.000, including notes that the Flutter test command was not found, and that the validation script was used to verify the result.
• T-Rex examined how StrategyProvider imports and validates version guards, and confirmed decoding behavior for known page properties without requiring a version bump.

View all artifacts

_{T-Rex Ran code and verified through T-Rex}

1. General comment

   P1 Interactive-map-only door layer is omitted from screenshot and video exports

   • Bug
     • The proposal lists lib/interactive_map.dart as the layer insertion point, but PNG captures use the separate ScreenshotView stack and video frames are built from that same ScreenshotView. Neither path composes InteractiveMap, so exported doors/interactable state would be absent.
   • Cause
     • ScreenshotView duplicates the map/overlay/placed-widget/drawing renderer instead of reusing InteractiveMap; VideoExporter._pageView returns ScreenshotView.
   • Fix
     • Add an export-safe interactable layer to ScreenshotView using page-persisted interactable state, and define how it renders during video transition frames; revise lines 179-180 to remove the no-extra-work claim.

   _{T-Rex Ran code and verified through T-Rex}

2. General comment

   P1 Inset map frame cannot directly consume full-world interactable coordinates

   • Bug
     • docs/proposals/interactive-map-elements.md:155-157 claims that full-world attack-frame coordinates can be positioned in the inset mapLeft/mapWidth layer and flipped there. The executed repro shows that direct placement adds mapLeft on attack and reflects around the inset map width on defense, producing a 290.400-pixel error at 1080px height in both frames.
   • Cause
     • CoordinateSystem.coordinateToScreen maps normalized coordinates into the full 16:9 world (1777.8 × 1000), while the map SVG frame is only 1.24×height and starts at mapLeft. Transform.flip reflects inside the bounds of the widget it wraps; the drawing layer is full-world (Positioned.fill), but the proposed interactable layer is inset (left: mapLeft, width: mapWidth).
   • Fix
     • Either place MapInteractableLayer in a full-world Positioned.fill layer and apply the drawing-layer Transform.flip, or retain the inset map layer but convert each full-world screen coordinate to map-local coordinates by subtracting mapLeft before positioning and document that conversion explicitly.

   _{T-Rex Ran code and verified through T-Rex}

3. General comment

   P1 Global version bump would reject otherwise forward-compatible .ica exports on older clients

   • Bug
     • Exact comment lines: docs/proposals/interactive-map-elements.md:129-132. Bumping Settings.versionNumber for the new optional StrategyPage.interactableStates field causes any archive exported by the newer build to carry the higher top-level version. An older client rejects that archive before decoding pages, even though its page JSON decoder would ignore the unknown optional field.
   • Cause
     • loadFromFilePath gates all imports on the archive-level version number (importedVersion > Settings.versionNumber) before StrategyPage.listFromJson; the proposed field is additive/defaulted and StrategyPage.fromJson does not validate or reject unknown JSON keys.
   • Fix
     • Do not prescribe a Settings.versionNumber/archive compatibility bump solely because this optional defaulted page field is added. Regenerate/update the Hive adapter as required for local persistence, but reserve the global import gate bump for a change that older clients cannot safely decode or migrate. If a release-wide version bump is mandatory for another reason, document the intentional loss of backward .ica import compatibility.

   _{T-Rex Ran code and verified through T-Rex}