# fix\(review\): address font picker and typography review feedback · stienswout/t3code

[View on GitCafe](https://git.cafe/stienswout/t3code/commit/deb9252868d01c41e6d2d85506941e51c0fc67f4)

Repository: [stienswout/t3code](https://git.cafe/stienswout/t3code)

Visibility: public

Requested revision: deb9252868d01c41e6d2d85506941e51c0fc67f4

Requested commit: deb9252868d01c41e6d2d85506941e51c0fc67f4

Commit: deb9252868d01c41e6d2d85506941e51c0fc67f4

Tree: bb34ff5f39e1234d261898153506a0b9cf87fc32

Author: Julius Marminge

Committer: Julius Marminge

## Message

```
fix(review): address font picker and typography review feedback

- Keyboard selection commits: the combobox commits through
  onValueChange instead of per-item clicks, so Enter on a highlighted
  font works, and keyboard highlights scroll the virtualized list into
  view the way the branch selector does.
- The picker popup opens after mount instead of mounting open, so the
  exit transition has a style baseline and close cannot wedge.
- Preview sessions no longer grant local-fonts: untrusted preview
  content must not read the user's installed-font fingerprint. The
  app's own picker runs in the main window session.
- The simple-mode Monospace row keeps the code-font search anchor
  under its custom title.
- A settings-search jump to font smoothing on non-macOS no longer pins
  Advanced on: the target set is platform-gated and each jump expands
  at most once.
- The Advanced preference persists through the shared useLocalStorage
  hook instead of hand-rolled helpers.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

```

## Parents

- [8e13a97baa6e9c7e33e82fe5c65a83111b837d2a](https://git.cafe/stienswout/t3code/commit/8e13a97baa6e9c7e33e82fe5c65a83111b837d2a?format=markdown)

[Source at this commit](https://git.cafe/stienswout/t3code/tree/deb9252868d01c41e6d2d85506941e51c0fc67f4?format=markdown)