Preview review button keys on the PR author, but Machines check the pusher#4079

opened1d agobyNNick

GitHub writeback is off. Issues and comments you change here stay in GitCafe. Sync settings

Follow-up to #4076 / #4078. The dashboard offers a preview review based on whether the preview rule trusts the PR's author. A Machine checks the account that pushed the head commit. A trusted author's PR whose head was pushed by an account the rule doesn't trust gets a Machine refusal and no review button.

Fix: carry the pusher (from the push or check-suite event) into the Store's PR plan listing and compute needs_review from it.

Score: F 2 × S 5 = 10 (broken flow with a workaround: re-push from a trusted account).