verify-cluster: the documented fault build fails when ployzd is cached#4048

opened2d agobyNNick
GitHub writeback is off. Issues and comments you change here stay in GitCafe. Sync settings

PLOYZ_VERIFY_CARGO_ARGS="--features ployz/verify-faults,ployzd/verify-faults", the form the verify-server skill documents, works on the first verify-cluster up. On a later up where the daemon hits the local artifact cache, the script builds only the CLI and fails:

1ployzd: hit local 56a0ed4f (…)
2verify-cluster: nice -n 10 cargo build --locked -p ployz --features ployz/verify-faults,ployzd/verify-faults
3error: the package 'ployz' does not contain this feature: ployzd/verify-faults

Workaround: add -p ployzd to the args (-p ployzd --features ployz/verify-faults,ployzd/verify-faults). That changes the cache key and rebuilds both.

Fix: when one binary is cached, build the other with only the features that apply to its package, or always pass both -p flags.

Scores: F 4 (every second fault-build boot from the same tree), S 3 (the boot fails fast; there is a workaround). Found while verifying #4046.