fix(web,mobile): save pull request description checkbox changes#30704

Approvability

Verdict: Approved at d9231e2

Macroscope's review found this PR approvable — PR description checkbox clicks now save on web and mobile, with optimistic feedback and save-error handling. Changes use existing edit permissions and serialized update commands, keeping their impact limited to user-requested description edits.

^{You can add or adjust custom eligibility rules. Learn more.}

Explain Change →

No actionable comments were generated in the recent review.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

External image Recent review info

External image Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 8b44f42
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7d6a789a-3218-42e8-9575-8f693fbd18d5

External image Commits

Reviewing files that changed from the base of the PR and between 91472ab96f8773b5059f5e02e5fa6c119eae29b9 and d9231e204583245f09194d2d9da8dd92b24077e9.

External image Files selected for processing: 4

• apps/mobile/src/features/pull-requests/usePullRequestDescription.ts
• docs/user/source-control.md
• packages/client-runtime/src/state/pullRequests.test.ts
• packages/client-runtime/src/state/pullRequests.ts

External image Files skipped from review as they are similar to previous changes: 1

• docs/user/source-control.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Verified in a real dev environment

verified unchanged head 91472ab96f8773b5059f5e02e5fa6c119eae29b9 on linux using repo playwright and /usr/bin/google-chrome against real vp run dev servers, one at a time.

• reproduced on github/main (8b44f42b14c8e273156474a924ccf29680dd7857): description editing worked, but all three checklist boxes were disabled.
• on the pr head, inline ticks saved through the app's git.cafe provider and appeared in fresh github api reads. checked the task after code and another after the existing attachments; other markers and the fenced code sample stayed unchanged.
• rapid check/uncheck persisted the final state. edit description opened from the updated body, cancel preserved it, and reload retained the ticks. a subsequent github-side uncheck appeared in the mounted renderer after the pr's refresh action.
• created the project and thread through the app. real codex gpt-6.1-sol turns completed on both main and the pr head.
• restored the original description exactly after verification. no code changes or pushes were needed.

vp run check:changed 0847a448fdca5a688720050ca706cbbd37e6347e passed through blacksmith: format, lint, knip, typechecking 39 packages, 10 test files / 103 tests, and the react compiler check. the worker initially lacked history and chromium; both prerequisites were installed before the passing run.

before, on main:

main: editable description with disabled checklist boxes

after, on the pr head, after saving and reloading:

pr: task after code saved and persisted while neighboring tasks remain unchecked

rapid toggles, editor state, and the persisted result after reload; loading frames removed:

real app checkbox saves, editor state, and reload persistence

runtime transcript

Not verified

native ios/android, electron, release packages, relay/tunnel, and other source control providers were not exercised on this linux vm. writes used git.cafe with github mirror readback, not the app's direct github adapter. save failures and denied-edit sessions were not induced against the live service. concurrent description edits still use whole-body replacement, as documented in the pr.

[GPT-6.1 Sol][Codex] on behalf of shivam.

The whole-description concurrency limitation is confirmed and documented in the PR's Limits section. Checkbox saves use the existing description update operation, which has no expected-version or merge semantics. Preserving concurrent host edits needs a provider-contract change across its implementations, including the manual editor. I am keeping that work outside this checkbox fix; a pre-save refresh or an observedAt argument alone would not prevent the race.

[GPT-6.1 Sol][Codex] on behalf of shivam.

For the older-host readback finding:

Addressed in d9231e204583245f09194d2d9da8dd92b24077e9 with local host-read versions. Mobile now retains the draft and Edit barrier until an actual detail response has settled, including when the server omits observedAt. Offline cache reads cannot acknowledge the save, and server freshness timestamps are unchanged.

I used response versions rather than body equality because a later host edit can legitimately return a different body, and must end the draft. The focused regression covers a held response, structurally shared equal responses, offline cache, reconnect, and preservation of server timestamps. check:changed passes with 160 tests. The narrow iOS success/failure readback pass is queued; I will add its evidence before resolving this thread.

[GPT-6.1 Sol][Codex] on behalf of shivam.

Verified the older-host readback correction at d9231e204583245f09194d2d9da8dd92b24077e9 on an iPhone 18 Pro simulator running iOS 27.0. Native dev client 2.2.0 build 1, fingerprint 887f84d7e8ee2e1063658bf884c9d17f60d6cbb3; the installed bundle digest matched the build artifact.

The fixture omitted observedAt and held detail responses separately from write acknowledgements. On success, write 55 completed with only the first task checked, while detail 58 remained held and Edit description stayed disabled with Saving. Releasing the detail enabled Edit with the checked text, including after reopening.

https://github.com/user-attachments/assets/fe279f1c-b391-4e0d-a5e6-03fefb10c48c

On failure, write 84 returned the existing error and the checkbox rolled back. With no writes pending and detail 88 still held, Edit stayed disabled after dismissing the alert. Releasing the detail enabled Edit with both tasks unchecked.

Failed save keeps the barrier until readback

I inspected the recovered recordings, screenshots and fixture events. The job timed out during reporting after both cases had completed; its timeout is not counted as a passing command. vp run check:changed passed separately with 160 tests, and required CI passes at this head. The focused regression also covers offline cache, identical host responses and reconnects.

This verifies the readback finding. These writes were intercepted. The optional current-host smoke, production permission denial, relay/tunnel, physical iPhone and release builds were not exercised in this run.

[GPT-6.1 Sol][Codex] on behalf of shivam.

Reattaching the actual recording and persistence transcript from Maria's independent verification. These are her original public artifacts, downloaded without changing their content. Her tested head was 91472ab96f8773b5059f5e02e5fa6c119eae29b9; baseline was 8b44f42b14c8e273156474a924ccf29680dd7857. This used the app's real GitCafe provider with fresh GitHub mirror readback, rather than intercepted writes. She restored the original description afterwards.

Maria's actual checkbox recording

Her original runtime transcript follows verbatim. The separate packaged desktop pass at final head d9231e204583245f09194d2d9da8dd92b24077e9 is still being prepared.

[GPT-6.1 Sol][Codex] on behalf of shivam.

Completed the remaining desktop evidence requests at d9231e204583245f09194d2d9da8dd92b24077e9 on shiv, macOS 27.0.1 arm64.

1. In native desktop PR Summary, the same background click at window position 279,390 leaves main 8b44f42b14c8e273156474a924ccf29680dd7857 unchecked with zero writes. The packaged candidate checks only the first task, saves one update and opens Edit description with [x] first and [ ] second.
2. Maria's actual recording and real GitCafe persistence readback are attached separately, with their original tested commit. This desktop run uses intercepted writes and does not substitute for her real-provider verification.
3. Native View > Reload reloads the packaged renderer. A fresh detail response, the Summary and the reopened editor retain the first check. The background Cmd+R attempt did nothing, so the recording uses the native menu instead. Read-only inspection confirmed a new renderer time origin and navigation type reload.

Main: attempted click and unchanged saved description

Packaged candidate: click, saved editor text, reload and reopened editor

The recordings begin with the native About dialog. Full commit bars and green click outlines are editorial annotations; the outlines mark the logged background input, rather than a captured cursor. About and interaction clips are joined in order. Baseline uses the Electron dev wrapper and baseline Vite assets; its About commit override matches the clean baseline checkout. Candidate uses the unsigned packaged app, its bundled renderer and the builder's unmodified embedded commit prefix. No Vite or commit override was used for candidate. All interaction used background native accessibility input; CDP was read-only.

Build and runtime provenance:

Sanitized fixture readbacks, captured after the actual clicks and reload:

I inspected the native recording frames, editor screenshots, action logs, bundled asset hashes and readbacks. An independent evidence audit found no remaining gap in these two cases. Original desktop profiles were restored with the same inodes; our apps, processes, detached worktrees and temporary build were removed.

Not exercised by this run: signed installers, direct GitHub adapter writes, relay/tunnel or production permission denial. Final iOS readback verification and the earlier Android/native mapping evidence remain linked in the PR body. Required CI at this head passes; check:changed previously passed 160 tests at this unchanged head.

[GPT-6.1 Sol][Codex] on behalf of shivam.

Rechecked the base move through 95e53a54dbd312fea7e8a2ef94514dc5f1c8ee3d and then current main a07be97ab0753b2b5b0caecebba69d7f872594fa, with PR head unchanged at d9231e204583245f09194d2d9da8dd92b24077e9.

Only packages/shared/package.json overlaps this PR's changed files. Main switches typechecking to effect-tsgo tsrs --noEmit and removes the unrelated jose dependency; the PR independently adds the ./markdownTaskList export. The merge preserves all three. Compared with the automatic merge against the previous base, all other PR files are byte-identical. An independent source review found no behavior affected by this base move.

I validated a clean, conflict-free local merge of these exact head/base commits. This temporary commit was not pushed:

The new check covers compatibility with current main's compiler and dependency setup. The desktop baseline and packaged reload recordings, real-provider readback and final iOS readback recordings retain their stated source commits; they are not recordings of this temporary merge. No checkbox runtime changes require new recordings for this base move. Existing limitations in the PR body still apply.

The live PR remains open, nondraft and mergeable, with both review threads resolved, Macroscope approval on this head, successful required CI and no auto-merge enabled. The temporary checkout is being removed after validation.