Synced from GitHub
test(scripts): expect the unmatched-pattern flag in the Astro check:changed test#29839
Main CI fails scripts/check-changed.test.ts > lints an Astro component and runs knip when only it changed since #29573 and #29596 landed together.
#29596 made check:changed pass --no-error-on-unmatched-pattern to every lint call. #29573, written before that, added a test that expects the lint args to be exactly ["lint", page]. The test now expects the flag too; the script is unchanged.
Verification: vp test run scripts/check-changed.test.ts scripts/check-changed-command.test.ts passes (21 tests), plus vp fmt --check and vp lint on the file, on a Blacksmith testbox.
Done with Claude Code (claude-opus-5-5).
Reviewed with sol-loop: 1 rounds with gpt-6.1-sol at high. Verdicts: approved, approved.
Checks
25 successful · 12 skipped
Added 1 commit
- test(scripts): expect the unmatched-pattern flag in the Astro check:changed testec0c718
Synced from GitHub
Approvability
Verdict: Approved at ec0c718
Macroscope's review found this PR approvable — Updates the Astro test to expect the unmatched-pattern flag already passed by the script. This test-only change leaves product defaults and diagnostic configuration unchanged.
Notes:
- No code objects were reviewed. Approvability was decided on eligibility alone.
You can add or adjust custom eligibility rules. Learn more.
Synced from GitHub
No actionable comments were generated in the recent review.
Walkthrough
The Astro launcher test now expects
--no-error-on-unmatched-patternbetweenlintand the changed page path.Changes: Astro lint test
Layer / File(s) Summary Update Astro lint expectation
scripts/check-changed.test.tsThe expected lint arguments for an Astro-only change now include --no-error-on-unmatched-patternbefore the page path.Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related PRs
- pingdotgg/t3code#29573: Added the Astro launcher test whose argument expectation this change updates.
- pingdotgg/t3code#29596: Added the lint flag that this test now expects.
Suggested labels:
size:S,vouch:unvouchedSuggested reviewers:
saphid,macroscopeapp
Merge Risk: External image Minimal · up to ec0c7
No actionable merge-blocking risk remains.
Pre-merge checks: Passed 4
Check name Status Explanation Title check Passed The title names the test file and the expected flag change, which matches the single-file test update described in the summary and objectives. It follows conventional commit form and is specific. The … Linked Issues check Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request. Description check Passed The description covers the problem, the focused test change, and verification results. It also identifies the agent used. The Scope and approval section is not explicit, but the description explains t… Full details: Title check
Explanation
The title names the test file and the expected flag change, which matches the single-file test update described in the summary and objectives. It follows conventional commit form and is specific. The test expects the
--no-error-on-unmatched-patternflag in the Astro check:changed lint arguments, which is the main change.
Full details: Description check
Explanation
The description covers the problem, the focused test change, and verification results. It also identifies the agent used. The Scope and approval section is not explicit, but the description explains that this is a small, focused test fix for an obvious CI failure.
Finishing Touches
Generate docstrings
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
External image ast-grep (0.51.1)
ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/php/security/avoid-using-ftp.yml
CodeRabbit Verify
- Run CodeRabbit Verify to test the changes in this pull request.
External image Recent review info
-
External image Run configuration
- Source mode: Auto
- Repository: pingdotgg/t3code
- Branch: t3/fix-check-changed-astro
- File: .coderabbit.config.ts
- Commit: ec0c718
- Layers: Repository TS config
- Review profile: CHILL
- Plan: Advanced
- Run ID:
f0a69076-0eaa-49b8-888b-2fe1b1e6e11f
External image Commits
Reviewing files that changed from the base of the PR and between 30b9c4a956a6c595fda5c8b2c439a6aaebc861b0 and ec0c7189e727dc9a4f83db30177c1b82b5f78718.
External image Files selected for processing: 1
scripts/check-changed.test.ts
Limit details: You’ve used all 10 included reviews currently available.
External image Recent review info
-
External image Run configuration
- Source mode: Auto
- Repository: pingdotgg/t3code
- Branch: t3/fix-check-changed-astro
- File: .coderabbit.config.ts
- Commit: ec0c718
- Layers: Repository TS config
- Review profile: CHILL
- Plan: Advanced
- Run ID:
f0a69076-0eaa-49b8-888b-2fe1b1e6e11f
External image Commits
Reviewing files that changed from the base of the PR and between 30b9c4a956a6c595fda5c8b2c439a6aaebc861b0 and ec0c7189e727dc9a4f83db30177c1b82b5f78718.
External image Files selected for processing: 1
scripts/check-changed.test.ts
Limit details: You’ve used all 10 included reviews currently available.