feat(mobile): share a thread with a guest from the mobile app#26744

🟡 Medium threads/ThreadGuestShareSheet.tsx:220

On Android, tapping the header back button while createGuestShare is pending dismisses the sheet and loses the returned URL, even though the server may still create the link and end the previous guest’s access. AndroidSheetHeader calls close without checking creating; guard its back action until creation finishes, as the iOS close action already does.

No longer relevant as of f39030803c896b0df2ea5a2e81218d5191593d2a

Fixed in 53be7e65093. Rather than guarding only the Android header button, the sheet now calls usePreventRemove(creating, () => {}). That blocks every way of closing it while the request is in flight: the Android header back, Android hardware back, the iOS swipe-down, and the iOS close button. It replaces the previous gestureEnabled: !creating guard, which only covered the swipe.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

External image Major · Functional Correctness · Heavy lift

Wait for the thread detail before treating the link as absent.

When the sheet opens from the thread list, useThreadGuestShare can return null before the thread detail loads. The sheet then says no link is active and enables Create link. If a link is active, creating another ends the guest’s access without showing the replacement warning. Distinguish “loading” from “no active link,” and disable creation until the active-link state is known. (raw.githubusercontent.com)

✅ Confirmed as addressed by @jakeleventhal

Fixed in f39030803c8. The sheet now reads whether the thread detail has loaded (environmentThreadDetails.threadAtom(ref) !== null) and keeps Create link disabled until it has. Once the detail arrives, the "a new link ends the current one" warning is in place before creation is possible. The detail starts loading when the sheet opens, so the button is disabled only briefly.

@jakeleventhal Verified the fix. Create link stays disabled until environmentThreadDetails.threadAtom(threadRef) is non-null. The active-link warning reads from the same thread detail, so it is available before creation is enabled.

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

✅ Review thread resolved.

_{You are interacting with an AI system.}

External image Major · Functional Correctness · Quick win

Block the Android back button while creating a link.

When creating is true, the Android header still receives onBack={close}. Its back button calls navigation.goBack() even though the request is in flight. If creation succeeds after dismissal, the one-time URL remains only in the unmounted sheet state and the user cannot copy it. Disable the back action while creating, and guard other Android dismissal paths as needed. (raw.githubusercontent.com)

✅ Addressed in commit 53be7e6

Already fixed in 53be7e65093. The sheet calls usePreventRemove(creating, () => {}), so while the request is in flight, navigation.goBack() from the Android header does nothing. The same guard blocks Android hardware back and the iOS swipe-down.

@jakeleventhal Verified in the current code. usePreventRemove(creating, () => {}) guards route removal while creation is in progress, including the Android header’s navigation.goBack() action. No separate header guard is needed. This addresses the finding.

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

✅ Review thread resolved.

_{You are interacting with an AI system.}

External image Minor · Functional Correctness · Quick win

Show a recovery option when the system share sheet fails.

If Share.share rejects, the handler only logs the error. The user receives no indication that sharing failed. Show an alert that suggests Copy as the alternative. (raw.githubusercontent.com) Based on learnings, failed async UI actions should give users actionable feedback and a recovery option.

Source: Learnings

✅ Addressed in commit f390308

Fixed in f39030803c8. If Share.share rejects, the sheet now shows "Could not share the link — Copy it instead." and still logs the error.

@jakeleventhal Thanks for the fix in f39030803c8. The reported change addresses the finding: users get Copy guidance when Share.share fails, and error logging remains.

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

✅ Review thread resolved.

_{You are interacting with an AI system.}

External image Minor · Functional Correctness · Quick win

Explain why creation is unavailable when no thread projection exists.

When detail loading has no cached projection, or the thread is deleted, threadAtom(threadRef) returns null. This sets threadLoaded to false and disables Create. The sheet does not show whether the thread is still loading, failed, or deleted. Use the existing statusAtom and errorAtom to show the appropriate state.

A load failure with cached data can leave threadLoaded true, so this concern applies only when no projection is available.

✅ Confirmed as addressed by @jakeleventhal

Fixed in bd6ed1a4711. While the thread data hasn't loaded, the sheet now reads statusAtom and errorAtom and shows one of: "This thread was deleted.", the load error, or "Checking for an active link…". It shows that in place of the expiry note, and Create link stays disabled. Once the data has loaded, behavior is unchanged.

@jakeleventhal Verified the fix in bd6ed1a4711. When no thread projection exists, the sheet shows the deleted state, load error, or loading message. Create link remains disabled. When a projection exists, the prior behavior is unchanged.

This addresses the finding.

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

✅ Review thread resolved.

_{You are interacting with an AI system.}