fix(mobile): honor native iOS glass appearance#24926

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This targeted iOS glass fix changes the default appearance of the shared GlassSurface, affecting existing native UI surfaces as well as the two updated callers. The fallback paths remain preserved, but the product-wide default visual behavior warrants human review.

Notes:

• All code in this push has already been reviewed. Approvability was decided on eligibility alone.

No code changes detected at 1607382. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

Review in Change Stack →

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

Earlier native verification captures, preserved while the PR description presents the complete matched 0% / 50% / 100% grids. These images include production toast placement and the earlier system-setting checks.

Matched native samples of the production home screen and composer, with demo content. System glass opacity stays at 50% throughout. Before reproduces the glass wrapper and composer-popover styles at 0191d6c647; After uses #24926 at 095538b3. Font handling is held constant within each pair, with 16 pt and 22 pt app-text examples. The iPhone home toast is held open with demo data in its normal production position. Suggestions show the app’s built-in commands. The main composer and dark toast already opt out of default chrome, so those material pairs can remain unchanged. Temporary capture controls are removed, original appearance settings are restored, and both simulator sessions are shut down.

iPhone · T3 Code light · 16 pt · Home

iPhone · T3 Code light · 16 pt · Composer

iPhone · T3 Code light · 16 pt · Composer commands

iPhone · T3 Code dark · 22 pt · Home

iPhone · T3 Code dark · 22 pt · Filtered composer commands

iPad · Iris dark · 16 pt · Home

iPad · Iris dark · 16 pt · Composer commands

@PixPMusic, your three-file fix already captures the right scope: native glass loses the decorative defaults, explicit tints remain available, and fallback rendering stays intact. I kept your implementation and commit, merged current github/main (220eb73524ca) without conflicts, and pushed 1607382a39f7d8767c70a1be2fdf952a4851c78c to this branch. The final diff is still 5 additions and 22 deletions; nothing was dropped or moved beyond your original change.

All 30 CI checks passed on the merged head. GitCafe reports it mergeable.

Verification on the merged head:

• Blacksmith vp run check:changed passed formatting, lint, both knip passes, and mobile/scripts typechecks.
• Blacksmith composer command-menu tests passed, 3/3.
• Two independent source reviews approved the final tree with no findings. Android/older-iOS fallback styling and explicit tint forwarding were inspected.
• Native rendering is unverified in this Linux VM. Chrome cannot exercise UIKit glass. The default web dev server started and was stopped; its pairing check did not establish a usable client, so it supplies no UI proof.
• An additional lint:mobile attempt could not run native analysis because the worker lacks SwiftLint, ktlint, and detekt. No Swift or Kotlin files changed; native CI remains the verification for those checks.

CodeRabbit raised one minor suggestion to restore glassEffectStyle="clear" in ComposerCommandPopover.tsx:80. I am retaining the contributor's intentional use of the shared "regular" material: the original diff explicitly removes "clear", and the supplied after captures show that choice. Restoring it would change the submitted visual result. This material choice remains part of Maria's required visual approval, not a functional blocker found by either source reviewer.

I inspected and re-uploaded the matched native composer screenshots below from your existing evidence. These are your captures, not a fresh main-versus-merged-head reproduction. Human visual approval remains required for the shared default appearance.

Contributor capture before: iPhone composer commands, light theme, 50% system glass opacity

Contributor capture after: iPhone composer commands, light theme, 50% system glass opacity

The uploaded files render at 402 × 874 in Chrome. I reopened this GitCafe comment; its renderer displays these external image references as links, so inline media rendering in the PR remains unverified.

Verified in a real dev environment

No changed runtime behavior could be verified on this Linux Boat VM. This is an unverifiable result, not a passing verification.

I read the description, discussion, reviews, and complete three-file diff. The PR is open, and its only PR commit is by PixPMusic. I created a separate github/main worktree at 949929dda5df97bc2084290fbe761c41b23665f7 and ran vp i successfully. I then checked out the exact PR head 78d10c9e3201408808f3f32c9c48083ee80b29c6 and ran vp i successfully. Both working trees remained clean.

Environment checks:

The changed native rendering branch requires Platform.OS === "ios" && isGlassEffectAPIAvailable(). The user reaches it through mobile glass surfaces, including the command palette and composer command suggestions. Chrome and a web Codex turn cannot exercise UIKit or the system glass opacity preference. I did not start a web server or submit provider turns as substitute proof. No fresh screenshots or recordings were captured, and contributor captures in the description were not treated as a reproduction on this head. No source changes or pushes were made.

GitCafe reports 28 successful checks, zero pending, zero failing on this head. CI is not runtime proof.

Not verified

The original bug on main and the fix on the PR remain unverified. A native iOS client on a supported device or macOS simulator is required to compare the same content and theme at 0%, 50%, and 100% system glass opacity. This includes the default shared surface, command palette, and composer popover, whose material changes from clear to regular.

Nearby behavior also remains unverified at runtime: explicit semantic tints, toast glass, palette selection/dismissal, composer suggestion selection, Android and older-iOS fallback rendering, and a real Codex gpt-6.1-sol turn through the native client. There is no connected Android device either. A native verification pass is still needed before calling this behavior verified.

Verified in a real dev environment

No changed runtime behavior could be verified on this Linux Boat VM. Result: unverifiable.

I inspected the full three-file diff, description, discussion, and review. The PR is open; its sole PR commit is by PixPMusic, with no commits by juliusmarminge or t3dotgg. GitCafe also identifies this as PR #24926.

This pass created a separate github/main worktree at 8d012a688e7cb12fb17a91be68a32734a0efa0b7 and successfully ran timeout 600 vp i. I then checked out the exact PR head 78d10c9e3201408808f3f32c9c48083ee80b29c6 and successfully ran timeout 600 vp i. Both trees remained clean. Source inspection confirms main still has the themed native fill, default tint, border, and shadow removed by this PR. That is source evidence, not a reproduced visual bug.

Environment transcript:

The affected rendering path requires Platform.OS === "ios" && isGlassEffectAPIAvailable(). The mobile user reaches it through shared glass surfaces, the command palette, and composer suggestions. This PR also changes the composer material from clear to the shared regular default. Chrome cannot render UIKit or apply the native system glass-opacity preference. No web server, project, thread, or provider turn was used as substitute proof. No fresh captures were possible; existing contributor screenshots are not verification performed in this pass. No source changes or pushes were made, and no dev processes were started or retained.

GitCafe reports 28 successful checks, zero pending, and zero failing for this head. Those checks do not establish native runtime behavior.

Not verified

The original bug on main and the fix on the exact PR head remain unverified. A supported native iOS device or macOS simulator is required for matched before/after captures over the same real content at 0%, 50%, and 100% system glass opacity, in light and dark themes. Check the shared glass surface, command palette, and composer suggestion popover.

Nearby runtime behavior remains unverified: explicit semantic tints, toast glass, command-palette selection and dismissal, composer suggestion selection, older-iOS and Android fallback rendering, and a real Codex gpt-6.1-sol turn through the native client using an app-created project and thread. There is no connected Android device. Native verification remains required before marking this PR verified.