feat(mobile): search Settings, and keep its sidebar header clean#24766

🟠 High workspace/WorkspaceToolbar.ios.tsx:188

On iOS without Liquid Glass, opening Settings removes the environment/project scope filter, so users cannot change their Settings scope. This condition still mounts the right Toolbar on those clients, and NativeHeaderToolbar replaces rather than merges unstable_headerRightItems; keep the fallback search button without replacing the Settings filter.

No longer relevant as of c22d89112d9a59e9645566530f2e8b0bf3202789

Fixed: without Liquid Glass, Settings now keeps its search field out (no trailing search button), and the trailing toolbar is no longer mounted for Settings outside the folded Duo, so the scope filter stays.

This still affects folded Duo without Liquid Glass: foldedSearch keeps the trailing toolbar mounted for Settings, which replaces the scope filter. Could you cover that case too?

External image Minor · Functional Correctness · Quick win

Label the visible Settings header as Settings.

When Settings is open beside a sidebar, this condition renders WorkspaceRootTitle. Its accessibility label still uses state.selectedTab, so a Settings screen opened over Threads announces “T3 Code, Threads.” Use the visible Settings scope when constructing that label.

✅ Confirmed as addressed by @juliusmarminge

Fixed: the brand title's accessibility label says Settings while Settings is open.

@juliusmarminge Confirmed in the supplied code: when Settings is open, the brand accessibility label is “T3 Code, Settings.”

✅ Review thread resolved.

_{You are interacting with an AI system.}

External image Minor · Functional Correctness · Quick win

Keep the underlying tab’s search field off the Android Settings screen.

If a Threads or Pull Requests search is active when the user opens Settings, this branch mounts the Android WorkspaceToolbar. That toolbar reads state.tabs[state.selectedTab], so it shows and edits the underlying tab’s search alongside the Settings search input. Make its Android search controls Settings-aware, or suppress those controls while Settings is open without removing the needed navigation dock.

✅ Confirmed as addressed by @juliusmarminge

Fixed: Android Settings keeps the section toolbar; its list carries its own search in the app bar, so the underlying tab's search no longer appears.

@juliusmarminge The supplied code still mounts WorkspaceToolbar on Android when state.selectedTab is "threads" or "pullRequests". Those || branches remain true while Settings is open.

Make the tab checks conditional on Settings being closed:

This selects WorkspaceSectionToolbar for Android Settings regardless of the underlying tab.

_{You are interacting with an AI system.}

You're right, the earlier change still mounted WorkspaceToolbar on Android when Settings sat over Threads or PRs. Fixed: the tab checks now only apply while Settings is closed, so Android Settings always gets WorkspaceSectionToolbar.

@juliusmarminge Confirmed in the supplied code. When Settings is open on Android, the branch selects WorkspaceSectionToolbar regardless of the underlying tab. This addresses the finding.

✅ Review thread resolved.

_{You are interacting with an AI system.}

🟡 Medium workspace/WorkspaceToolbar.ios.tsx:55

After switching from Settings to Usage, the retained Settings toolbar still handles the global focusSearch command and dispatches search to its hidden list; on Duo, it can also toggle the sidebar. The tab === "settings" shortcut ignores NativeWorkspaceTabActivityContext, so gate Settings activity on tabActive to prevent both command handling and search restoration in inactive slots.

Fixed: Settings activity is now gated on the slot's NativeWorkspaceTabActivityContext, so a retained Settings toolbar no longer handles focusSearch or restores search.