Sign up
View stargazersSign up

fix(mobile): stop defaulting new threads to the oldest project#24359

closed1
main
GitHub fork: fix/mobile-new-thread-project-fallback
opened5d agobyNnone23
2 files changed
View on GitHubTwo-way sync enabledPR last imported 1d ago

Problem

Starting a thread from Home with multiple projects selects the first (oldest) project and bypasses the picker. A stale current project takes the same fallback.

This change has been introduced by https://github.com/pingdotgg/t3code/pull/23467 and does not appear intentional

Change

Remove ?? projects[0] from mobile's newTaskDestination. Keep valid current-thread/draft selections, explicit project-specific actions, and the existing single-selectable-project shortcut on Android and iOS/iPad.

Scope and approval

Small, focused bug fix restoring the existing project-selection flow when there is no valid current project. Changes are limited to the shared mobile helper and its tests. Web and desktop are unchanged.

Verification

  • Four regression cases failed before the fix, covering missing and stale current projects in compact and split layouts. All 12 tests in new-task-project-selection.test.ts now pass.
  • vp run check:changed passes formatting, lint, knip, scoped typechecking, and focused tests.

Android emulator verification: with two synthetic projects, Home → New thread opens an Atlas draft before the fix and the project picker after it. The GIF below uses recordings of both versions, trimmed to the action with the final frames held for readability. No real project data was loaded.

Android before and after: New thread from Home automatically selects Atlas before the fix and opens the project picker after it. All projects are synthetic.

iOS/iPad device verification has not been performed.

Model: gpt-6-astra. Harness: Codex in T3 Code.

Checks

21 successful · 12 skipped
All checks passed
5256c89

Added 1 commit

  • fix(mobile): stop defaulting new threads to the first project5256c89
CcoderabbitaiBot4d ago
Synced from GitHub

Review in Change Stack →

No actionable comments were generated in the recent review.

External image Recent review info
External image Run configuration
External image Commits

Reviewing files that changed from the base of the PR and between 2c592a1086ff593293358529a1975dde308edeaf and 5256c89dee2749f96f33f0cf819661006263a661.

External image Files selected for processing: 2
  • apps/mobile/src/features/threads/new-task-project-selection.test.ts
  • apps/mobile/src/features/threads/new-task-project-selection.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

New-task drafts remain unassigned when there is no current project or when the current project does not match an available environment and project. Tests cover both cases in split and compact views.

Changes: New-task destination selection

Layer / File(s)Summary
Match the current project before assigning a destination
apps/mobile/src/features/threads/new-task-project-selection.ts, apps/mobile/src/features/threads/new-task-project-selection.test.ts		newTaskDestination no longer falls back to the first project. Tests expect drafts to remain unassigned when the current project is missing or stale, in split and compact views.

Priority: External image Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • pingdotgg/t3code#23531: Changes environment and project matching and removes an unsuccessful-match fallback in the same selection module.

Suggested labels: bugfix

Suggested reviewers: juliusmarminge

Merge Risk: External image Minimal · up to 5256c

New mobile threads can open project selection without losing the single-project shortcut. No identified issue blocks merging.

Pre-merge checks: Passed 4
Check nameStatusExplanation
Title checkPassedThe title clearly and concisely describes the primary change: preventing mobile threads from defaulting to the oldest project.
Description checkPassedThe description covers the problem, implementation, scope, approval rationale, focused test results, Android verification, screenshot evidence, and the unperformed iOS/iPad verification. It is complet…
Linked Issues checkPassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes checkPassedCheck skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the problem, implementation, scope, approval rationale, focused test results, Android verification, screenshot evidence, and the unperformed iOS/iPad verification. It is complete enough for review.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.