fix: canonicalize git.cafe pull request links#22593

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0f22c9bd-d3f1-4be0-98ef-f82d10e896d7

📥 Commits

Reviewing files that changed from the base of the PR and between 8a9d0e0dd553c5b0bd943ddfd9741d6bab0e486f and 2a3009c658f0e1e08dfb55f51d44b8f349bfc778.

📒 Files selected for processing: 11

• apps/server/src/mcp/toolkits/pullRequests/handlers.test.ts
• apps/server/src/mcp/toolkits/pullRequests/handlers.ts
• apps/server/src/orchestration-v2/Orchestrator.ts
• apps/server/src/orchestration-v2/runtimeLayer.test.ts
• packages/client-runtime/src/pullRequestLinkInput.test.ts
• packages/client-runtime/src/pullRequestLinkInput.ts
• packages/shared/src/changeRequestUrl.test.ts
• packages/shared/src/changeRequestUrl.ts
• packages/source-control-gitcafe/src/client/definition.ts
• packages/source-control-gitcafe/src/server/GitCafeSourceControlProvider.test.ts
• packages/source-control-gitcafe/src/server/GitCafeSourceControlProvider.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

The change adds shared parsing for GitCafe pull-request URLs using /pull/ and /pulls/ routes. Client and server integrations use the parser and canonicalize valid links to HTTPS /pulls/{number} URLs.

Changes: GitCafe URL normalization

Layer / File(s)	Summary
Shared URL parsing and canonicalization packages/shared/src/changeRequestUrl.ts, packages/shared/src/changeRequestUrl.test.ts	Shared helpers recognize GitCafe pull requests on git.cafe and staging.git.cafe. Valid links use the HTTPS /pulls/{number} form. Tests cover unsupported hosts and invalid pull-request numbers.
GitCafe client and provider integration packages/source-control-gitcafe/src/client/definition.ts, packages/source-control-gitcafe/src/server/GitCafeSourceControlProvider.ts, packages/source-control-gitcafe/src/server/GitCafeSourceControlProvider.test.ts	The client and provider use the shared parser for GitCafe pull-request URLs. Provider tests cover both route forms when checking out a fork.
Application link resolution and storage packages/client-runtime/src/pullRequestLinkInput.ts, packages/client-runtime/src/pullRequestLinkInput.test.ts, apps/server/src/mcp/toolkits/pullRequests/handlers.ts, apps/server/src/mcp/toolkits/pullRequests/handlers.test.ts, apps/server/src/orchestration-v2/Orchestrator.ts, apps/server/src/orchestration-v2/runtimeLayer.test.ts	Client runtime resolution, pull-request handlers, and orchestration link paths store canonicalized URLs. Tests cover link commands and projection rebuilds.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge, scottn-pv

GitCafe pull-request links using either the pull or pulls route are now recognized and stored in the canonical pulls form. No actionable merge-blocking risk was identified.

The change is narrowly scoped to accepting equivalent GitCafe links and storing one canonical format. Existing host and credential restrictions remain in place. No new security weakness was verified, although concurrent and interrupted updates were not fully validated.

Retained concerns No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The changed attack surface is user-supplied pull-request references flowing into thread associations and GitCafe retrieval or checkout. Recognition expands to another route on the two existing hosts, not to arbitrary destination hosts or new credential authorities.

Trust Boundaries and Controls

• observed — Credential selection remains host-scoped: environment credentials require a matching configured host, settings credentials are restricted to production, and CLI lookup receives the selected host. Existing tests explicitly reject production-to-staging and staging-to-production environment-token reuse.

Resilience and Maintainability Implications

• observed — Link deduplication, ordinary unlinking, and stack-dismissal restoration continue to use normalized identity rather than URL spelling. The unchanged commit mechanism reserves the command receipt, appends events, applies projections, and finalizes the receipt inside a transaction before publishing. Duplicate command IDs reuse the recorded result. These mechanisms provide counterevidence to partial-state concerns, but are not direct validation of every concurrent or interrupted link transition.

Check name	Status	Explanation
Title check	Passed	The title clearly and concisely describes the main change: canonicalizing GitCafe pull request links.
Description check	Passed	The description explains the problem, implementation, affected behavior, and verification results in sufficient detail. It does not include an explicit issue or maintainer approval link, but the focus…
Linked Issues check	Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, implementation, affected behavior, and verification results in sufficient detail. It does not include an explicit issue or maintainer approval link, but the focused scope and review evidence provide adequate context.

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR