revert: fourteen unverified desktop fixes from the takeover campaign#22222

merged14

main

revert/unverified-desktop

opened4d agobyJJulius Marminge

49 files changed

View on GitHubTwo-way sync enabledPR last imported 4d ago

Reverts the fourteen desktop-only fixes the takeover campaign merged between 2026-10-19 18:58Z and 2026-10-20 05:33Z. All of them landed on green CI and clean code audits, and none of them was run on a real desktop build. #20907 from the same set broke every existing install (#22219), and nothing in the fleet can verify Electron changes, so the rest come out too until each one has been exercised on a real build with existing user state on the platforms it touches.

One revert commit per PR, newest first, so any single one can be dropped from this branch or re-landed on its own:

#20303 let lifecycle shutdown finish before exiting
#19706 show connecting splash while the local backend starts
#19300 stop blocking the renderer during topology polling
#21273 retry a timed-out Windows update signature check once
#19589 avoid temporary icon copies on Linux launches
#19931 capture fresh pixels from background previews
#18095 restart prompt returns after relaunching with a downloaded update
#19377 read Chromium cookies stored as text
#19467 a slow PowerShell profile delays Windows startup by 5 s, not 10 (conflicted with #7894's Nushell imports; resolved by keeping those imports and dropping the now-unused Clock and test imports)
#21225 skip WSL distro probing while the WSL backend is off
#19232 allow half-screen tiling on scaled displays
#15995 register Windows OAuth callbacks with the app entry point
#18808 an AppImage launch drops earlier launches' mount dirs from the server PATH
#12978 skip auxiliary macOS snapshot windows

The original PRs stay closed; each gets a comment pointing here and stating what re-landing needs.

🤖 Generated with Claude Code

Checks

All checks passed

CodeRabbitGitHub
Review skipped
Successful
Verify preview eligibilityGitHub
Skipped
Publish anonymous downloadGitHub
Skipped
Package and sign macOS arm64 previewGitHub
Skipped
Remove preview downloadGitHub
Successful
CheckGitHub
Successful
Mobile Native Static AnalysisGitHub
Skipped
RustGitHub
Skipped
Release SmokeGitHub
Successful
TestGitHub
Successful
Test WebGitHub
Successful
Build and TypecheckGitHub
Successful
Label PR 22222GitHub
Successful
Sync PR size label definitionsGitHub
Skipped
Label PR sizeGitHub
Successful
Macroscope - UI ConsistencyGitHub
Skipped
Macroscope - Effect Service ConventionsGitHub
Skipped
Macroscope - Approvability CheckGitHub
Neutral
Macroscope - Approvability CheckGitHub
Neutral
Macroscope - Correctness CheckGitHub
Successful
EAS PreviewGitHub
Skipped
Macroscope - Correctness CheckGitHub
Successful
POST to CursorGitHub
Successful
Prepare PR size configGitHub
Successful
Collect PR targetsGitHub
Successful
Test Server 4GitHub
Successful
Test Server 8GitHub
Successful
Test Server 5GitHub
Successful
Test Server 6GitHub
Successful
Test Server 7GitHub
Successful
Test Server 1GitHub
Successful
Test Server 3GitHub
Successful
Test Server 2GitHub
Successful
LintGitHub
Successful
ChangesGitHub
Successful
Native fingerprint diffGitHub
Successful

Added 14 commits4d ago

Revert "fix(desktop): skip auxiliary macOS snapshot windows (#12978)"1143043
Revert "perf(desktop): show connecting splash while the local backend starts (#19706)"38b20f5
Revert "fix(desktop): let lifecycle shutdown finish before exiting (#20303)"3a352db
Revert "fix(desktop): a slow PowerShell profile delays Windows startup by 5 s, not 10 (#19467)"4c3db70
Revert "fix(desktop): register Windows OAuth callbacks with the app entry point (#15995)"78d0790
Revert "fix(desktop): stop blocking the renderer during topology polling (#19300)"9dba745
Revert "fix(desktop): restart prompt returns after relaunching with a downloaded update (#18095)"a6202ec
Revert "fix(desktop): allow half-screen tiling on scaled displays (#19232)"af18e1b
Revert "fix(desktop): skip WSL distro probing while the WSL backend is off (#21225)"b83a9da
Revert "fix(desktop): capture fresh pixels from background previews (#19931)"bab7c66
Revert "fix(desktop): avoid temporary icon copies on Linux launches (#19589)"be1cab9
Revert "fix(desktop): an AppImage launch drops earlier launches' mount dirs from the server PATH (#18808)"e9b9b33
Revert "fix(desktop): read Chromium cookies stored as text (#19377)"ef5a43b
Revert "fix(desktop): retry a timed-out Windows update signature check once (#21273)"f3108e2

MmacroscopeappBot4d ago

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This rollback changes behavior across desktop lifecycle, updates, IPC, previews, platform integration, and web UI rather than being a narrow mechanical revert. It also raises the desktop window minimum width from 600 to 840, changing a product default.

^{You can add or adjust custom eligibility rules. Learn more.}

Ggithub-actionsBot4d ago

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	+7 B (+0.1%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+7 B (+0.6%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.9 KiB	0 B (0.0%)	29.3 KiB	✅
Codex	Live turn messages	2	2	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	−7 B (−0.1%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	−7 B (−0.6%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	0 B (0.0%)	29.3 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: 41b513d · PR result: 4c3db70 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 108.5 KiB
Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.