Removes comments that repeat the code, document the obvious, or record history, in source and tests. Agents copy these into new files, where they go stale. A comment stays only when someone reading the code would likely break something without it: a security check, a race, a provider or OS quirk, or an invariant another file relies on. Lint directives, knip tags, and suppression reasons stay. Comment lines in the touched files drop from 63,684 to 18,432. Outside the lint rule below, code is unchanged: every pruned file parses to the same syntax tree as main.
A new t3code/no-low-value-comments lint rule keeps the mechanical cases out: section dividers, Arrange/Act/Assert labels, TODOs without an issue link, JSDoc types in TypeScript, empty @param/@returns tags, commented-out code, and comments that only repeat the name below them. AGENTS.md now tells agents that comments say why.
To check the effect on agents, gpt-6.1-sol did the same 10 tasks on main and on an earlier cut of this branch. 6 judges compared each pair without knowing which was which. 21 verdicts favored main, 18 favored the branch, and 21 were ties. Tokens, files read, and time stayed within 6%. The bench has not been rerun on this cut.
Done by claude-opus-5-5 (Claude Code) coordinating gpt-6.1-sol (Codex) subagents.
Review skipped: 2994 files exceed the limit of 300
Verdict: Needs Human Approval
Macroscope's review found this PR requires human approval — The PR is largely a mechanical comment cleanup with a development-only lint rule and no apparent product behavior changes. Its mobile fingerprint inputs nevertheless trigger the repository's native-change flow, which can block production OTA delivery until a new store build ships.
You can add or adjust custom eligibility rules. Learn more.
✅ Thread transfer remains within every enforced ceiling.
| Provider | Metric | Main baseline | This PR | Impact | PR ceiling | |
|---|---|---|---|---|---|---|
| Codex | Total thread wire | 5.0 KiB | 4.9 KiB | −30 B (−0.6%) | 6.8 KiB | ✅ |
| Codex | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Codex | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | −30 B (−2.5%) | 2.0 KiB | ✅ |
| Codex | Live turn WebSocket decoded | 20.9 KiB | 20.8 KiB | −41 B (−0.2%) | 29.3 KiB | ✅ |
| Codex | Live turn messages | 2 | 1 | −1 (−50.0%) | 8 | ✅ |
| Claude | Total thread wire | 5.0 KiB | 5.0 KiB | +31 B (+0.6%) | 6.8 KiB | ✅ |
| Claude | Thread snapshot wire | 3.8 KiB | 3.8 KiB | 0 B (0.0%) | 4.9 KiB | ✅ |
| Claude | Live turn WebSocket wire | 1.2 KiB | 1.2 KiB | +31 B (+2.6%) | 2.0 KiB | ✅ |
| Claude | Live turn WebSocket decoded | 21.2 KiB | 21.2 KiB | +41 B (+0.2%) | 29.3 KiB | ✅ |
| Claude | Live turn messages | 1 | 2 | +1 (+100.0%) | 8 | ✅ |
Baseline: ba35822 · PR result: 391c8d3 · Source CI: success
10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.
Added 4 commits
Added 2 commits
Note
Written by claude-opus-5-5 on behalf of Maria
The frozen-lockfile change in scripts/setup-worktree.ts comes from main (#19747) via the merge. Against main, this PR only removes the doc comment in that file. Every changed file has the same syntax tree as main once comments are stripped, so this PR changes no runtime code.
Added 2 commits
| … | … | @@ -0,0 +1,118 @@ | |
| 8 | + | const TASK_MARKER_PATTERN = /\b(?:TODO|FIXME|XXX|HACK)\b/u; | |
| 9 | + | const TASK_LINK_PATTERN = /#\d+|https?:\/\//u; | |
| 10 | + | const JSDOC_TYPE_PATTERN = /^@(?:param|returns?|type|typedef)\s+\{/u; | |
| 11 | + | const EMPTY_JSDOC_TAG_PATTERN = /^@(?:param|returns?)(?:\s+\[?[\w$.]+\]?)?$/u; | |
🟡 Medium rules/no-low-value-comments.ts:11
A one-word return description such as @returns milliseconds is reported as an empty JSDoc tag, so meaningful documentation is rejected. The pattern allows an optional word after both @param and @returns; only parameter tags have a name to skip. Match an optional name only for @param, and match @returns only when it has no following text.
| 1 | In file @oxlint-plugin-t3code/rules/no-low-value-comments.ts around line 11: |
| 2 | |
| 3 | A one-word return description such as `@returns milliseconds` is reported as an empty JSDoc tag, so meaningful documentation is rejected. The pattern allows an optional word after both `@param` and `@returns`; only parameter tags have a name to skip. Match an optional name only for `@param`, and match `@returns` only when it has no following text. |
Note
Written by claude-opus-5-5 on behalf of Maria
Fixed in 56df2bd07c: only @param skips a name now, so @returns milliseconds passes and a bare @returns is still flagged.
Added 1 commit
