fix(server): Claude no longer shows unavailable when its health check can't run in $HOME #19320 · pingdotgg/t3code

	Where the spawns ran	Claude status
main	`--version` in `$HOME`	`error`: installed but failed to run
main, shim refusal off	`--version` and SDK probe in `$HOME`	ready
this PR	both in `<base-dir>/userdata`	ready, authenticated

MmacroscopeappBotapproved these changes29d ago

Approvability

Verdict: Approved at 8f42bc6

Macroscope's review found this PR approvable — This is a focused server bug fix that moves only instance-level Claude probes to the existing state directory, while preserving project-scoped workspace and session execution. A live regression test covers the packaged-desktop cwd scenario, and no product defaults or static-analysis settings are changed.

^{You can add or adjust custom eligibility rules. Learn more.}

Ggithub-actionsBot29d ago

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	4.9 KiB	5.0 KiB	+23 B (+0.5%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+23 B (+1.9%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.8 KiB	20.9 KiB	+41 B (+0.2%)	29.3 KiB	✅
Codex	Live turn messages	1	2	+1 (+100.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	−7 B (−0.1%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	−7 B (−0.6%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	0 B (0.0%)	29.3 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: 614b432 · PR result: 8f42bc6 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 108.5 KiB
Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

CcoderabbitaiBot29d ago

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.config.ts
Review profile: CHILL
Plan: Team
Run ID: 25283be5-a5bf-42f1-82cf-2b7be7cff085

📥 Commits

Reviewing files that changed from the base of the PR and between 614b432a79b0acae38c27c00b1e4eece223ecfe4 and 8f42bc660d06a67527682f67c8564cb98bd115c4.

📒 Files selected for processing: 4

apps/server/src/provider/ClaudeProvider.ts
apps/server/src/provider/Drivers/ClaudeDriver.ts
apps/server/src/provider/ProviderInstanceRegistry.test.ts
apps/server/src/provider/testing/ProviderInstanceRegistryLive.fixture.mjs

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

📝 Walkthrough

Claude instance-level capability probes and provider-status checks now run from the server state directory. Claude command execution accepts an explicit working directory. Workspace snapshot probes continue to use the thread working directory.

Changes: Claude probe working directory

Layer / File(s)	Summary
Explicit working directory for Claude probes `apps/server/src/provider/ClaudeProvider.ts`, `apps/server/src/provider/Drivers/ClaudeDriver.ts`, `apps/server/src/provider/ProviderInstanceRegistry.test.ts`, `apps/server/src/provider/testing/ProviderInstanceRegistryLive.fixture.mjs`	`runClaudeCommand` accepts and uses an optional `cwd`, which the provider-status version check now supplies. Instance-level probes, capability-cache keys, and status checks use `stateDir`; workspace snapshot probes retain the thread `cwd`. The fixture can reject an unexpected working directory, and a live test checks readiness, version, and authentication.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 8f42b

Claude’s instance-level probes now use the server state directory, while workspace probes retain their thread directory. No merge-blocking issue is established; the change appears ready for normal checks.

Pre-merge checks: ^Passed 4

^Passed Passed checks: 4 passed

Check name	Status	Explanation
Title check	Passed	The title clearly and concisely describes the primary fix: Claude no longer reports unavailable when health checks inherit an unsuitable $HOME working directory.
Description check	Passed	The description explains the problem, affected behavior, implementation scope, issue reference, verification steps, observed results, and test coverage. It uses "Fix" and "Proof" headings instead of t…
Linked Issues check	Passed	Issue `#2867` requires Claude auxiliary probes to use an explicit scoped working directory. `ClaudeDriver.create` now uses `stateDir` for the capability probe, capability cache key, and provider status …
Out of Scope Changes check	Passed	The changed driver code, command cwd support, registry test, and opt-in fixture guard all directly verify or implement issue `#2867`. The test and fixture changes are supporting automated coverage. No u…

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

fix(server): Claude no longer shows unavailable when its health check can't run in $HOME#19320

Fix

Proof

Checks

Approvability

Thread transfer impact