fix(desktop): allow V1 and V2 to run concurrently#12480

This wraps every filesystem failure in the pipeline with only the destination directory, so failures while probing or reading the source lose the resource and stage where they occurred. The error convention requires structured, bounded context at the known translation boundary.

Suggested fix: map each fallible filesystem operation where it occurs, recording the relevant source/destination path, stage, and normalized filesystem category while preserving the immediate error as cause.

^{Posted via Macroscope — Effect Service Conventions}

Fixed in ace0d4421df. Each filesystem operation now records its operation and relevant resource path, normalizes the category from the filesystem reason, and preserves the immediate error as cause. Added a regression test for a failed source read; focused tests, lint, and desktop typecheck pass.

This hides Path.Path by extracting a service instance from DesktopEnvironment and providing it manually. Production Effect dependencies should remain in the operation’s environment so make/layer expose them for composition. Let resolveUserDataPath acquire Path.Path from context directly, and remove the now-unused Path import.

^{Posted via Macroscope — Effect Service Conventions}

Fixed in 7aad2a497bd. Identity now captures the FileSystem and Path dependencies from the Effect context during make, so both requirements are exposed in its make/layer types. The deferred resolution operation uses that context, following DesktopAssets.make, and no longer extracts Path from DesktopEnvironment. All 20 focused tests, targeted lint, and desktop typecheck pass.

This manually injects the Path.Path service stored inside another service, hiding the dependency from DesktopClerk.make and its layer. Let resolveUserDataPath acquire Path.Path from the Effect environment and remove the now-unused Path import.

^{Posted via Macroscope — Effect Service Conventions}

Fixed in 7aad2a497bd. Clerk now calls the shared helper without supplying a Path service; its make/layer expose Path.Path for composition through NodeServices. The existing tests now supply NodePath.layerPosix explicitly. All 20 focused tests, targeted lint, and desktop typecheck pass.

🟠 High app/DesktopUserData.ts:63

The upgrade skips importing Windows safeStorage keys when T3 Code (Alpha) exists without Local State, even if the V1/nightly t3code profile contains it, leaving saved connection credentials inaccessible. The sourcePath selection checks only whether the Alpha directory exists; select the source based on each candidate's Local State instead, falling back to t3code when Alpha lacks it.

Fixed in 7f1069e9e58. Source selection now checks the legacy Local State file and falls back to the nightly file when the Alpha directory is empty. The existing nightly credential-preservation test now creates that empty Alpha directory; it fails before the fix and passes after it. All 20 focused tests, targeted lint, and desktop typecheck pass.

🟠 High app/DesktopUserData.ts:60

resolveUserDataPath returns a nonexistent t3code-v2 directory on fresh non-Windows launches and on Windows when no legacy Local State exists, so the subsequent Electron.app.setPath("userData", ...) throws and aborts startup. Create destinationPath before each of these returns.

Verified as a false positive with an isolated native Electron 44.4.2 process, the version pinned on this branch. Before ready, app.setPath(userData, target) succeeded for a nonexistent nested directory, and app.getPath(userData) returned that target. Result: {electron:44.4.2,existsBefore:false,setPathSucceeded:true,pathMatches:true,existsAfter:false}. The pinned implementation uses OverrideAndCreateIfNeeded with is_absolute=true and create=false: https://github.com/electron/electron/blob/v44.4.2/shell/browser/api/electron_api_app.cc#L893-L904. The SDK subsequently acquires the profile lock and creates its directory. This does not abort startup, so no extra filesystem initialization is needed.